That's huge, Thank you Roberciiik!

I fear pro5 is no longer around to update this (which is a 2014 release) but perhaps updating the .tp2 to be compatible with 1.22 is a simple enough operation?

Yes, it is.

1 line need to be updated :

REQUIRE_PREDICATE MOD_IS_INSTALLED "setup-bgtmusic.tp2" "2" ~BGTMusic component 2 is not installed, SONGLIST.2DA is missing required BGT/BGII song entries~

by

REQUIRE_PREDICATE ((MOD_IS_INSTALLED "setup-bgtmusic.tp2" "2") OR (ID_OF_LABEL ~bgt.tp2~ ~A6-BGT-MusicFull~) OR (ID_OF_LABEL ~bgt.tp2~ ~A6-BGT-MusicHybrid~) OR (ID_OF_LABEL ~bgt.tp2~ ~A6-BGT-MusicBG1~)) ~BGTMusic component is not installed, SONGLIST.2DA is missing required BGT/BGII song entries~

I'm not sure if I understand. BGT music was always intended to be installed right after the core component. This is because other mods need to know the contents of the song list. Otherwise how are you supposed to add an area for your NPC mod with BG1 music if you don't know what the song number will turn out to be at the end of the installation chain? And as far as I know, the reasons it's a separate component with options are 1) not every platform supports executable patching (e.g., macOS) and 2) the player was supposed to understand and accept the risks of hacking the executable.

Again, this was to provide an intermediate solution, not a structural one. As far as I know, no mod checks songlist.2da; so for the time being, installing this component just after, in the middle or at the end makes no difference.

The music component used to be a separate mod, and the readme was as follows:

Baldur’s Gate and Tales of the Sword Coast music

Music is installed during Baldur’s Gate Trilogy-WeiDU installation, but is not activated.

To activate Baldur’s Gate and Tales of the Sword Coast music, run Setup-BGTMusic.exe in your Baldur’s Gate Trilogy-WeiDU installation directory. Three options are available:

 

• Full Baldur’s Gate and Tales of the Sword Coast music: Activates all original Baldur’s Gate and Tales of the Sword Coast music. If you play Shadows of Amn and/or Throne of Bhaal with this component installed, the music heard will be incorrect. For best results, when you decide that you want to play Shadows of Amn and/or Throne of Bhaal, uninstall this component to restore the default music for Shadows of Amn and Throne of Bhaal.
• Hybrid Baldur’s Gate/Shadows of Amn/Throne of Bhaal music: Keeps all music for Shadows of Amn and Throne of Bhaal, but activates only some music for Baldur’s Gate and Tales of the Sword Coast. Effort has been made to ensure the music is as appropriate as possible for each area.
• Full Baldur's Gate/Shadows of Amn/Throne of Bhaal Music (WARNING: patches BGMain.exe): Utilises a hack to the executable created by Taimon to allow all Baldur's Gate I and Baldur's Gate II music to be used. The executable hack increases the numbers of SONGLIST.2DA rows supported by the game. Use at your own risk.
• Install none: No Baldur’s Gate and Tales of the Sword Coast music will be heard in the corresponding portion of the game. The music heard during Baldur’s Gate and Tales of the Sword Coast will sound inappropriate.

 

If you intend to install other modifications with Baldur’s Gate Trilogy-WeiDU, it is recommended that you install the music as close to the end of the installation chain as possible. This will allow you to uninstall this modification easily and avoid possible compatibility issues.

So installing at the end was at this time recommanded - this is from v1.21 and things may have changed of course.

Come on, you're saying it as if it had worked before and only now it didn't. Let's get the facts straight: some of these mods weren't even originally developed with BGT in mind and only later the authors/maintainers released newer versions with BGT support. So, who introduced the issues: the author of BGT music or the authors of the respective mods which were intended to be installed on top of BGT?

 

In principle, it just isn't correct to do things backwards and, at least in my opinion, these issues aren't important enough to warrant a temporary patch that doesn't give me the satisfaction of a good solution. If somebody wants to play these mods, for now they can do a custom install with your suggestions or use a different option for BGT music.

That wasn't my intention, I was just saying that there's no direct answer, it's not as if there are any clear rules to follow, maybe some are better than others but some take less time: it depends on your motivation.

But your point is clear and I won't bore you with it any further.

What? I didn't say a year. I said I'd look at your list. Thank you; it's very helpful, by the way

Sorry, but I wasn't aiming for anyone... that's more or less the time between updates of the old BG mods.

Anyway, it's good to know that it helps to move forward; the list should cover all the areas that need addressing.

I understand  

But, it was a BGT component that introduced this incompatibility, so it could also be resolved by it. I'll rename the PR: Compatibility issue.

For players who want to play BGT-Weidu with these mods and the Full music patch, the wait for updates is likely to be long, very long (over a year for some and even longer for Bonehill)... Don't get me wrong, it's not a problem but a fact, as you said it's a hobby... Besides, I could help you if you need it (for bonehill perhaps).

From my point of view, this PR solves the problem if you install the component after these mods, but it doesn't create any problem; it would still be buggy if it was installed before, so there's no harm done. In any case, when these mods are updated, you'll have the better of the two: install before or after. I'd rather have a 2-way solution than a one-way one...

BG2 modding is already a challenge... look at 1pp, it should be split into 2 or 3 parts, 1pp music needs 3 mods when installed on bgt, IA used to have separate packages to install, has a component that needs to be manually disabled and should be installed in 2 or 3 parts... the list is quite long. So installing one BGT component at the end of a list won't make any difference, in fact that's why you have the component, to split the installation process...

But well, it's up to you and thank you very much

Hi Skellytz,

As long as those above mods are not updated, the music is not working as intended... I have open a PR (https://github.com/S...T-WeiDU/pull/78) that could, in the meantime, solve the probleme if the component "Full Baldur's Gate/Shadows of Amn/Throne of Bhaal Music" is installed after them.

Cheers