Jump to content


Photo

Journal entries not erased


  • This topic is locked This topic is locked
16 replies to this topic

#1 OneEyedPhoenix

OneEyedPhoenix
  • Member
  • 308 posts

Posted 18 September 2009 - 12:45 PM

I have encountered a bug with the "talking chicken quest".
After Melicamp was successfully transformed back into a human the three previous journal entries were not erased. (Although a entry was added to "done quests")

Change log:
[codebox]
Mods affecting THALAN.DLG:
00000: /* from game biffs */ ~BG2FIXPACK/SETUP-BG2FIXPACK.TP2~ 0 0 // BG2 Fixpack - Core Fixes
00001: /* from game biffs */ ~SETUP-BGT.TP2~ 0 0 // Baldur's Gate Trilogy - Core
00002: /* from game biffs */ ~SETUP-VAULT.TP2~ 0 0 // The Vault (erebusant's rework for BGT compatibility)
00003: ~SETUP-THALAN.TP2~ 0 0 // Thalantyr - Item Upgrade
00004: ~BG1NPC.TP2~ 0 1 // The BG1 NPC Project: Banters, Quests, and Interjections
00005: ~BG1UB/SETUP-BG1UB.TP2~ 0 1 // The Mysterious Vial
00006: ~CURSED_ITEMS/CURSED_ITEMS.TP2~ 0 0 // Salk's cursed items revisions
00007: ~SETUP-XPMOD.TP2~ 0 12 // Reduce to 50%[/codebox]

Incompatibility with BG1NPC perhaps? I Remember Minsc interjecting something.
If I understand the scripting correctly this might have prevented Thalantyr's dialogue from erasing the journal entries...?

Edited by OneEyedPhoenix, 20 October 2009 - 08:28 AM.


#2 Ascension64

Ascension64
  • Modder
  • 5983 posts

Posted 19 September 2009 - 12:18 AM

Do you have a saved game before transforming Melicamp back that you could compress and attach here?

--------------
Retired Modder
Note: I do not respond to profile comments/personal messages in regards to troubleshooting my modifications. Please post on the public forums instead.

Baldur's Gate Trilogy-WeiDU and Mods
Throne of Bhaal Extender (TobEx)

Contributions: (NWN2) A Deathstalker (voice acting) - (IWD2) IWD2 NPC Project (soundset editing) - (Misc) SHS PC Soundsets (voice acting)
Legacy: (BG/Tutu/BGT) Beregost Crash Fixer 1.9 (18 Jul 10) - (BG2) Enable conversations with charmed/dominated creatures (18 Jul 10) - (BG2) Experience Corrections (18 Jul 10) - (Misc) Platform Conversion Utility RC2 (13 Feb 10)


#3 OneEyedPhoenix

OneEyedPhoenix
  • Member
  • 308 posts

Posted 19 September 2009 - 12:45 AM

Do you have a saved game before transforming Melicamp back that you could compress and attach here?


Yup. Here you go. Minsc does indeed interject and changes the end of the conversation. I'm quite certain this is a bg1npc bug.

Edited by OneEyedPhoenix, 28 September 2009 - 07:11 AM.


#4 Ascension64

Ascension64
  • Modder
  • 5983 posts

Posted 21 September 2009 - 12:48 AM

Actually, this was a reported bug from previously: http://www.shsforums...&...st&p=457105. This is fixed for BGT v1.08.

--------------
Retired Modder
Note: I do not respond to profile comments/personal messages in regards to troubleshooting my modifications. Please post on the public forums instead.

Baldur's Gate Trilogy-WeiDU and Mods
Throne of Bhaal Extender (TobEx)

Contributions: (NWN2) A Deathstalker (voice acting) - (IWD2) IWD2 NPC Project (soundset editing) - (Misc) SHS PC Soundsets (voice acting)
Legacy: (BG/Tutu/BGT) Beregost Crash Fixer 1.9 (18 Jul 10) - (BG2) Enable conversations with charmed/dominated creatures (18 Jul 10) - (BG2) Experience Corrections (18 Jul 10) - (Misc) Platform Conversion Utility RC2 (13 Feb 10)


#5 OneEyedPhoenix

OneEyedPhoenix
  • Member
  • 308 posts

Posted 21 September 2009 - 01:07 AM

Actually, this was a reported bug from previously: http://www.shsforums...&...st&p=457105. This is fixed for BGT v1.08.


Good Job! :cheers:

#6 OneEyedPhoenix

OneEyedPhoenix
  • Member
  • 308 posts

Posted 29 September 2009 - 06:55 AM

I found another journal entry error.
The "Zombie infestation" quest deletes the wrong journal entry upon completion.
The "action" to the "state 3" looks like this in my copy of wenric.dlg:

[codebox]AddexperienceParty(400)
GivePartyGold(150)
IncrementGlobal("ZombiesDead","GLOBAL",1)
EraseJournalEntry(104875) // A zombie infestation. I slew twenty zombies ploughing around in Wenric's farm. I don't know where they came from, but they shouldn't trouble him again.
ReputationInc(1)[/codebox]

where it should look like this:

[codebox]AddexperienceParty(400)
GivePartyGold(150)
IncrementGlobal("ZombiesDead","GLOBAL",1)
EraseJournalEntry(104405) // A zombie infestation. A zombie infestation has been terrorizing the few settlers unlucky enough to own land by the river. An old farmer by the name of Wenric has counted twenty of them and will pay me an impressive 150 gp if I can get rid of every last one.
ReputationInc(1)[/codebox]

#7 OneEyedPhoenix

OneEyedPhoenix
  • Member
  • 308 posts

Posted 04 October 2009 - 03:24 AM

You seem preoccupied with other things ascension64...
Regardless, I will post these bugs as I find them so you can use the information at your own leisure.

Scar.dlg needs to have a "EraseJournalEntry(104251)" at "end node#71" in order to remove the "investigate the mysterious disappearance of citizens" quest from the journal.

Shopkn.dlg (nashkel store) should also have a "EraseJournalEntry(104417)" at end node 7 and 8 in order to remove the "in want of winter wolf pelts" quest.

Edited by OneEyedPhoenix, 04 October 2009 - 03:39 AM.


#8 10th

10th
  • Member
  • 621 posts

Posted 04 October 2009 - 07:25 AM

Shopkn.dlg (nashkel store) should also have a "EraseJournalEntry(104417)" at end node 7 and 8 in order to remove the "in want of winter wolf pelts" quest.


You wouldn't happen to have SCS installed? SCS modiefies shopkn.dlg so that only one winter wolf pelt will ever be taken. Unless BGT changed this shopkeeper, he'll pay you for every winter wolf pelt you bring him. That's original BG1 behaviour.

If it's SCS you'd have to report it to DavidW over at Gibberlings3, if it hasn't been fixed already.

10th
Avast! You cannot defeat our titan-mounted submarine staffed by cannibal vikings! - Nodwick

"I grab his deceased spirit and piledrive it back into his body, duplicating raise dead." - Psyren Oots board

#9 OneEyedPhoenix

OneEyedPhoenix
  • Member
  • 308 posts

Posted 04 October 2009 - 07:47 AM

Shopkn.dlg (nashkel store) should also have a "EraseJournalEntry(104417)" at end node 7 and 8 in order to remove the "in want of winter wolf pelts" quest.


You wouldn't happen to have SCS installed? SCS modiefies shopkn.dlg so that only one winter wolf pelt will ever be taken. Unless BGT changed this shopkeeper, he'll pay you for every winter wolf pelt you bring him. That's original BG1 behaviour.

If it's SCS you'd have to report it to DavidW over at Gibberlings3, if it hasn't been fixed already.

10th


Ok, thanks for pointing it out 10th.

#10 Ascension64

Ascension64
  • Modder
  • 5983 posts

Posted 09 October 2009 - 03:03 PM

wenric.dlg
The vanilla BGT action looks like this:

AddexperienceParty(800)
GivePartyGold(150)
IncrementGlobal("ZombiesDead","GLOBAL",1)
EraseJournalEntry(74643) // A zombie infestation. A zombie infestation has been terrorizing the few settlers unlucky enough to own land by the river. An old farmer by the name of Wenric has counted twenty of them and will pay me an impressive 150 gp if I can get rid of every last one.

So which mod changes the action?

scar.dlg
Again, there is no problem here with vanilla BGT. Which mod changes the outcome of this quest?

Edited by Ascension64, 09 October 2009 - 03:13 PM.

--------------
Retired Modder
Note: I do not respond to profile comments/personal messages in regards to troubleshooting my modifications. Please post on the public forums instead.

Baldur's Gate Trilogy-WeiDU and Mods
Throne of Bhaal Extender (TobEx)

Contributions: (NWN2) A Deathstalker (voice acting) - (IWD2) IWD2 NPC Project (soundset editing) - (Misc) SHS PC Soundsets (voice acting)
Legacy: (BG/Tutu/BGT) Beregost Crash Fixer 1.9 (18 Jul 10) - (BG2) Enable conversations with charmed/dominated creatures (18 Jul 10) - (BG2) Experience Corrections (18 Jul 10) - (Misc) Platform Conversion Utility RC2 (13 Feb 10)


#11 Lollorian

Lollorian

    smiley addict

  • Member
  • 4150 posts

Posted 09 October 2009 - 08:17 PM

wenric.dlg gets changed by the NTotSCv171a patch. The code in the NTotSCDLGFixBG1NPC.d seems to be:
REPLACE_SAY WENRIC 12 @36
ALTER_TRANS WENRIC BEGIN 2 END BEGIN 0 END BEGIN ~ACTION~ ~AddexperienceParty(800) GivePartyGold(150) IncrementGlobal("ZombiesDead","GLOBAL",1) EraseJournalEntry(@38) ReputationInc(1)~ END
ALTER_TRANS WENRIC BEGIN 2 END BEGIN 0 END BEGIN ~EPILOGUE~ ~GOTO NTWENRIC1~ END
ADD_STATE_TRIGGER WENRIC 5 ~GlobalLT("ZombiesDead","GLOBAL",21)~
ADD_STATE_TRIGGER WENRIC 12 ~GlobalLT("RevealAR01PB","GLOBAL",1)~
ALTER_TRANS WENRIC BEGIN 12 END BEGIN 0 END BEGIN ~ACTION~ ~RevealAreaOnMap("AR01PB") SetGlobal("RevealAR01PB","GLOBAL",1)~ END
APPEND WENRIC
IF ~Global("ZombiesDead","GLOBAL",21) Global("RevealAR01PB","GLOBAL",1)~ THEN BEGIN NTWENRIC1
  SAY @37
  IF ~~ THEN EXIT
END
END

scar.dlg probably gets changed to that by BG1UB's Scar and Sashenstar's Daughter component (although I couldn't figure out which line OneEyedPhoenix was pointing at :P) but that component adds a dialog state to the .dlg (which I think OEPhoenix thinks is the error)

Cheers,
Lol

"I am the smiley addict, yellow and round, this is my grin :D when I'm usually around :P.
When there's trouble brewing, see me post, cuz it's usually a wall o' yellow and your eyes are toast!!!"

BWP GUIDE - BWP FIXES - impFAQ - NPC LIST - KIT LIST - AREA LIST

GitHub Links : BWP Fixpack | Lolfixer | BWP Trimpack | RezMod


#12 OneEyedPhoenix

OneEyedPhoenix
  • Member
  • 308 posts

Posted 10 October 2009 - 01:37 AM

wenric.dlg gets changed by the NTotSCv171a patch. The code in the NTotSCDLGFixBG1NPC.d seems to be:


Another NtotSC issue? One of these days I am going to do something nasty I think... :angry:

I will do some proper checkups of the dlg files once I get my game back up and running.

I refer to lines in the way Dltcep lists them Lollorian.

Edited by OneEyedPhoenix, 10 October 2009 - 01:39 AM.


#13 Lollorian

Lollorian

    smiley addict

  • Member
  • 4150 posts

Posted 10 October 2009 - 03:08 AM

Call it coincidence but I just started using DLTCEP from yesterday :woot: (just to try and catch errors, it generated a lotta reports :whistling:)

But still, depending on the mods we install, your end node #71 might not match my end note#71 :P My end node #71 is the "thanks for returning the body, have 3000 gold ..." line that got added by BG1UB's component. It should be reported to the BG1UB forums if that's the case :D

Cheers,
Lol

"I am the smiley addict, yellow and round, this is my grin :D when I'm usually around :P.
When there's trouble brewing, see me post, cuz it's usually a wall o' yellow and your eyes are toast!!!"

BWP GUIDE - BWP FIXES - impFAQ - NPC LIST - KIT LIST - AREA LIST

GitHub Links : BWP Fixpack | Lolfixer | BWP Trimpack | RezMod


#14 OneEyedPhoenix

OneEyedPhoenix
  • Member
  • 308 posts

Posted 10 October 2009 - 05:53 AM

Call it coincidence but I just started using DLTCEP from yesterday :woot: (just to try and catch errors, it generated a lotta reports :whistling:)

But still, depending on the mods we install, your end node #71 might not match my end note#71 :P My end node #71 is the "thanks for returning the body, have 3000 gold ..." line that got added by BG1UB's component. It should be reported to the BG1UB forums if that's the case :D


Most of the errors you'll never notice in-game, others don't matter and most of the rest you can't do anything about yourself. So the end of the line is that you'll have to search thoroughly through the generated list to find something useful. (I gave up this approach long ago)

Sound like the right node. Thought it was BGT, but if you know it's BG1UB then you have saved me some time.

Edited by OneEyedPhoenix, 10 October 2009 - 05:54 AM.


#15 OneEyedPhoenix

OneEyedPhoenix
  • Member
  • 308 posts

Posted 12 October 2009 - 08:33 AM

Lets see...

Wenric.dlg has the following changelog:
[codebox]
Mods affecting WENRIC.DLG:
00000: /* from game biffs */ ~SETUP-BGT.TP2~ 0 0 // Baldur's Gate Trilogy - Core
00001: /* from game biffs */ ~SETUP-NTOTSC.TP2~ 0 0 // NTotSC for BGT-Weidu
00002: /* from game biffs */ ~SETUP-NTOTSCV171.TP2~ 0 0 // Fix NTotSC Issues
00003: ~BG1NPC.TP2~ 0 1 // The BG1 NPC Project: Banters, Quests, and Interjections
00004: ~SETUP-XPMOD.TP2~ 0 12 // Reduce to 50%[/codebox]

My guess is NtotSC, like Lollorian suggested above.

Scar.dlg has the following changelog:
[codebox]Mods affecting SCAR.DLG:
00000: /* from game biffs */ ~SETUP-BGT.TP2~ 0 0 // Baldur's Gate Trilogy - Core
00001: /* from game biffs */ ~BG1NPC.TP2~ 0 1 // The BG1 NPC Project: Banters, Quests, and Interjections
00002: ~BG1UB/SETUP-BG1UB.TP2~ 0 11 // Scar and the Sashenstar's Daughter
00003: ~SETUP-XPMOD.TP2~ 0 12 // Reduce to 50%
00004: ~AURORA/SETUP-AURORA.TP2~ 0 247 // Reduce to 50%[/codebox]

So it could well be BG1UB.

In other words, it doesn't look like you need to concern yourself Ascension.

Edit: Or maybe you do... (Just posted on the BG1UB bug thread) :P

Edited by OneEyedPhoenix, 12 October 2009 - 08:45 AM.


#16 OneEyedPhoenix

OneEyedPhoenix
  • Member
  • 308 posts

Posted 20 October 2009 - 02:54 AM

Just to sum this thread up...

Melicamp the chicken journal entry is fixed in BGTv1.8.

The scar journal entry is fixed in BG1UBv8.

The winter wolf pelt journal entry was reported to ScS here.

The Zombie infestation journal entry is reported in the Ntotsc bug thread here.

Edited by OneEyedPhoenix, 20 October 2009 - 02:57 AM.


#17 Ascension64

Ascension64
  • Modder
  • 5983 posts

Posted 20 October 2009 - 11:09 PM

Just a note that no modifications currently remove journal entries upon transition - this means that any modded BGT has a chance of leaving behind journal entries (solved, unsolved, and journal) when you go into BG2.

--------------
Retired Modder
Note: I do not respond to profile comments/personal messages in regards to troubleshooting my modifications. Please post on the public forums instead.

Baldur's Gate Trilogy-WeiDU and Mods
Throne of Bhaal Extender (TobEx)

Contributions: (NWN2) A Deathstalker (voice acting) - (IWD2) IWD2 NPC Project (soundset editing) - (Misc) SHS PC Soundsets (voice acting)
Legacy: (BG/Tutu/BGT) Beregost Crash Fixer 1.9 (18 Jul 10) - (BG2) Enable conversations with charmed/dominated creatures (18 Jul 10) - (BG2) Experience Corrections (18 Jul 10) - (Misc) Platform Conversion Utility RC2 (13 Feb 10)