Last call for bugs before new release

Post away here:

http://www.shsforums...&...st&p=459986

Here is the most recent changelog so I don't look into same bugs twice.

Installation of Check The Bodies ©2003, ©2004 Charles Bisson now complete. Thanks for playing!

------------------
VERSION HISTORY

*******************************************************************************
*** Version 1.12 (by King Diamond) *Hoppy was here * - WeiDU v212
*******************************************************************************
1) added Italian translation.
credits go to: Ilot (in collaboration with Arcangelo and Andrea C.).

2) Revised French translation: Les D'Oghmatiques

3) added German translation.
credits go to: Leonardo Watson

4) Fixed 3 search maps (AR3534, AR3551 and AR3575) which now allow for better movement or fixes CTD's.

5) Attempted to fix the Academy of Kuldin scripts (AR3541-AR3560 cumulatively) with appropriate change of enemies
depending on party levels and allowing other script blocks to fire. Level checks were previously too high.

6) Creature fixes for Yuanti in Hlondeth relative to Rynn's quest. Changed death variable to YUANTI to match her
dialog checks (SPRITE_IS_DEADYUANTI) and does not effect the Yuanti of the main quest,
Hlondeth Secession or Black Adder stew.
-CBHLDYT1, CBHLDYT2, CBHLDYT3, CBHLDYT4 all have YUANTI dv's.

7) Missing characters (CBPISSMN=AR1100, CBSEACAPT=AR0300, CB3650DW=AR3650) that are present in the area file but never
get created. Not a timing issue or incompatibility, they never worked in versions 150-1.11 either.
Possible patching botched? Just added some script blocks in the areas to spawn them when relevent.

Fixed the dragring.itm crashing due to no creature files present to summon. Added 4 dragons that it can summon
with generic summoned Nishru scripts for now so they won't go hostile by spells cast. Will improve on this later.

9) Fixed the item CBDRSTF3.ITM causing a crash on "hit" because it was set as 2 handed and inventory icon mace. Also changed BAM.

10) Generated a script to spawn the item (CBDRSWOD) needed to upgrade/fix the item above.
PREY.BCS was appended to and will create the item in a forest area.
This item could not be previously found by me or testers in any files.

11) Fixed Crowley's cutscene to give Use Any Item as the normal spell casts on self. Added my own CBUAISP for the spell
and changed other class quest scripts that teach Use Any Item to work better with the new spell.

12) Fixed Tardeth's dialog from Company of Eight to not give the quest in chapter 7 only.

13) Fixed CBCLKSCP to correctly decrease reputation permanently each time donned. I based similar coding to what Aurora's
Shoes mod uses.

14) Many creature changes done by ScuD to reorder items in slots that may not be immediate bugs, but can make other installations
fail or create corrupt resources. Some of these I had to alter further for fixes.

15) Attempted to fix Alchemy test that worked in early versions. I made the changes to area script AR3504 and CBTETTCH.BCS so this
hopefully will work better compatibility-wise. Not sure why this was happening honestly.

16) Attempted to fix Zannaster the mage/lich scripts to work better.

17) Attempted to fix a nasty bug in Angry Villagers revolt (AR1000.BCS).

18) Added a proper journal entry for the Master Vampire quest. Originally pointed to a spell name in the dialog.tlk.

19) Reordered scripts for CBDRIFAL (driders not hostile in ancient library) and CB901SCK (Holly the elf changed script to override). These will hopefully allow the driders to be hostile where
appropriate and Holly to have stronger checks for the herbs that she needs.

20) Fixed CBHOLLY2.ITM where the save throws were disappearing on character level up. With this change, the modifier still shows after level up. This is an attempt to make the effects permanent.

21) For the Captured quest, I removed one global check from AR0300.BCS to account for the two different scenarios. In one scenarion Mook would never be created so player would have to CLUA
the item that Bodhi wants.

22) Tried to fix Ryberg to not spawn instantly again if the player refuses to help. Added SetGlobalTimer("#HCbRybSpwn","GLOBAL",ONE_DAY)
to his dialog and a GlobalTimerExpired in his BCS so he can spawn again in one day in relevant areas.

Edited by Hoppy, 26 December 2009 - 10:36 AM.

Hello,
I'm not sure this is a bug. In CTB v1.9, the potion giving by Holly the Elf supposed to decrease saving throws of 2 points does'nt function any more when a character gains a level. Their values are "re-initialized".

OK it is probably a duration oddity. In both potions the effects are listed as instant/permanent until death. I will try a test with the items and see what happens. Maybe instant/permanent will be better to stack when leveling up.

these are the bugs in my run
1-Rynn does not react after I kill the yuan ti ( this is probably point 6 in your fixes but just to make sure)
2-even after making the crown of horns, Cromwell still has the dialogue option to make it and not the dialogue to destroy it
3-when I bring the 5 components that Holly the elf has asked for I only get the dialogue that I have 3 components only and the quest doesnt finish
4-in the ancient library ( Umar hills) trying to attack the dryder priestesses with physical weapons will cause a CTD ( CTRL-Y kills them normally without CTD)

sorry I dont have the game installed now

these are the bugs in my run
1-Rynn does not react after I kill the yuan ti ( this is probably point 6 in your fixes but just to make sure)
2-even after making the crown of horns, Cromwell still has the dialogue option to make it and not the dialogue to destroy it
3-when I bring the 5 components that Holly the elf has asked for I only get the dialogue that I have 3 components only and the quest doesnt finish
4-in the ancient library ( Umar hills) trying to attack the dryder priestesses with physical weapons will cause a CTD ( CTRL-Y kills them normally without CTD)

sorry I dont have the game installed now

1) yes point six in the fixpack resolves this otherwise it was a set global command via console.

2) OMG! That quest messes with me, I'm serious . I don't have any saves regarding this quest but I will try to see what is going on. I know there are some things in his script pertaining to this as there are others like it for forging things. Maybe it is just a global trigger not matching between script and dialog.

3) Never had the problem and the scripts look fine. Her script checks for the items and increments the global that way.

4) never had this problem so there could be an incompatibility. Because of their Magic Resistance I found I could only beat them with melee weapons after disabling their spell protections.

Edited by Hoppy, 21 December 2009 - 11:05 AM.

1) thanks
2) I also had Weimers item upgrades so maybe due to it
3) actually there is a bug, though Im not a modder . but I found on a french walkthrough ( the link to it was from the forums here, used google to translate) that if you bring double copies of the items the quest will work, though it even didnt in my case
4) it must be a mod conflict since I was running a megamod manual install ( bdash, bg2fixpack, nej, all large quest mods, most small quest mods, pretty funky install) but the thing is only those creatures caused the CTD. come to think of it, maybe next time I do such an install and have the same problem I should report it to the megamod help forum and not here


actually, it was you who gave the link to the french walkthrough
http://forums.jeuxon...ad.php?t=876281

although I read the translated version , but this walkthrough mentions a lot of bugs which are worth checking out ( in case you havent for like a 100 times already)

Edited by psychlopes, 21 December 2009 - 05:49 PM.

1) thanks
2) I also had Weimers item upgrades so maybe due to it
3) actually there is a bug, though Im not a modder . but I found on a french walkthrough ( the link to it was from the forums here, used google to translate) that if you bring double copies of the items the quest will work, though it even didnt in my case
4) it must be a mod conflict since I was running a megamod manual install ( bdash, bg2fixpack, nej, all large quest mods, most small quest mods, pretty funky install) but the thing is only those creatures caused the CTD. come to think of it, maybe next time I do such an install and have the same problem I should report it to the megamod help forum and not here


actually, it was you who gave the link to the french walkthrough
http://forums.jeuxon...ad.php?t=876281

although I read the translated version , but this walkthrough mentions a lot of bugs which are worth checking out ( in case you havent for like a 100 times already)

1) anytime

2) Possibly a conflict but item upgrades doesn't use the cutscenes I thought. CtB is the only one I thought that makes the forging just like the vanilla. I'll check this out some more at least for compatibility sake.

3) Never heard of this problem and that is why I did not pay much attention in the walkthrough. It is definitely script related to Holly since that is what counts the items to increment globals and the dialog checks the global value. I don't think I want to make that an area script though. Since it is in her script, I would wait a little bit before talking to her especially with tons of items in a bag of holding to fulfill the check. I'll keep looking into it if people have problems again with 1.12.

4) That could be an animation error with the creature or an error with the weapon. I assume all weapons produced the crash so it may have been corrupted creatures. Hard to tell without seeing the error message.


Thanks psycholopes!


EDIT: For destroying the crown, these conditions have to be true for PC to ask C to detroy the crown.

GlobalGT("CbMalteseArtifact","GLOBAL",4)
PartyHasItem("CBMALR6a")
Global("SPRITE_IS_DEADCBMALR1","GLOBAL",1)

and this guy is KHADDYR and the dialog for this guy has a lot of setting our key global to 6 which doesn't look to be an immediate problem.. I be thinkin' another mod/mods alter C's dialog making it run around this option.

Everything looks aesthetically and logically correct, so I don't think we have something wrong with CtB.

Edited by Hoppy, 21 December 2009 - 09:37 PM.

More fixes added:

19) Reordered scripts for CBDRIFAL (driders not hostile in ancient library) and CB901SCK (Holly the elf changed script to override). These will hopefully allow the driders to be hostile where
appropriate and Holly to have stronger checks for the herbs that she needs.

20) Fixed CBHOLLY2.ITM where the save throws were disappearing on character level up. With this change, the modifier still shows after level up. This is an attempt to make the effects permanent.

21) For the Captured quest, I removed one global check from AR0300.BCS to account for the two different scenarios. In one scenarion Mook would never be created so player would have to CLUA
the item that Bodhi wants.

Edited by Hoppy, 26 December 2009 - 10:31 AM.

Last call for bugs before new release

Well, is there any chance you could make the CtB not use the old weidu --make-biff command to every file in the game, but have the MAKE_BIFF command executed by an optional component, like the Generalized Biffing uses. This would make the mod to be able to be uninstalled... yes, I looked at the .tp2 file, and got lost... as there is not one reference to the created directories except their creation... so something else moves the created files to them in addition to the CtbFinishInstall.bat's moving few of them to there before the --make-biff commands. Yes, you might need to make the some empty spare .bif files so the WeiDU.exe can think like this:

ACTION_IF NOT FILE_EXISTS ~data/CTB-RULE.BIF~

By the way, it might be good to add this:

COPY + ~Setup-CtB.exe~ ~Setup-CtB_FF.exe~

to the .tp2 file, and remove the said Setup-CtB_FF.exe from the archive, to make it smaller as then it's unneeded, and make the line #24 check if there is already a WeiDU.exe file in the game directory...

Last call for bugs before new release

Well, is there any chance you could make the CtB not use the old weidu --make-biff command to every file in the game, but have the MAKE_BIFF command executed by an optional component, like the Generalized Biffing uses. This would make the mod to be able to be uninstalled... yes, I looked at the .tp2 file, and got lost... as there is not one reference to the created directories except their creation... so something else moves the created files to them in addition to the CtbFinishInstall.bat's moving few of them to there before the --make-biff commands. Yes, you might need to make the some empty spare .bif files so the WeiDU.exe can think like this:

ACTION_IF NOT FILE_EXISTS ~data/CTB-RULE.BIF~

By the way, it might be good to add this:

COPY + ~Setup-CtB.exe~ ~Setup-CtB_FF.exe~

to the .tp2 file, and remove the said Setup-CtB_FF.exe from the archive, to make it smaller as then it's unneeded, and make the line #24 check if there is already a WeiDU.exe file in the game directory...

I don't see this as fixing something that is broken plus I would need to look into the Gen biffing code because cuurently, I do not support that tool. If folks from BWP want to edit the TP2 and .bat files to remove the biff tool and use their own final biffing procedure, then they can go right ahead. CtB can be uninstalled on its own and when I do it. there are no references to CBxxxxx files left. I don't know what you meant by making the mod able to be uninstalled.


Setup-CtB_FF.exe is completely optional and is in the main package because it has the updated translations. It should not go into the main tp2 like the chores in my opinion because it is by a different author. If it isn't broken, I am not going to fix it. Anyone else can feel free to hack it any way they want

I don't see this as fixing something that is broken plus I would need to look into the Gen biffing code because currently, I do not support that tool. If folks from BWP want to edit the TP2 and .bat files to remove the biff tool and use their own final biffing procedure, then they can go right ahead. CtB can be uninstalled on its own and when I do it. there are no references to CBxxxxx files left. I don't know what you meant by making the mod able to be uninstalled.

Yes, I do realize this is a lot too late, but still...
Now I perhaps misspoke when saying that CtB can't be uninstalled, it can. But it can't be stack-uninstalled, meaning that when someone wants to uninstall multiple mods in a row within the WeiDU.exe to install some others say...

The install order requires the component 4003, instead of 4002 of a mod that's already installed before CtB, to change this, we start the mods (*which component the 4002 was*) setup-*modname*.exe

The setup-*modname*.exe can't operated properly as the CtB uses Uninstall.bat, because of the --make-biff having been a cmd.exe command line command, instead of a everything having been inside the setup-CtB.tp2, the whole game goes belly up, cause the Uninstall.bat was never actually started properly within the stack-uninstall procedure.
Or this is at least what I understand from the situation, that I have read from few boards.

Setup-CtB_FF.exe is completely optional and is in the main package because it has the updated translations. It should not go into the main tp2 like the chores in my opinion because it is by a different author. If it isn't broken, I am not going to fix it.

Yeah, it's a different author, but aren't the mod users supposed to contact you if the mod fails to install, not hlidskialf(CtB-FF) or Charles Bisson and King Diamond(CtB).
If it's broken, you need to fix it. And you should give the credits in the Don't ReadMe.txt .
As should you understand it, the install failure message includes the AUTHOR ~yyyyyyyyyyyyyyyyyyyyyyy~ info.

Edited by Jarno Mikkola, 05 January 2010 - 04:02 AM.

YAY for new version!!!

Thanks,
Lol

Congratulations with new release

I don't see this as fixing something that is broken plus I would need to look into the Gen biffing code because currently, I do not support that tool. If folks from BWP want to edit the TP2 and .bat files to remove the biff tool and use their own final biffing procedure, then they can go right ahead. CtB can be uninstalled on its own and when I do it. there are no references to CBxxxxx files left. I don't know what you meant by making the mod able to be uninstalled.

Yes, I do realize this is a lot too late, but still...
Now I perhaps misspoke when saying that CtB can't be uninstalled, it can. But it can't be stack-uninstalled, meaning that when someone wants to uninstall multiple mods in a row within the WeiDU.exe to install some others say...

The install order requires the component 4003, instead of 4002 of a mod that's already installed before CtB, to change this, we start the mods (*which component the 4002 was*) setup-*modname*.exe

The setup-*modname*.exe can't operated properly as the CtB uses Uninstall.bat, because of the --make-biff having been a cmd.exe command line command, instead of a everything having been inside the setup-CtB.tp2, the whole game goes belly up, cause the Uninstall.bat was never actually started properly within the stack-uninstall procedure.
Or this is at least what I understand from the situation, that I have read from few boards.

Setup-CtB_FF.exe is completely optional and is in the main package because it has the updated translations. It should not go into the main tp2 like the chores in my opinion because it is by a different author. If it isn't broken, I am not going to fix it.

Yeah, it's a different author, but aren't the mod users supposed to contact you if the mod fails to install, not hlidskialf(CtB-FF) or Charles Bisson and King Diamond(CtB).
If it's broken, you need to fix it. And you should give the credits in the Don't ReadMe.txt .
As should you understand it, the install failure message includes the AUTHOR ~yyyyyyyyyyyyyyyyyyyyyyy~ info.

Thanks for being more specific. I focused mainly on game play fixes and translations for this update. Since BWP uses its own modified.bat files and doesn't stack uninstall anything, I left their changes up to them for now. I am not familiar with this stack uninstalling so I am a bit befuddled.

not hlidskialf(CtB-FF) or Charles Bisson and King Diamond(CtB).

It has been this way for almost three years and Bisson wasn't even active in that time

<img src='http://www.shsforums.net/public/style_emoticons/<#EMO_DIR#>/tongue.gif' class='bbc_emoticon' alt=':P' /> And you should give the credits in the [i]Don't[/i] ReadMe.txt . <img src='http://www.shsforums.net/public/style_emoticons/<#EMO_DIR#>/biggrin.gif' class='bbc_emoticon' alt=':D' />

CBisson's credits are in the read me. I did give my credits pertaining to the new version in the CTB-Version.txt. Did you look at that one? I am sorry if I may have left someone out and meant no offense.


If you want to provide the modifications in a way that works for what you are trying to accomplish, then please provide them. You know what you want more than I do. This doesn't mean I will instantly do another release as I have moved on to the next project. However, I will implement your changes and give you credit in the next release

YAY for new version!!!

Thanks,
Lol

Enjoy

Congratulations with new release

Thank you for your help in the process

Thank you for taking care of the mod ;-)