1025 replies to this topic

[Jarno Mikkola]

Try to extract the 11.1.6 fixpack and tell me where you are able to find the string 11.1.6 .

Ups... well, but isn't this a good reason to include actual fixes to the BWS Fix pack... like say one to APPEND one IDS file with the eventual content it should have and put the file version tag to the WeiDU.log as the first item to show up as.
This can be done to all the BWS tools, Fixpack, Installpack, Textpack, Trimpack.

Edited by Jarno Mikkola, 23 August 2012 - 10:42 AM.

[dabus]

I'm with you that it makes sense, so the BWS creates pseudo-entries for the packages, BWP itself does not add these entries.
Wouldn't be too hard to do so (3 lines of text for each package).
If I remind correctly, the ids don't get overwritten any more since someone said that it wasn't needed...

[Lollorian]

Agreed that the full version number should probably be there in BiG World Fixpack\_messages\header.txt (currently just says v11 )

And yeah... the doc really needs an update I mean really really... this thread is now a PITA to keep track of by itself Umm, btw that fix for Darian attached is made for v2.1 of the mod when v2.3 is out right now

I think Lollorian has been working on this too.

Was I? I create reports about what patches are redundant/not being applied properly on each BWPFixpack update but never looked at the docs itself though

That said, this is probably my last post for a couple of weeks yeah? A little time off is in session...

[Beleg33]

Umm, btw that fix for Darian attached is made for v2.1 of the mod when v2.3 is out right now

Balls, thanks for pointing it. Attaching new one here then, and removing the attachment from previous post.

 darian_sarahtob_crossmod_check_fix.7z   6.38K   179 downloads

Edited by Beleg33, 23 August 2012 - 12:10 PM.

[Jarno Mikkola]

If I remind correctly, the ids don't get overwritten any more since someone said that it wasn't needed...

The thing is, you shouldn't overwrite the files, but APPEND to them the proper .ids entries... and for now, it can lead up to this:

ERROR 1 (Region of Terror mod)

[RoTerror/SNIP/BAF/bBALDUR.BAF] PARSE ERROR at line 1142 column 1-41
Near Text: )
[StateCheck] argument [CD_STATE_NOTVALID] not found in [State.IDS]

I'm with you that it makes sense, so the BWS creates pseudo-entries for the packages, BWP itself does not add these entries.
Wouldn't be too hard to do so (3 lines of text for each package).

Well, I was thinking that the BWP .bat would actually install an .IDS fix component(s) that just at the side would also ad in the versions tag for the tools. So in actuality all these * :

~SETUP-WEIDU.TP2~ #0 #0 // 23100
~SETUP-BWS.TP2~ #0 #0 // 20120701
~SETUP-BWS-URL.TP2~ #0 #0 // 20120813224048
*~SETUP-BWFIXPACK.TP2~ #0 #0 // BiG World Fixpack-11.1.6.7z
*~SETUP-BWTRIMPACK.TP2~ #0 #0 // BiG World Borkpack v11.7z
*~SETUP-BWINSTALLPACK.TP2~ #0 #0 // BiG World Installpack-11.1.4.7z

Could be real files that actually just fix a .IDS file like the State.IDS, while the // * would be the actual version number in the setup-*modname*.tp2 files innards... and not a random archive name as it's now.

Edited by Jarno Mikkola, 23 August 2012 - 01:01 PM.

[Beleg33]

Huh there are 2 different issues discussed at the same time, I'm getting lost.

About IDS stuff :
RoT is the only mod that I've heard about that uses a custom IDS entry (from STATE.IDS) without providing it (APPENDing it) during installation. I can provide a fixed .tp2 with an APPEND STATE.IDS section, just to add that CD_STATE_NOTVALID if it's missing. So it doesn't choke while compiling.

About BWFixpack version tags :
The BWS adds it to WeiDU.log at some point even though they are not really WeiDU mods (au3 script does that? IDK) so I guess that's fine. Maybe that function could be added in each of the batch command files (Fixpack/Installpack/Trimpack) instead. So even with batch/manual intall when these are run they write into WeiDU.log, so it's easier to debug which version someone used.

[Nightfarer]

Umm, btw that fix for Darian attached is made for v2.1 of the mod when v2.3 is out right now

That is right, Darian v2.3 is out; although they both suffer from the same issue, as well as v2.2.

[dabus]

BWS creates a dummy-file for those entries since changelogs like to have their files present. So a SETUP-BWTRIMPACK.tp2 would be this:

BACKUP ~WeiDU/bwp_backup~
AUTHOR ~dummy@mail.de~
BEGIN "BiG World Borkpack v11.7z"

If the version entries are not suited, I get that elsewhere (like the archive-name in this case).

[Beleg33]

RoT is the only mod that I've heard about that uses a custom IDS entry (from STATE.IDS) without providing it (APPENDing it) during installation. I can provide a fixed .tp2 with an APPEND STATE.IDS section, just to add that CD_STATE_NOTVALID if it's missing. So it doesn't choke while compiling.

Link to reported compile missing IDS entry error There's something going on here, I can't find that line 1142 StateCheck(Someone,CD_STATE_NOTVALID) in that file... I'm redownloading it to be sure I got the right version (even if I'm sure I do). That trigger is usually in DLGs for interjections anyway. No fix until investigated.

[Jarno Mikkola]

...

Edited by Jarno Mikkola, 23 August 2012 - 11:09 PM.

[Jarno Mikkola]

Huh there are 2 different issues discussed at the same time, I'm getting lost.

Well, I am advicating the fact that the two should be combined... in a way.

And while it's good to have dummy entries for the BWS, it would be good to have concreat WeiDU fixes made from the Fixpack. If you want, I can provide with most files to you ... I just need your help to spread the fixes and a --change.log from a bwp States.ids file, and you to code the nessasary parts in BWS, which shouldn't be a lot... so I can code the .tp2 files, the .bat file addition, and the WeiDU.exes are unnessasary as the BWInstall.bat addition can handle that, they just need to be removed eventually.

As what I am talking about is altering this:

BACKUP ~WeiDU/bwp_backup~
AUTHOR ~dummy@mail.de~
BEGIN "BiG World Borkpack v11.7z"

To be like this:

BACKUP ~WeiDU/bwp_backup~
AUTHOR ~dummy@mail.de~
BEGIN "BiG World Borkpack"
VERSION ~v11~

APPEND ...

And then actually installing some content, and not just suedo installing nothing.

Ouh, and someone also needs to then edit the "v11" to be the actual number in the future... hard as hell I know.

Edited by Jarno Mikkola, 24 August 2012 - 12:14 AM.

[dabus]

I didn't need the code since you got the batch-files to do the installation at another time.
If you want to volunteer to rewrite those batches, I guess you are welcome.
And I don't see the benefit of adding a version tag if there is only one info in there...

[Beleg33]

Now that we've fixed Finch's out-of-party dialog trigger we need to make sure she doesn't spamforce it on you when you have a book in your possession that she hasn't commented on yet. Added a bunch of InParty(Myself) triggers to SUFINCH.BAF

 sufinch_outofparty_book_comments_fix.7z   797bytes   167 downloads

Edited by Beleg33, 24 August 2012 - 09:49 AM.

[Lollorian]

Some backstory first - I've been following this thread by Beleg33 (I hope ) in the Undying mod forums and he's found quite a bit of stuff. I decided to check EVERY OTHER FRIGGIN MOD for the same problems (bar the mismatched item descriptions and stuff which I'm not skilled enough to automate )

So, in order of discovery in that thread, here are 3 sets of item fixes

1) Invalid modifier for Magic Resistance Bonus Effect - both items (from Gloran and the RTTItempack) are already fixed by the BWPFixpack for some other fix I'm too lazy to dig up about, so the attachment has these fixes added to the BWPFixpacked items

Spoiler

gloran\itm\GLOR01.ITM
rttitempack\files\RTT003.ITM

2) Batch 1 of stuff contains:
- Double Spells Bonus with overkilled levels

Spoiler

DarkHorizons\BGT\items\CMRIQ07.ITM
DarkHorizons\items\CMRIQ07.ITM (both found by Beleg33)
BG1NPCSoA\ITEMS\depo150.itm (changed spell level from 256 and below to 9 and below... no in-game effect I guess )

- Cold/Fire/Acid/Elec/Magic Resistance Bonus erroneously set to Modifier 2 - "Set % of" (changed to Modifier 0 - "Increment")

Spoiler

DarkHorizons\BGT\items\CMHELM01.ITM error: Opcode (30) - Sets to 25
DarkHorizons\items\CMHELM01.ITM error: Opcode (30) - Sets to 25 (both found by Beleg33)
Trovador\ITM\Trov_002.itm error: Opcode (27) - Sets to 90
AviM\avii3.itm error: Opcode (31) - Sets to 50 (special case - changed that effect into an AC bonus of 1 as per description)
BG1NPCSoA\ITEMS\depo206.itm error: Opcode (30) - Sets to 10
BG1NPCSoA\ITEMS\depo31.itm error: Opcode (31) - Sets to 25
DSoA\BrownDragon\items\C-CS.ITM error: Opcode (30) - Sets to 60

Also contains a modified BG1NPCSoA.tp2 that doesn't bork the IDed Description of the Celestial Fire item (TRAified string was present but something broke )

3) Second batch - found this by accident when fixing BG1NPCSoA\ITEMS\depo206.itm! Apparently there were other bonuses that were erroneously using Modifier 2 - "Set % of"

- Magic Fire/Magic Cold/Slashing/Crushing/Piercing/Missile/Open Locks/Find Traps/Pickpockets/Fatigue/Intoxication/Tracking bonus boo boos

Spoiler

DarkHorizons\BGT\items\CMAMQ02.ITM error: Opcode (92) - Sets to 20
DarkHorizons\BGT\items\CMAMUL04.ITM error: Opcode (92) - Sets to 10
DarkHorizons\BGT\items\CMBRQ03.ITM error: Opcode (90) - Sets to 20
DarkHorizons\items\CMAMQ02.ITM error: Opcode (92) - Sets to 20
DarkHorizons\items\CMAMUL04.ITM error: Opcode (92) - Sets to 10
DarkHorizons\items\CMBRQ03.ITM error: Opcode (90) - Sets to 20
BG1NPCSoA\ITEMS\depo206.itm error: Opcode (86) - Sets to 10 (included in first batch )
RFWIP\Items\FWBrac05.ITM error: Opcode (87) - Sets to 25
RFWIP\Items\FWBrac05.ITM error: Opcode (89) - Sets to 25
RFWIP\Items\FWBrac05.ITM error: Opcode (88) - Sets to 25
RFWIP\Items\FWBrac05.ITM error: Opcode (86) - Sets to 25
RFWIP\Items\FWChan03.ITM error: Opcode (86) - Sets to 0
RFWIP\Items\FWChan03.ITM error: Opcode (88) - Sets to 0 (special case - descrip says immunity, so I SET (modifier 1) their values to 100)
RFWIP\Items\FWChan04.ITM error: Opcode (87) - Sets to 25
RFWIP\Items\FWChan04.ITM error: Opcode (89) - Sets to 25
RFWIP\Items\FWChan04.ITM error: Opcode (88) - Sets to 25
RFWIP\Items\FWChan04.ITM error: Opcode (86) - Sets to 25
RotBArmorSet\Items\rbplat01.itm error: Opcode (89) - Sets to 50
Vendedor_DLAN\V-DLAN12.itm error: Opcode (84) - Sets to 75
Vendedor_DLAN\V-DLAN12.itm error: Opcode (85) - Sets to 75
Vendedor_DLAN\V-DLAN12.itm error: Opcode (86) - Sets to 55
Vendedor_DLAN\V-DLAN12.itm error: Opcode (87) - Sets to 55
Vendedor_DLAN\V-DLAN12.itm error: Opcode (88) - Sets to 55
Vendedor_DLAN\V-DLAN12.itm error: Opcode (89) - Sets to 55 (special case - descrip says bonuses are SET instead of INCREMENTED)

So YAY PUPPIES!!!

Attached Files

•  magic_res_bonus_invalid_modifier.7z   471bytes   575 downloads
•  first_batch_Beleg33_expanded.7z   60.41K   212 downloads
•  second_batch_Beleg33_expanded.7z   1.11K   215 downloads

[hook71]

The latest version of the BiG World Fixpack as of now is 11.2.1 by the way. Download from here.

[Lollorian]

Attaching this here because the YeslickNPC forum doesn't allow attachments (Almost) BGT compatibility for Yeslick NPC as reported here.

Attached Files

•  yeslicknpc_BGT_compatibility.7z   32.91K   181 downloads

[Nightfarer]

Larsha NPC 0.3 eng tra files done!

[Lollorian]

More item effect stuff

com_encounters\item\UCMGLE01.ITM
- Hide in shadows bonus is now INCREMENTED rather than SET as a %

TheUndying\items\CMMISC01.itm
- used to SET your lore to 20% when neither description nor item name (Rabbit's Foot) suggest anything related to being lore impaired Changed to provide +2 to Luck (+1 to opcode ) similar to BGII rabbit's foot (MISC88.itm)

OldModsPack\items\Ringkon.itm
- Used to SET your damage to 15% (the item tries to implement a bonus to cold damage that isn't possible in vanilla BGII-ToB) Now provides a flat +15% damage... ALL DAMAGE

planarspheremod\itm\pshelm02.itm
planarspheremod\itm\psmade12.itm
- Doubled level 2 spells and QUADRUPLED level 1 spells Now only doubles...

vampiretales\CoMStore\items\GCMRI01.itm
- Had BOTH of the above problems (spurious doubling spell effects and extreme attack damage reduction)

Also, double Aegisfields fix for Hubelpot

And finally, one of RoT's fixes in the BWPFixpack requires STATE.IDS value - CD_STATE_NOTVALID... my bad The attached TP2 already includes both the Trimpack and Fixpack patches applied, so overwrite it after applying them!

Attached Files

•  more_item_stuff.7z   876bytes   221 downloads
•  RoT_cd_state_notvalid_whoopsie.7z   24.44K   156 downloads

Edited by Lollorian, 13 September 2012 - 02:44 AM.

[Lollorian]

Almost all the IDS stuff that borked Echo's installation should be fixed now Lots of APPENDs added where relevant... They already contain the BWPFixpack's patches

Attached Files

•  append_ids_extras.7z   108.02K   176 downloads

[Lollorian]

More stuff for:
Eilistraee
FR_ROV
DarkHorizons and BonsBruce