Jump to content


Photo

Quest rewards component


  • Please log in to reply
11 replies to this topic

#1 OneEyedPhoenix

OneEyedPhoenix
  • Member
  • 308 posts

Posted 19 September 2009 - 12:09 AM

Why Aurora? Because I'm trying to reduce the number of mini-mods I have floating around, and it also already contains an updated Store Prices mini-mod, including the following components GeN1e and I reworked:

  • Change store buying prices
  • Change store selling prices
  • Change gem and jewelry prices
  • Change creature gold carried
So basically, with the addition of this component and the other one, you can rework the Faerunian economy however you like :).

The other component is a "Reduce quest gold rewards" which is also essentially done, at least as far as modding the actual amounts granted. We're just trying to change the dialogue references too, otherwise it may seem odd if you're offered 10,000 and only get 5,000 or whatever. But we have some wei-fu ninjery up our sleeves, if someone can convince GeN1e to get it working instead of giving up and going back to playing NWN2 :unsure:.


So this will be a joining of Aurora, AGPRICES and XPMOD in other words...?

I can test the treasure mod on Vanilla BG2 if you like, but I won't be doing extensive play-testing.

#2 Miloch

Miloch

    Barbarian

  • Modder
  • 6573 posts

Posted 19 September 2009 - 01:51 AM

So this will be a joining of Aurora, AGPRICES and XPMOD in other words...?

Aurora and agprices are already joined in the existing v1, as per the readme. This won't be merging XpMod ("DEF JAM") but if we get the gold quest reward component working, it's similar to the XP quest reward component in that mod (only for gold not XP).

I can test the treasure mod on Vanilla BG2 if you like, but I won't be doing extensive play-testing.

Already tested it on vanilla BG2 and confirmed it does what it should, so it doesn't really need extensive play-testing. Just need to test it on BWP (always last on my list, because it's a monster :D).

Infinity Engine Contributions
Aurora * BG1 NPC * BG1 Fixpack * Haiass * Infinity Animations * Level 1 NPCs * P5Tweaks
PnP Free Action * Thrown Hammers * Unique Containers * BG:EE * BGII:EE * IWD:EE
================================================================
Player & Modder Resources
BAM Batcher * Creature Lister * Creature Checker * Creature Fixer * Tutu/BGT Area Map & List * Tutu Mod List
================================================================
"Infinity turns out to be the opposite of what people say it is. It is not 'that which has nothing beyond itself' that is infinite, but 'that which always has something beyond itself'." -Aristotle


#3 OneEyedPhoenix

OneEyedPhoenix
  • Member
  • 308 posts

Posted 19 September 2009 - 02:04 AM

Aurora and agprices are already joined in the existing v1, as per the readme. This won't be merging XpMod ("DEF JAM") but if we get the gold quest reward component working, it's similar to the XP quest reward component in that mod (only for gold not XP).


The quest gold is already handled by some mod in my setup (without changing the dialog). Is this xpmod as well?

Edited by OneEyedPhoenix, 19 September 2009 - 02:05 AM.


#4 Miloch

Miloch

    Barbarian

  • Modder
  • 6573 posts

Posted 19 September 2009 - 02:42 AM

The quest gold is already handled by some mod in my setup (without changing the dialog). Is this xpmod as well?

It's not XPMod. I kinda thought there was such a mod already too, but GeN1e said there wasn't. GeN1e is known to lie sometimes though :D. I'm sure your WeiDU.log is around here somewhere? Also, do you have an example of a quest where you know it's been reduced? If so, attaching or doing a --change-log on that dialogue file might help.

Infinity Engine Contributions
Aurora * BG1 NPC * BG1 Fixpack * Haiass * Infinity Animations * Level 1 NPCs * P5Tweaks
PnP Free Action * Thrown Hammers * Unique Containers * BG:EE * BGII:EE * IWD:EE
================================================================
Player & Modder Resources
BAM Batcher * Creature Lister * Creature Checker * Creature Fixer * Tutu/BGT Area Map & List * Tutu Mod List
================================================================
"Infinity turns out to be the opposite of what people say it is. It is not 'that which has nothing beyond itself' that is infinite, but 'that which always has something beyond itself'." -Aristotle


#5 OneEyedPhoenix

OneEyedPhoenix
  • Member
  • 308 posts

Posted 19 September 2009 - 03:10 AM

It's not XPMod. I kinda thought there was such a mod already too, but GeN1e said there wasn't. GeN1e is known to lie sometimes though :D. I'm sure your WeiDU.log is around here somewhere? Also, do you have an example of a quest where you know it's been reduced? If so, attaching or doing a --change-log on that dialogue file might help.


Of course...

I think the Reward for the Naskel Mine quest was nerfed. Will do a changelog on berrun Gasthkill's dlg (or whatever it was).

Edit: I remembered correctly... I got 239 gold, not the promised 900. Changelog in a bit...

Mods affecting BERRUN.DLG:00000: /* from game biffs */ ~SETUP-BGT.TP2~ 0 0 // Baldur's Gate Trilogy - Core00001: /* from game biffs */ ~BG1NPC.TP2~ 0 1 // The BG1 NPC Project: Banters, Quests, and Interjections00002: ~GAVIN/GAVIN.TP2~ 0 0 // Gavin NPC for Tutu and BGT, 14April200800003: ~BG1UB/SETUP-BG1UB.TP2~ 0 1 // The Mysterious Vial00004: ~SETUP-XPMOD.TP2~ 0 12 // Reduce to 50%

Edited by OneEyedPhoenix, 19 September 2009 - 03:16 AM.


#6 Miloch

Miloch

    Barbarian

  • Modder
  • 6573 posts

Posted 19 September 2009 - 03:31 AM

I think the Reward for the Naskel Mine quest was nerfed. Will do a changelog on berrun Gasthkill's dlg (or whatever it was).

Edit: I remembered correctly... I got 239 gold, not the promised 900. Changelog in a bit...

Funnily enough, it is this mod causing it already:

~AGPRICES/SETUP-AGPRICES.TP2~ #0 #28 // Change creature gold carried -> Reduce to 25%: Beta 3

The answer is quite simple. Berrun's dialogue has a GivePartyGold(900) rather than GiveGoldForce(900). That means he has to be carrying the gold he's giving the party. Well ordinarily he has 958 gold, but with agprices, you've reduced his gold to 239 :).

Now the vast majority of quest awards use GiveGoldForce which awards the gold no matter how much the CRE has, and that's what we're trying to mod.

Infinity Engine Contributions
Aurora * BG1 NPC * BG1 Fixpack * Haiass * Infinity Animations * Level 1 NPCs * P5Tweaks
PnP Free Action * Thrown Hammers * Unique Containers * BG:EE * BGII:EE * IWD:EE
================================================================
Player & Modder Resources
BAM Batcher * Creature Lister * Creature Checker * Creature Fixer * Tutu/BGT Area Map & List * Tutu Mod List
================================================================
"Infinity turns out to be the opposite of what people say it is. It is not 'that which has nothing beyond itself' that is infinite, but 'that which always has something beyond itself'." -Aristotle


#7 OneEyedPhoenix

OneEyedPhoenix
  • Member
  • 308 posts

Posted 19 September 2009 - 04:31 AM

Now the vast majority of quest awards use GiveGoldForce which awards the gold no matter how much the CRE has, and that's what we're trying to mod.


This isn't the first time something like this has happened to me, so I think GivePartyGold is more common than you belive.
Maybe a bulk mod that changes all GivePartyGold to GiveGoldForce, since you are in a mood to do a lot of files at once...?
Although this would of course leave a lot of gold in the pockets of the affected npc's (especially without AGPRICES).

Edited by OneEyedPhoenix, 19 September 2009 - 04:37 AM.


#8 Miloch

Miloch

    Barbarian

  • Modder
  • 6573 posts

Posted 19 September 2009 - 05:07 AM

This isn't the first time something like this has happened to me, so I think GivePartyGold is more common than you belive.

No it isn't - not for significant amounts of gold anyway. Berrun's is without a doubt the biggest GivePartyGold reward in unmodded BG1. Kelddath Ormlyr's reward of 2000gp *would be* - but for the fact he only has 102 gold in his pocket even without nerfing it. Arguably that last one should be a bug fix. And the former *could* be changed, but only if we reduce his gold by the same amount, otherwise it opens an exploit to rob him of the gold he'd otherwise have given as a reward.

As for BG2, there are only 3 or 4 dialogues that use GivePartyGold for amounts over 1k. We might not be changing amounts under this anyway. If we have to hardcode dialogue changes (which is how it's looking) it'd be too much work.

Maybe a bulk mod that changes all GivePartyGold to GiveGoldForce, since you are in a mood to do a lot of files at once...?

I'd be leery of doing this, because it could break some things. For example, Lena has a GivePartyGold(1000000). Well that makes her give the party "all her money" which is only 4gp usually - changing it to Force makes her hand the party a cool million :blink:. Ditto for Zhurlong who has the same thing, making him hand over what he's robbed from the party (unlikely he's looted 1m gold). So I'm not sure changing it in bulk is either a good idea or really necessary, except maybe for those 2 dialogues I mentioned, and maybe a very small handful of others (possibly Scar, Brielbara, Unshey, Oublek, Arkion, Landrin). And that I'd only do if their dialogue mentions specific amounts (didn't check like I did for Berrun and Kelddath). None of those rewards is for more than a few hundred tops, so I don't know if it's worth it except for consistency (like I said, we may only be touching rewards of 1k+ anyhow). Consistency meaning you get what they say you're getting.

Infinity Engine Contributions
Aurora * BG1 NPC * BG1 Fixpack * Haiass * Infinity Animations * Level 1 NPCs * P5Tweaks
PnP Free Action * Thrown Hammers * Unique Containers * BG:EE * BGII:EE * IWD:EE
================================================================
Player & Modder Resources
BAM Batcher * Creature Lister * Creature Checker * Creature Fixer * Tutu/BGT Area Map & List * Tutu Mod List
================================================================
"Infinity turns out to be the opposite of what people say it is. It is not 'that which has nothing beyond itself' that is infinite, but 'that which always has something beyond itself'." -Aristotle


#9 Lollorian

Lollorian

    smiley addict

  • Member
  • 4150 posts

Posted 06 October 2009 - 05:28 AM

Furthermore, it fixes buggy behavior where some NPCs may not have enough gold on hand to give the rewards they promised (unless intended by their dialogues). It is fully compatible with the next component (Change creature gold carried) in that respect. Choices vary anywhere from 10% to 75% of the original quest rewards.

Soooo, since it fixes things as well as changing them, would it be possible to create a subcomponent that keeps 100% of the gold but only fixes the bugs (or isn't it needed for 100% gold?? :P) for those who aren't using any big mods and hence wouldn't need the reduced shinies :D

And does this affect mod quests too?? :ph34r: (the dialogue changing part I mean :P)

Cheers,
Lol

Edited by Lollorian, 06 October 2009 - 05:29 AM.

"I am the smiley addict, yellow and round, this is my grin :D when I'm usually around :P.
When there's trouble brewing, see me post, cuz it's usually a wall o' yellow and your eyes are toast!!!"

BWP GUIDE - BWP FIXES - impFAQ - NPC LIST - KIT LIST - AREA LIST

GitHub Links : BWP Fixpack | Lolfixer | BWP Trimpack | RezMod


#10 Miloch

Miloch

    Barbarian

  • Modder
  • 6573 posts

Posted 06 October 2009 - 11:56 AM

Soooo, since it fixes things as well as changing them, would it be possible to create a subcomponent that keeps 100% of the gold but only fixes the bugs

Nope :P.

for those who aren't using any big mods

You don't fall in that category, nor does most everyone else you know, so why ask? :P

Ok, well it would be possible in theory, but not really necessary unless you're either a) using a megamod install (see above) or b) using the Reduce creature gold component. And if you're using that, you really should be using the Quest rewards component, because creature gold is nothing compared to some of the quest rewards you get.

As a practical matter, if I were to consider adding an extra subcomponent here (which isn't really desirable since there are several already) I'd add a "reduce to 85%" or something before I'd add a "don't reduce at all" because I don't see that as particularly useful.

And does this affect mod quests too?? :ph34r: (the dialogue changing part I mean :P)

Yep... all those I found on my BWP install anyway, and a few other new ones. If someone creates a new mod that doles out loads of supercash, someone will have to let us know so we can add it.

I should mention that this doesn't affect rewards of 100gp or less, except a few specific ones (such as in Aurora's own dialogue, because it makes sense to do so). Just decided that such amount aren't really significant enough to nerf - it's the multi-thousand amounts that are overkill. Seriously, some of these quest rewards are just sick - I think I saw one for 320000gp in one of the megamods :blink:.

Infinity Engine Contributions
Aurora * BG1 NPC * BG1 Fixpack * Haiass * Infinity Animations * Level 1 NPCs * P5Tweaks
PnP Free Action * Thrown Hammers * Unique Containers * BG:EE * BGII:EE * IWD:EE
================================================================
Player & Modder Resources
BAM Batcher * Creature Lister * Creature Checker * Creature Fixer * Tutu/BGT Area Map & List * Tutu Mod List
================================================================
"Infinity turns out to be the opposite of what people say it is. It is not 'that which has nothing beyond itself' that is infinite, but 'that which always has something beyond itself'." -Aristotle


#11 Lollorian

Lollorian

    smiley addict

  • Member
  • 4150 posts

Posted 06 October 2009 - 05:27 PM

Soooo, since it fixes things as well as changing them, would it be possible to create a subcomponent that keeps 100% of the gold but only fixes the bugs

Nope :P.

(damn) :P Like I always say (well maybe only 3 times in this forum ... yet) Doesn't hurt to try :D

for those who aren't using any big mods

You don't fall in that category, nor does most everyone else you know, so why ask? :P

But bugfixes are bugfixes. Someone doing a "Minimal" install of the BWP could use that ;)

I should mention that this doesn't affect rewards of 100gp or less, except a few specific ones (such as in Aurora's own dialogue, because it makes sense to do so). Just decided that such amount aren't really significant enough to nerf - it's the multi-thousand amounts that are overkill. Seriously, some of these quest rewards are just sick - I think I saw one for 320000gp in one of the megamods :blink:

Oooohh, shiny :Tasty:

Cheers,
Lol

"I am the smiley addict, yellow and round, this is my grin :D when I'm usually around :P.
When there's trouble brewing, see me post, cuz it's usually a wall o' yellow and your eyes are toast!!!"

BWP GUIDE - BWP FIXES - impFAQ - NPC LIST - KIT LIST - AREA LIST

GitHub Links : BWP Fixpack | Lolfixer | BWP Trimpack | RezMod


#12 Miloch

Miloch

    Barbarian

  • Modder
  • 6573 posts

Posted 07 October 2009 - 11:06 PM

Someone doing a "Minimal" install of the BWP could use that

"Minimal" and "BWP" are kind of contradictory <_<.

Infinity Engine Contributions
Aurora * BG1 NPC * BG1 Fixpack * Haiass * Infinity Animations * Level 1 NPCs * P5Tweaks
PnP Free Action * Thrown Hammers * Unique Containers * BG:EE * BGII:EE * IWD:EE
================================================================
Player & Modder Resources
BAM Batcher * Creature Lister * Creature Checker * Creature Fixer * Tutu/BGT Area Map & List * Tutu Mod List
================================================================
"Infinity turns out to be the opposite of what people say it is. It is not 'that which has nothing beyond itself' that is infinite, but 'that which always has something beyond itself'." -Aristotle