34 replies to this topic

[Fiann of the Silver Hand]

Sounds like True() just needs to be replaced with NumTimesTalkedTo(0).

[Lollorian]

Could you attach your AGRANDBR.BCS please?

[Lollorian]

Thanks! Offending block - will debug - can probably be fixed by changing HPLT() to HPPercentLT() but I need to figure out why this script is given to all these creatures.

 

 

IF
    HPLT(Myself,20)
    Global("Death","LOCALS",0)
THEN
    RESPONSE #100
        SetGlobal("Death","LOCALS",1)
        StartDialogueNoSet(Player1)
END

Update: Did a grep and the only instances of this block are in the tougher Abazigal scripts from ding0's questpack (questpack\creatures\dragons\tob\abazdrag.baf) and BP (BP\ASCEND\TOUGH\ABAZ\BAF\NEW\ABAZ3.baf)

 

Now why the hell are they appending into Aurora's script?

 

If you do find the time, Rick, could you please changelog AGRANDBR,BCS please? I'm not finding anything that can do this (only case I could think of is some legacy mod that appends using BCS instead of decompiled BAFs - which would mean my grep missed them and BCSes are not greppable btw)

Edited by Lollorian, 09 September 2015 - 07:12 AM.

[Lollorian]

Ah yes that is a serious issue if it is overwriting original creature scripts then

Will have a look at how this script is assigned by Aurora.

[Lollorian]

Update from the future: I fail at code - the following post is irrelevant because Aurora does not meddle with CREs that have 5 scripts Epiphany happened here, Read on to lol at my fails

 

Aurora's berry script patching code:

Spoiler

    COPY_EXISTING ~%tcr%.cre~ ~override~
      PATCH_IF SOURCE_SIZE > 0x71 BEGIN
        sf = 0 //Script offset
        fg = 0 //Ending script
        rgd = 0 //Random number
        READ_ASCII 0x250 s1 //Class script
        PATCH_IF (~%s1%~ STRING_EQUAL_CASE ~none~ = 1) OR (~%s1%~ STRING_EQUAL ~~ = 1) BEGIN
          sf = 0x250
        END ELSE BEGIN
          READ_ASCII 0x248 s2 //Override script
          PATCH_IF (~%s2%~ STRING_EQUAL_CASE ~none~ = 1) OR (~%s2%~ STRING_EQUAL ~~ = 1) BEGIN
            sf = 0x248
          END ELSE BEGIN
            READ_ASCII 0x258 s3 //Race script
            PATCH_IF (~%s3%~ STRING_EQUAL_CASE ~none~ = 1) OR (~%s3%~ STRING_EQUAL ~~ = 1) BEGIN
              sf = 0x258
            END ELSE BEGIN
              READ_ASCII 0x260 s4 //General script
              PATCH_IF (~%s4%~ STRING_EQUAL_CASE ~none~ = 1) OR (~%s4%~ STRING_EQUAL ~~ = 1) BEGIN
                sf = 0x260
              END ELSE BEGIN
                READ_ASCII 0x268 s5 //Default script
                PATCH_IF (~%s5%~ STRING_EQUAL_CASE ~none~ = 1) OR (~%s5%~ STRING_EQUAL ~~ = 1) BEGIN
                  sf = 0x260
                  fg = 1
                END
              END
            END
          END
        END
        PATCH_IF sf > 0 BEGIN
          PATCH_RANDOM_SEED null
          rgd = RANDOM(1 rgf)
          PATCH_IF rgd < 33 BEGIN
            SPRINT sn ~agrandbr~
          END ELSE BEGIN
            PATCH_IF rgd < 63 BEGIN
              SPRINT sn ~agrandrb~
            END ELSE BEGIN
              PATCH_IF rgd = 63 BEGIN
                SPRINT sn ~agrandsr~
              END ELSE BEGIN
                PATCH_IF rgd = 64 BEGIN
                  SPRINT sn ~agrandrp~
                END ELSE BEGIN
                  PATCH_IF rgd = 65 BEGIN
                    SPRINT sn ~agrandlx~
                  END ELSE BEGIN
                    PATCH_IF rgd = 66 BEGIN
                      SPRINT sn ~agrandcl~
                    END ELSE BEGIN
                      PATCH_IF rgd = 67 BEGIN
                        SPRINT sn ~agrandrg~
                      END ELSE BEGIN
                        PATCH_IF rgd = 68 BEGIN
                          SPRINT sn ~agrandea~
                        END ELSE BEGIN
                          PATCH_IF rgd = 69 BEGIN
                            SPRINT sn ~agrandsh~
                          END ELSE BEGIN
                            PATCH_IF rgd = 70 BEGIN
                              SPRINT sn ~agrandsw~
                            END ELSE BEGIN
                              PATCH_IF rgd = 71 BEGIN
                                SPRINT sn ~agrandnc~
                              END
                            END
                          END
                        END
                      END
                    END
                  END
                END
              END
            END
          END
          PATCH_INCLUDE ~aurora/lib/fj_cre_validity.tpp~
          PATCH_IF vl BEGIN
            PATCH_INCLUDE ~aurora/lib/fj_cre_reindex.tpp~
            SPRINT sz ~%SOURCE_RES%~
            READ_STRREF 0x8 nm //Name
            PATCH_IF fg = 1 BEGIN
              WRITE_ASCIIE 0x268 ~%s4%~ #8
            END
            WRITE_ASCIIE sf ~%sn%~ #8
            INNER_ACTION BEGIN
              APPEND_OUTER ~aurora/batchlog/ag_scripted_cres.txt~ ~%sz%    %nm%    Slot %sf%    %sn%~
            END
          END
        END
      END
    BUT_ONLY

 

 

The problem I see with this is that it's going to destructively overwrite the Default script for a CRE that has all 5 script slots filled with the berry script. I would guess that in a megamodded installation with fucktons of AI mods and shit, it would be easy to find CREs with all 5 filled script slots.

 

We can modify the code so Aurora doesn't even patch CREs with 5 filled script slots

 

Modified code:

Spoiler

    COPY_EXISTING ~%tcr%.cre~ ~override~
      PATCH_IF SOURCE_SIZE > 0x71 BEGIN
        sf = 0 //Script offset
        fg = 0 //Ending script
        rgd = 0 //Random number
        READ_ASCII 0x250 s1 //Class script
        PATCH_IF (~%s1%~ STRING_EQUAL_CASE ~none~ = 1) OR (~%s1%~ STRING_EQUAL ~~ = 1) BEGIN
          sf = 0x250
        END ELSE BEGIN
          READ_ASCII 0x248 s2 //Override script
          PATCH_IF (~%s2%~ STRING_EQUAL_CASE ~none~ = 1) OR (~%s2%~ STRING_EQUAL ~~ = 1) BEGIN
            sf = 0x248
          END ELSE BEGIN
            READ_ASCII 0x258 s3 //Race script
            PATCH_IF (~%s3%~ STRING_EQUAL_CASE ~none~ = 1) OR (~%s3%~ STRING_EQUAL ~~ = 1) BEGIN
              sf = 0x258
            END ELSE BEGIN
              READ_ASCII 0x260 s4 //General script
              PATCH_IF (~%s4%~ STRING_EQUAL_CASE ~none~ = 1) OR (~%s4%~ STRING_EQUAL ~~ = 1) BEGIN
                sf = 0x260
              END ELSE BEGIN
                READ_ASCII 0x268 s5 //Default script
                PATCH_IF (~%s5%~ STRING_EQUAL_CASE ~none~ = 1) OR (~%s5%~ STRING_EQUAL ~~ = 1) BEGIN
                  sf = 0x268
                END ELSE BEGIN
                  fg = 1
                END
              END
            END
          END
        END
        PATCH_IF sf > 0 BEGIN
          PATCH_RANDOM_SEED null
          rgd = RANDOM(1 rgf)
          PATCH_IF rgd < 33 BEGIN
            SPRINT sn ~agrandbr~
          END ELSE BEGIN
            PATCH_IF rgd < 63 BEGIN
              SPRINT sn ~agrandrb~
            END ELSE BEGIN
              PATCH_IF rgd = 63 BEGIN
                SPRINT sn ~agrandsr~
              END ELSE BEGIN
                PATCH_IF rgd = 64 BEGIN
                  SPRINT sn ~agrandrp~
                END ELSE BEGIN
                  PATCH_IF rgd = 65 BEGIN
                    SPRINT sn ~agrandlx~
                  END ELSE BEGIN
                    PATCH_IF rgd = 66 BEGIN
                      SPRINT sn ~agrandcl~
                    END ELSE BEGIN
                      PATCH_IF rgd = 67 BEGIN
                        SPRINT sn ~agrandrg~
                      END ELSE BEGIN
                        PATCH_IF rgd = 68 BEGIN
                          SPRINT sn ~agrandea~
                        END ELSE BEGIN
                          PATCH_IF rgd = 69 BEGIN
                            SPRINT sn ~agrandsh~
                          END ELSE BEGIN
                            PATCH_IF rgd = 70 BEGIN
                              SPRINT sn ~agrandsw~
                            END ELSE BEGIN
                              PATCH_IF rgd = 71 BEGIN
                                SPRINT sn ~agrandnc~
                              END
                            END
                          END
                        END
                      END
                    END
                  END
                END
              END
            END
          END
          PATCH_INCLUDE ~aurora/lib/fj_cre_validity.tpp~
          PATCH_IF vl BEGIN
            PATCH_INCLUDE ~aurora/lib/fj_cre_reindex.tpp~
            SPRINT sz ~%SOURCE_RES%~
            READ_STRREF 0x8 nm //Name
            PATCH_IF fg = 0 BEGIN
              WRITE_ASCIIE sf ~%sn%~ #8
            END
            INNER_ACTION BEGIN
              APPEND_OUTER ~aurora/batchlog/ag_scripted_cres.txt~ ~%sz%    %nm%    Slot %sf%    %sn%~
            END
          END
        END
      END
    BUT_ONLY

 

 

That should save a few headaches

Edited by Lollorian, 13 September 2015 - 02:02 AM.

[Lollorian]

It's a good thing I decided to do a test before including this because I think I spoke too soon Aurora does not overwrite 5 scripted CREs so your issue is something else

 

The trick that I failed to notice earlier was the "sf" variable it uses - "sf" = 0 when all 5 scripts are filled for a CRE so it never passes the "sf > 0" check to go into the block that writes the new script

 

To summarize, something else fucked with your Abazigal

Edited by Lollorian, 13 September 2015 - 02:00 AM.