Jump to content


Photo

Missing animations for quarterstaves


  • Please log in to reply
17 replies to this topic

#1 Ithildur

Ithildur
  • Member
  • 170 posts

Posted 29 January 2016 - 12:18 AM

I realize the mod author isn't around lately so I'll probably post this both here and in the BWS/BWP forums, since the version of 1pp I used was the latest 4.x BWS/BWP Fixpacked version.

 

I'm getting assertion error ctd's whenever certain magical quarterstaves are equipped by creatures both party members and otherwise; 1PP patches these items to use new equipped appearance animations (Q2, Q3, Q4), but the actual animation is missing for both inventory screen as well as in game screen (missing appearance in inventory/simply equipping the item while in inventory screen does not crash the game, but switching to the main game screen will result in an assertion error ctd - this happens whenever an npc appears in the game with one of these magical staves equipped as well, obviously).

 

Oddly enough equipped appearance GS (which is another custom animation that 1PP adds) for the staff of the Magi works fine.

 

I tried to set up a partial install on a separate folder with only tobex, bg2fixpack, and 1pp with the exact same components installed, and got the exact same results.

 

Spoiler

 

Specifically, it's component 400 that patches these staves to use the new animations.


Edited by Ithildur, 29 January 2016 - 12:20 AM.


#2 Ithildur

Ithildur
  • Member
  • 170 posts

Posted 29 January 2016 - 12:47 AM

Ok, it seems like installing component 400 without component 210 is the issue. Adding component 210 to the above installation puts the missing animations into the game and resolves this issue.

 

So it's essentially a dependency of mod component issue; the problem is imo there isn't a clear enough warning in either the documentation or the install process that warns you that you need 210 in order to install 400 without issues. The annotation at the bottom of the documentation for 210 does say:

 

Note that this is a core component; by itself it does not contain any item patches. If installed, the content will instead be used by following 1ppv4 components to give you more options when updating.

 

However, the information at the top of documentation for 400 lists 210 under 'suggested' rather than required. Also the part about 'IF installed, the content will instead be used by following ... etc' makes it sound like it's optional.


Edited by Ithildur, 29 January 2016 - 01:10 AM.


#3 The Imp

The Imp

    Not good, see EVIL is better. You'll LIVE.

  • Member
  • 4792 posts

Posted 29 January 2016 - 03:10 AM

Hmm, can you check if the 400 actually needs the component 200, or just the 210 ?

Yep, Jarno Mikkola. my Mega Mod FAQ. Use of the BWS, and how to use it(scroll down that post a bit). 
OK, desert dweller, welcome to the sanity, you are free to search for the limit, it's out there, we drew it in the sand. Ouh, actually it was still snow then.. but anyways.


#4 Ithildur

Ithildur
  • Member
  • 170 posts

Posted 29 January 2016 - 07:37 AM

As you can see in the weidu.log in the first post, 200 was installed when the errors were occuring. If you're asking whether 200 can be skipped for 400 to work, the notes for 400 lists 200 as 'Required', and 210 as 'Suggested'... which is where the problem springs from; you need both to avoid the crashing staves.

 

Adding component 210 to the above installation puts the missing animations into the game and resolves this issue.

Edited by Ithildur, 29 January 2016 - 08:16 AM.


#5 agb1

agb1
  • Member
  • 1623 posts

Posted 29 January 2016 - 07:45 AM

While we are discussing 1pp issues, if I may go on a tangent here -- does anyone know if 1pp 113 (the smart avatar switching component) is included in Item Revisions?

 

I have a conflict rule for that particular cosmetic tweak and I'm wondering if it is incomplete -- Change avatar depending on equipped armor=C:1pp(113):BDToBv173(16):BG2_Tweaks(50):BG2_Tweaks(120)


BiG World Fixpack (community collection of mod fixes and compatibility patches, with user-friendly cross-platform script)

 

BiG World Setup (tool to automate best-practice installation of Infinity Engine mods on Windows, with conflict analysis)

Latest version:    https://bitbucket.or.../get/master.zip


#6 Ithildur

Ithildur
  • Member
  • 170 posts

Posted 29 January 2016 - 07:47 AM

bit of a tangent here as well (I do not know the answer to your question agb1), but the smart avatar switching component has some oddities when interacting with things like the belt of gender (which obviously swaps out your ingame avatar and paperdoll. In future installations I may opt to avoid installing this component of 1PP v4; not sure if Item Revisions has a better version (or if the component from BG2Tweaks might be preferable).

 

1pp is a wonderful mod, but v4 ideally needs some ongoing support from either the author or someone else.


Edited by Ithildur, 29 January 2016 - 07:54 AM.


#7 agb1

agb1
  • Member
  • 1623 posts

Posted 29 January 2016 - 07:50 AM

Here are all the BWS rules that currently include 1pp:

 

Line 217: Change avatar depending on equipped armor=C:1pp(113):BDToBv173(16):BG2_Tweaks(120):BG2_Tweaks(50)
Line 252: 1pp conflict with IR=C:item_rev(0):1pp(205|206|208)
Line 456: 1pp conflict with IA=C:1pp(203|204):infinityanimations(8000|8010|8020|8030|9500|9510|9520)
Line 504: Requires 1pp component=D:1pp(105|200|203|204|205|206|207|208|209|210):1pp(101)
Line 505: Requires 1pp component=D:1pp(400):1pp(101&200&210)
Line 506: Requires 1pp component=D:1pp(401):1pp(400)
Line 683: Choose one "restore Shadows of Amn loading screen" GUI tweak=C:1pp(104):bg2_tweaks(80)
Line 685: Choose one "Avatar Switching" tweak=C:1pp(113):BG2_Tweaks(50):BG2_Tweaks(120) // this is redundant with the top rule - will remove
Line 714: Choose one GUI=C:W_GUI(-):1pp(104):TutuGui(-)

Edited by agb1, 29 January 2016 - 07:52 AM.

BiG World Fixpack (community collection of mod fixes and compatibility patches, with user-friendly cross-platform script)

 

BiG World Setup (tool to automate best-practice installation of Infinity Engine mods on Windows, with conflict analysis)

Latest version:    https://bitbucket.or.../get/master.zip


#8 Mike1072

Mike1072
  • Member
  • 535 posts

Posted 29 January 2016 - 07:58 AM

While we are discussing 1pp issues, if I may go on a tangent here -- does anyone know if 1pp 113 (the smart avatar switching component) is included in Item Revisions?

 

It's not.

This is what we suggest for 1PPv4 and IRv4.

 

Install Before IR's Main Component:

101. Core Paperdolls (included in IR but required for other 1PP components)
400. Core Updates and Item Patches (partially included in IR but required for other 1PP components)
401. Improved Projectile Effects


Install After IR's Main Component:
113. Smart Avatar & Armour Switching
210. Increased Paperdoll Object Variety (core)

 

Install in Any Order:
102. Extended Palette Entries
104. GUI Additions for BGII
105. Avatar Fixes
106. Female Dwarves
110. Thieves Galore
114. Softer Spell Effects
201. Consistent Spell and Scroll Icons
202. Spell Tweaks
209. Attachable Wings (core)
300. Fixed Animations for Solars and Elementals
301. Miscellaneous Content Fixes

 

Don't Install Because They're Already Included:
203. Restored Flame Sword Animations
204. Colourable Quarterstaves (not actually included yet, but will be)
205. Legacy Shields v2
206. Additional Shield Animations (core)
207. Wizards' Staves (core) (not actually included yet, but will be)
208. Additional Helmet Animations (core)


Edited by Mike1072, 29 January 2016 - 08:25 AM.


#9 agb1

agb1
  • Member
  • 1623 posts

Posted 29 January 2016 - 08:00 AM

Thanks Mike.


BiG World Fixpack (community collection of mod fixes and compatibility patches, with user-friendly cross-platform script)

 

BiG World Setup (tool to automate best-practice installation of Infinity Engine mods on Windows, with conflict analysis)

Latest version:    https://bitbucket.or.../get/master.zip


#10 Mike1072

Mike1072
  • Member
  • 535 posts

Posted 29 January 2016 - 08:25 AM

I've added some of the info from our v4 beta readme.



#11 The Imp

The Imp

    Not good, see EVIL is better. You'll LIVE.

  • Member
  • 4792 posts

Posted 29 January 2016 - 08:31 AM

the notes for 400 lists 200 as 'Required'
And I asked if that was actually the case ? Nothing about the 210, which is.
Could it be that as the mod adds animation circles, that the component number got switched at some point between the 400 requiring the 200 instead of 210.

Yep, Jarno Mikkola. my Mega Mod FAQ. Use of the BWS, and how to use it(scroll down that post a bit). 
OK, desert dweller, welcome to the sanity, you are free to search for the limit, it's out there, we drew it in the sand. Ouh, actually it was still snow then.. but anyways.


#12 agb1

agb1
  • Member
  • 1623 posts

Posted 29 January 2016 - 08:37 AM

Does IRv4 #0 need to be installed before or after SRv4 #0?


BiG World Fixpack (community collection of mod fixes and compatibility patches, with user-friendly cross-platform script)

 

BiG World Setup (tool to automate best-practice installation of Infinity Engine mods on Windows, with conflict analysis)

Latest version:    https://bitbucket.or.../get/master.zip


#13 Mike1072

Mike1072
  • Member
  • 535 posts

Posted 29 January 2016 - 08:49 AM

Does IRv4 #0 need to be installed before or after SRv4 #0?

 

I don't think it really matters, but in the overall mod landscape, it's usually more important to install IR earlier.


Edited by Mike1072, 29 January 2016 - 08:50 AM.


#14 agb1

agb1
  • Member
  • 1623 posts

Posted 29 January 2016 - 08:56 AM

1pp component 400 offers additional ACTION_READLN choices depending if components 206 (shields) and/or 208 (helmets) are installed first.  Clearly these two (206 and 208) are meant to be optional for 400.

 

1pp component 400 has extra code that is only executed if 207 (staves) and/or 210 (swords and blunts) are installed.  I wonder if 207 is an undocumented requirement like 210.


BiG World Fixpack (community collection of mod fixes and compatibility patches, with user-friendly cross-platform script)

 

BiG World Setup (tool to automate best-practice installation of Infinity Engine mods on Windows, with conflict analysis)

Latest version:    https://bitbucket.or.../get/master.zip


#15 Mike1072

Mike1072
  • Member
  • 535 posts

Posted 29 January 2016 - 09:32 AM

According to the readme, component 400 should only require 101 and 200.  The components marked (core) are not supposed to do anything except install animations/paperdolls that component 400 can apply to items within the game.

 

It sounds like the problem is that component 400 didn't properly detect that the required component was installed.  Instead of marking that component as a prerequisite, component 400 should be fixed to function as described.



#16 agb1

agb1
  • Member
  • 1623 posts

Posted 29 January 2016 - 10:27 PM

The recommendation to install 1pp 210 after IR main component after 1pp 400 is problematic because 400 has conditional code for 210 that will never be invoked with 210 after 400.  This means we need a different install order depending on whether IR will be part of the installation.  A possible solution would be to split the portion of 1pp 400 that is conditional on 210 into a separate component that we can install after IR...


Edited by agb1, 29 January 2016 - 10:34 PM.

BiG World Fixpack (community collection of mod fixes and compatibility patches, with user-friendly cross-platform script)

 

BiG World Setup (tool to automate best-practice installation of Infinity Engine mods on Windows, with conflict analysis)

Latest version:    https://bitbucket.or.../get/master.zip


#17 Mike1072

Mike1072
  • Member
  • 535 posts

Posted 30 January 2016 - 12:27 AM

I'll have to look at the code again to give a recommendation.  I think 210 does something to item files in addition to installing new animations.  I'm not sure what it's doing exactly, but since it is a (core) component, maybe that code would be better suited in 400, and 210 can be installed before IR.



#18 Ithildur

Ithildur
  • Member
  • 170 posts

Posted 30 January 2016 - 03:09 AM

[edit] nm...


Edited by Ithildur, 30 January 2016 - 03:14 AM.