366 replies to this topic

[MikeX]

Hi Insomniator.

 

just a short note:

 

The panel height and buttons are fixed, fantastic, thank you very much!

 

Also the new centering of the loot slot bar looks very nice.

 

'lootpanel.tph' has still an issue using the right mos for patching (at least for my resolution and 'Restored x2 Scaled GUI'), see attached ingame screenshot in Baldr005.bmp.

Debug:

Spoiler

Installing [Loot Panel -> Classic EE mode] [5.1]
Copying 1 file ...
[bg2improvedgui/files/TobEx.dll] loaded, 602624 bytes
TobEx.dll copied to bg2improvedgui/backup/110/TobEx.dll, 600576 bytes
Copied [bg2improvedgui/files/TobEx.dll] to [TobEx.dll]
Copying 1 file ...
[bg2improvedgui/files/XCrashReport.exe] loaded, 91136 bytes
XCrashReport.exe copied to bg2improvedgui/backup/110/XCrashReport.exe, 91136 bytes
Copied [bg2improvedgui/files/XCrashReport.exe] to [XCrashReport.exe]
Copying 3 files ...
[bg2improvedgui/loot_panel/files/GUICONTB.MOS] loaded, 117264 bytes
override/GUICONTB.MOS copied to bg2improvedgui/backup/110/GUICONTB.MOS, 117264 bytes
Copied [bg2improvedgui/loot_panel/files/GUICONTB.MOS] to [override/GUICONTB.MOS]
[bg2improvedgui/loot_panel/files/GMPWMSG8.MOS] loaded, 148116 bytes
Copied [bg2improvedgui/loot_panel/files/GMPWMSG8.MOS] to [override/GMPWMSG8.MOS]
[bg2improvedgui/loot_panel/files/GMPWMSG0.MOS] loaded, 187608 bytes
override/GMPWMSG0.MOS copied to bg2improvedgui/backup/110/GMPWMSG0.MOS, 117264 bytes
Copied [bg2improvedgui/loot_panel/files/GMPWMSG0.MOS] to [override/GMPWMSG0.MOS]
Copying and patching 3 files ...
BIFF may be in hard-drive CD-path [C:\GOG Games\Baldur's Gate 2 PI2\data\\DATA\GUICHUI.BIF]
BIFF may be in hard-drive CD-path [C:\GOG Games\Baldur's Gate 2 PI2\data\\DATA\GUICHUI.BIF]
BIFF may be in hard-drive CD-path [C:\GOG Games\Baldur's Gate 2 PI2\data\\DATA\GUICHUI.BIF]
BIFF may be in hard-drive CD-path [C:\GOG Games\Baldur's Gate 2 PI2\data\\DATA\GUICHUI.BIF]
BIFF may be in hard-drive CD-path [C:\GOG Games\Baldur's Gate 2 PI2\data\\DATA\GUICHUI.BIF]
BIFF may be in hard-drive CD-path [C:\GOG Games\Baldur's Gate 2 PI2\data\\DATA\GUICHUI.BIF]
BIFF may be in hard-drive CD-path [C:\GOG Games\Baldur's Gate 2 PI2\DATA\GUICHUI.BIF]
[C:\GOG Games\Baldur's Gate 2 PI2\DATA\GUICHUI.BIF] 158458 bytes, 27 files, 0 tilesets
Copied [guiw.chu] to [override/guiw.chu]
Copied [guiw08.chu] to [override/guiw08.chu]
[./override/guiw10.chu] loaded, 7926 bytes

Found Widescreen Mod patched guiw10.chu 960x150
override/guiw10.chu copied to bg2improvedgui/backup/110/guiw10.chu, 7926 bytes
Copied [guiw10.chu] to [override/guiw10.chu]
Copying and patching 1 file ...
[TobEx_ini/TobExTweak.ini] loaded, 1804 bytes
[bg2improvedgui/loot_panel/files/TobEx_nogroups.txt] loaded, 118 bytes
TobEx_ini/TobExTweak.ini copied to bg2improvedgui/backup/110/TobExTweak.ini, 1804 bytes
Copied [TobEx_ini/TobExTweak.ini] to [TobEx_ini/TobExTweak.ini]
Copying and patching 1 file ...
[./override/GMPWMSG8.MOS] loaded, 148116 bytes

GMPWMSG8.MOS->GUICONTB.MOS enlarged to 960, H390
Copied [GMPWMSG8.MOS] to [override\GUICONTB.MOS]

 

I fixed it locally, but have to run more tests on different resolutions.

Basically, I read which mos is used in the chu and patch the expanded mos with the same name that your mod provides.

Your mod provides expanded mos for the base game and 2 GUI mods (TutuGUI and GUI_720).

I attached my current version (and an ingame screenhot in Baldr004.bmp), if you want to have a look.

 

I will be back with more test results and probably more questions.

 

[Insomniator]

Hi Salk

Great!

https://anonfiles.co...0c3ye/TobEx_zip

 

add new UI:Damage Info On Record Screen=1 to installed TobExTweak.ini

 

i have additional installer option to install only on record screen, but manualy editing TobExTweak.ini is enough

[Insomniator]

Hi MikeX
 

'lootpanel.tph' has still an issue using the right mos for patching (at least for my resolution and 'Restored x2 Scaled GUI'), see attached ingame screenshot in Baldr005.bmp.

I fixed it locally, but have to run more tests on different resolutions.
Basically, I read which mos is used in the chu and patch the expanded mos with the same name that your mod provides.
Your mod provides expanded mos for the base game and 2 GUI mods (TutuGUI and GUI_720).
I attached my current version (and an ingame screenhot in Baldr004.bmp), if you want to have a look.
I will be back with more test results and probably more questions.

To solve this issue, my installer must track how .MOS was enlarged by widescreen (H*** parameter) or how cells/gold was shifted.
Main problem - i think widescreen try to "center" right cells on some resolution conditions, for 940x540 it take 640x480 base image and enlarge it to 960x90 with inserting free space in CENTER, so inventory cells shifted to right border, then it shifts cells's X and Gold's coordinates by patching .CHU

If i set 940x600 resolution, it stops shifting and use 800x600 base image. It has complicated logic to when shifts and when not for same X Resolution
 
Also Widescreen's enlarging 640x90 ->960x90  has artifacts:

 

Widescreen's enlarging 800x90 ->960x90 without shifting:

 

Edited by Insomniator, 04 May 2022 - 01:30 AM.

[Salk]

Hello, my friend!

 

Hi Salk

Great!

https://anonfiles.co...0c3ye/TobEx_zip

 

add new UI:Damage Info On Record Screen=1 to installed TobExTweak.ini

 

i have additional installer option to install only on record screen, but manualy editing TobExTweak.ini is enough

 

Very much appreciated! 

[Insomniator]

MikeX, fixed version:

• .MOS renaming removed
• tutugui enlarge position fixed

Attached Files

•  lootpanel.tph   18.02K   56 downloads

Edited by Insomniator, 04 May 2022 - 05:40 AM.

[MikeX]

MikeX, fixed version:

• .MOS renaming removed
• tutugui enlarge position fixed

Hi Insomniator,

 

tested your 'lootpanel.tph' shortly only with my resolution and it seems to work now, thank's.

 

I still think the 'Hxxx' parameter could be fix (independent of the desired width), only dependent on which of the mod provided mos needs to be used and extended.

 

Do you have any insight about how 'Extend_Mos' works, especially the 'Hxxx' ('Vxxx') parameter?

The WeiDU readme says the command needs to be documented...

I know the number xxx is the position at which some area of the mos is duplicated.

The duplicated area is the one after the position, but to what widht/height?

Also the inserted duplicated area seems to be split in between.

 

With this:

COPY_EXISTING ~MAP.MOS~ ~override\MAP1.MOS~
    EXTEND_MOS "H100" 600
BUT_ONLY
COPY_EXISTING ~MAP.MOS~ ~override\MAP2.MOS~
    EXTEND_MOS "H100" 1200
BUT_ONLY

 

you get this (Source Map.mos, Map1.mos, Map2.mos):

[Insomniator]

Hi MikeX,

I still think the 'Hxxx' parameter could be fix (independent of the desired width), only dependent on which of the mod provided mos needs to be used and extended.
 
Do you have any insight about how 'Extend_Mos' works, especially the 'Hxxx' ('Vxxx') parameter?
The WeiDU readme says the command needs to be documented...
I know the number xxx is the position at which some area of the mos is duplicated.
The duplicated area is the one after the position, but to what widht/height?
Also the inserted duplicated area seems to be split in between.

I can not tell how Hxxx works, i just tried different numbers to see on what horizontal pixel doublicating was started.
Fortunately for contaner background one xxx parameter give proper start X coord and widht to shift
 
Weidu sources available, but OCAML is difficult to understand

Spoiler

 

 TP_Extend_Mos(where,howMuch) ->
        begin
          let howMuch = Int32.to_int (eval_pe buff game howMuch) in
          let where = String.uppercase (Var.get_string where) in
          let (buff',xSizeP,ySizeP) = Mos.size_of_str buff in
          let first,duplicate = where.[0], Str.string_after where 1 in
          let isdup,duplicate = try true, int_of_string duplicate with _ ->
            false, 0 - 1 in
          let (nxSizeP, nySizeP) = match where with
          | "TOP" | "BOTTOM" | "VCENT" -> if ySizeP > howMuch then
              failwith "EXTEND_MOS can't shrink" else xSizeP, howMuch
          | "LEFT" | "RIGHT" | "HCENT"  -> if xSizeP > howMuch then
              failwith "EXTEND_MOS can't shrink" else howMuch, ySizeP
          | _ -> (match first,isdup with
            | 'V',true -> if ySizeP > howMuch then
                failwith "EXTEND_MOS can't shrink" else xSizeP, howMuch
            | 'H',true -> if xSizeP > howMuch then
                failwith "EXTEND_MOS can't shrink" else howMuch, ySizeP
            | _ -> failwith
                  (Printf.sprintf "Unknown EXTEND_MOS mode: %s" where)) in
          if (nxSizeP,nySizeP) <> (xSizeP,ySizeP) then begin
            let old_mos = Mos.mos_of_str buff' in
            if !debug_ocaml then
              log_and_print "Extend_mos %s %d to a %dx%d (%c %b)\n"
                where howMuch xSizeP ySizeP first isdup;
            let startPos = match String.uppercase where with
            | "TOP" -> (0,nySizeP - ySizeP)
            | "BOTTOM" -> (0,0)
            | "VCENT" -> (0,(nySizeP - ySizeP)/2)
            | "LEFT" -> (nxSizeP - xSizeP,0)
            | "RIGHT" -> (0,0)
            | "HCENT" -> ((nxSizeP - xSizeP)/2,0)
            | _ -> (0,0) in
            let (xStart,yStart) = startPos in
            let new_mos = Array.init nxSizeP (fun i ->
              (Array.make nySizeP (Mos.Pixel(0,0,0,0))) ) in
            let getY i =
              if isdup then begin
                if first = 'V' then begin
                  if i < duplicate then i else i + nySizeP - ySizeP
                end else i
              end else i in
            let getX i =
              if isdup then begin
                if first = 'H' then begin
                  if i < duplicate then i else i + nxSizeP - xSizeP
                end else i
              end else i in
            for i = 0 to xSizeP - 1 do
              for j = 0 to ySizeP - 1 do
                new_mos.(xStart + getX i).(yStart + getY j) <- old_mos.(i).(j);
              done
            done;
            if isdup then begin try
              if first = 'H' then begin
                for i = duplicate to duplicate + nxSizeP - xSizeP do
                  for j = 0 to ySizeP - 1 do
                    new_mos.(i).(j) <- old_mos.(duplicate + (i mod 100)).(j);
                  done
                done
              end else begin
                for i = 0 to xSizeP - 1 do
                  for j = duplicate to duplicate + nySizeP - ySizeP do
                    new_mos.(i).(j) <- old_mos.(i).(duplicate + (j mod 100));
                  done
                done
              end
            with _ -> () end;
            Mos.str_of_mos new_mos
          end else buff
        end

Edited by Insomniator, 05 May 2022 - 10:43 AM.

[MikeX]

Hi Insomniator,

 

that's what I figured out:

Hxxx parameter duplicates a maximum of 100 pixel starting from pixel xxx to the right and adds them at pixel xxx.

If less are needed to reach the desired width, it duplicated only the needed amount.

If more are needed than it adds the duplicated pixels again (or a fraction of it) until the desired width is reached.

 

So as I thought, Hxxx should only be dependent of the used mos and whether TutuGUI is used or not:

Spoiler

OUTER_TEXT_SPRINT HMode "H000"
ACTION_IF (%need_mos_enlarge% > 0) BEGIN //enlarge MOS width
ACTION_IF ("%BackroundImage%" STRING_EQUAL_CASE "GUICONTB") BEGIN
OUTER_TEXT_SPRINT HMode "H240"
END
ACTION_IF ("%BackroundImage%" STRING_EQUAL_CASE "GMPWMSGB") BEGIN //TutuGUI only
OUTER_TEXT_SPRINT HMode "H150"
END
ACTION_IF ("%BackroundImage%" STRING_EQUAL_CASE "GMPWMSG8") BEGIN
OUTER_TEXT_SPRINT HMode "H395"
ACTION_IF (TutuGUI = 1) BEGIN
OUTER_TEXT_SPRINT HMode "H250"
END
END
ACTION_IF ("%BackroundImage%" STRING_EQUAL_CASE "GMPWMSG0") BEGIN
OUTER_TEXT_SPRINT HMode "H620"
ACTION_IF (TutuGUI = 1) BEGIN
OUTER_TEXT_SPRINT HMode "H400"
END
END
ACTION_IF ("%HMode%" STRING_EQUAL_CASE "H000") BEGIN
PRINT ~%BackroundImage%.MOS unknown to this mod, may not be compatible!~
END ELSE BEGIN
PRINT ~%BackroundImage%.MOS enlarged to width x = %PanelWidth%, using mode %HMode%~
COPY_EXISTING ~%BackroundImage%.MOS~ ~override~
EXTEND_MOS ~%HMode%~ %PanelWidth%
BUT_ONLY
END
END ELSE BEGIN
PRINT ~%BackroundImage%.MOS with width x = %PanelWidth%~
END

END

 

Tested the attached lootpanel.tph w/ and w/o TutuGUI and GUI_720 on many different resolutions, looked up the result in NI.

If the label for the available gold fits the place for it at the mos, everything should be fine.

[Insomniator]

Updated to v5.3

• Block Door/Portals/Area Escape if enemy is in sight (difficulty tweak)
• Allow enemy to bump invisible/invulnerable party members (difficulty tweak)

[Charriu]

One of the best mods out there. But my problem right now is the following. I'm constantly thinking about switching from the classic games to the enhanced edition. There are some few mods of mine that don't work on enhanced edition and this mod is one of them. At the same time I know that some features like the loot bar can also be found in the enhanced edition. But what about the other components? Which can also be found in the enhanced edition?

[ALIEN]

My layzy crafted list:

 

Mods:

Mods:
+ Show NPC's active effects on right mouse click - Bubb Spell Menu
+ Hide Static(by equipped items) Icons on Portrait - Tweaks Anthology
+ Disable Portrait Icons Added by Class Abilities/Equipped Items - Tweaks Anthology

EE:

EE:
+ Loot panel
+ Colorize icon of not memorized scrolls
+ Hide "Write magic" button for already known spells and for opposition schools
+ Show HitPoints on NPC/Party when pressed TAB key
+ THAC0 and Damage info on Inventory screen
+ Dark portraits on party when dragging not allowed items
+ Total Roll info on Character creation screen
+ Journal with fold/unfold quests
+ Greyscale background on Pause
+ Unlimited Hand off slot
+ Extended messages/sounds about item/quest/worldmap events
+ Extended roll/damage combat text
? Do not clear drained spells
+ Show Hit Points/Action on Portrait
+ Yellow Border on Portrait if Party Member too far for Item Transfer
+ Legacy of Bhaal difficulty mode
+ Highlight Active Zones/Points
+ Double Mouse Render Rate
? BG1 Style Greeting
+ Fast ProgressBar Screen
+ Scaled GUI
? Shift Subtitles Below Movie Frame
+ Spell Sequencer Panel
+ Hide 'Special Abilities' button if necessary
? Exchange "Turn Undead" and "Pick Pockets" buttons for Cleric/Thief multiclass
+ Improved Store&Bag Interface
? Custom hotkeys
+ Innate/Ability/Spell Description Screen on Right Click
+ Colored Selection Circles
+ New Spell Selection Overlay Menu
+ Borderless World Map
+ Show Float NPC Names ('Alt' key)
+ Auto Switch Spell Book between Priest and Mage
+ Additional Character Information on Record Screen (intoxication, fatigue, luck, casting speed)
+ Normalize Sound Volume
+ Add Pause To Save Game
+ Additional Icons on Portrait (improved invisibility, blur/mirror image)
? Block Door/Portals/Area Escape if enemy is in sight (difficulty tweak)
? Allow enemy to bump invisible/invulnerable party members (difficulty tweak)

Please correct me I'm wrong.

[parysm]

EE:
(...)
+ Additional Icons on Portrait (improved invisibility, blur/mirror image)
(...)

Please correct me I'm wrong.

 

This is not true. These spells do not add any icons on portrait.

Anyway, do you know how to add this feature to enhanced edition?

[Insomniator]

Icon of usual invisibility on portrait is also useful, but I did not find a suitable icon from standard STATES.BAM set

[MikeX]

Hi Insomniator,

 

bg2improvedgui.tp2, line 405 and 416:

 

I've changed this:

LAUNCH_ACTION_FUNCTION ~BLOCKTRANSITION...

to:

LAUNCH_ACTION_FUNCTION ~ENEMYCANBUMP...

 

Otherwise that component did not install.

[Insomniator]

Hi MikeX

I've changed this:

LAUNCH_ACTION_FUNCTION ~BLOCKTRANSITION...

to:

LAUNCH_ACTION_FUNCTION ~ENEMYCANBUMP...

 

Otherwise that component did not install.

Thanks for bugreport, i will update installer to remove this mistake
 

[MikeX]

Hi Insomniator,
 
on my latest BGT install attempt (using Project Infinity), I noticed that component #2400 had been skipped.
If I see/tested it right, this component requires either #2310 or #2320 to be installed.
But by the way this is enforced it only works if the components (#2310 OR #2320) AND #2400 are installed in one go.
If, like PI does, every component is going to be installed separately, this method of detecting an installed component does not work.
 
I 'd suggest instead of:
 
REQUIRE_PREDICATE (VARIABLE_IS_SET SCALED_X2) ~Skipped~
 
using this:
 
REQUIRE_PREDICATE (MOD_IS_INSTALLED ~bg2improvedgui.tp2~ 2310 || MOD_IS_INSTALLED ~bg2improvedgui.tp2~ 2320) @2402

with new line in 'setup.tra':
@2402 = ~Skipped, component #2310 or #2320 not installed~
 

The whole section in setup-*.tp2:

Spoiler

////////////////////////////////
// Scaled GUI
BEGIN @2310 DESIGNATED 2310
REQUIRE_PREDICATE FILE_EXISTS ~tobex.dll~ @-10003
SUBCOMPONENT @2300
INCLUDE ~bg2improvedgui/tobex.tph~
INCLUDE ~bg2improvedgui/stretch_gui/stretch_gui.tph~
LAUNCH_ACTION_FUNCTION ~STRETCHGUI~ INT_VAR option = 0 END

BEGIN @2320 DESIGNATED 2320
REQUIRE_PREDICATE FILE_EXISTS ~tobex.dll~ @-10003
SUBCOMPONENT @2300
INCLUDE ~bg2improvedgui/tobex.tph~
INCLUDE ~bg2improvedgui/stretch_gui/stretch_gui.tph~
LAUNCH_ACTION_FUNCTION ~STRETCHGUI~ INT_VAR option = 1 END

// Scaled GUI for WidescreeMod
BEGIN @2400 DESIGNATED 2400
REQUIRE_PREDICATE FILE_EXISTS ~tobex.dll~ @-10003
REQUIRE_PREDICATE (MOD_IS_INSTALLED ~widescreen.tp2~ 0) @2401
REQUIRE_PREDICATE (MOD_IS_INSTALLED ~bg2improvedgui.tp2~ 2310 || MOD_IS_INSTALLED ~bg2improvedgui.tp2~ 2320) @2402
INCLUDE ~bg2improvedgui/tobex.tph~
INCLUDE ~bg2improvedgui/stretch_gui/stretch_gui.tph~
LAUNCH_ACTION_FUNCTION ~STRETCHGUIWIDESCREENMODE~ END

////////////////////////////////

 

I tested it to may best knowledge under different circumstances and it seems to work as expected.
 
Thanks for this great mod.

 

[ALIEN]

Good catch MikeX, just for clarity, it's usual weidu behawior: you cannot set variable in one component and check it later in separate component because those components can be installed/uninstalled at different times.

[Insomniator]

MikeX, ALIEN

 

on my latest BGT install attempt (using Project Infinity), I noticed that component #2400 had been skippedIf I see/tested it right, this component requires either #2310 or #2320 to be installed. But by the way this is enforced it only works if the components (#2310 OR #2320) AND #2400 are installed in one go. If, like PI does, every component is going to be installed separately, this method of detecting an installed component does not work.

....

I tested it to may best knowledge under different circumstances and it seems to work as expected.

 

Good catch MikeX,

just for clarity, it's usual weidu behawior: you cannot set variable in one component and check it later in separate component because those components can be installed/uninstalled at different times

 

 

Thanks for report, now i see using temp markers between componets is wrong way

Edited by Insomniator, 27 August 2022 - 01:35 PM.

[ALIEN]

@Insomniator

 

I know that it's lot of work to deal with disassembly in order to create this mod and you don't have time to spend on other weidu factors but can I suggest you to not do any 'markers'? Using MikeX code has better outcome since it can be easy detected by other mods and mod managers.

[Insomniator]

ALIEN,

Using MikeX code has better outcome since it can be easy detected by other mods and mod managers.

OK, i will fix installer to use MOD_IS_INSTALLED() marker