Jump to content


Miloch

Member Since 20 Oct 2006
Offline Last Active Jan 01 2021 11:22 PM

Posts I've Made

In Topic: List of problems

01 January 2021 - 11:12 PM

You might want to attach the files your change-log generated, or you can do some of this yourself with an editor (DLTCEP or NearInfinity). For c-cs.itm, check the inventory icon. In my ancient BWP install, this file (ic-cs.bam) doesn't exist, so some other mod (or a later version to Deeper Shadows of Amn) may have added it. What you describe is a common issue; BAM Batcher in my signature has an option to fix such BAMs ("Fix inventory BAM coordinates"). Edit: you may want to do a change-log on that .bam file while you're at it too.

For telswd.itm (an item that exists in unmodded BG2), open the .itm files the change-log generates, look at the description string reference, and see at which point the description gets hosed, which should point you to the offending mod. My guess is Item Revisions (heh... old joke of mine... but your change-log does in fact list it among other mods that change the item).

 

In Topic: List of problems

26 December 2020 - 09:43 AM

I suggest editing the original post to paste your .txt file text directly. You could use bracketed

Spoiler
tags to collapse it, but as it isn't all that much text, that isn't really necessary.

 

The advantage is that modders and search engines can thus pick up the potential problems and fixes more readily, and you can also provide links to specific mod forums. Unfinished Business (UB) at least is in semi-active development last I checked, so being able to identify any issues with it will benefit its modders and players.

 

Also note that sometimes trying to change one thing (especially concerning direct dialogue modifications in dialog.tlk) can mess up something elsewhere.

 

Finally, what I noted with Vlad's Compilation (VCV20) should fix at least some of those issues, particularly with respect to creatures with botched inventory/spell slots and the like. And as the modder seems to sort of be around, explicitly noting those things as well might help.


In Topic: BWP 18.2 issues (Improved Coronet, Revised Battles, etc.)

19 December 2020 - 07:25 AM

I keep a list of problems that i run into, at the moment it is a little over 1 page, which is good, years ago i had it up over 4 pages.

It might be useful to both players and developers to post that somewhere. And if you've coded your own mods or fixes, you might as well share those too, however small they may be; all huge mods start small.

 

Make sure you also include that addition to Vlad's Compilation (Setup-VCv21.tp2) the next time you install it. Really, the .tp2 should include that code any time it does a .cre dump (overwriting existing ones in many cases), as it does in far more places than where I indicated. The BWP maintainers (if they're still active) should include this in their fixes as well. As I said, ideally it should patch instead of overwrite. If it were just a few .cre files, I'd fix it, but when I saw how many creatures it overwrites, I said ugh, forget it.


In Topic: Random treasure

19 December 2020 - 07:09 AM

I have taken a look to the ag_cres.tpa and one thing seem to be part of this behaviour - line 12 : STRING_EQUAL ~/*~; I think it should be ~*~ but I may be wrong.

Yeah, I forget STRING_EQUAL ignores regexp (for which we need / to quote the special regexp character *). The previous fix made sure * would not appear but did not address cases where you may have existing ones. Try this version for that.

Attached File  ag_cres.tpa   2.13K   216 downloads

 

Note that the game also ignores leading zeros in numeric values, as does SET_2DA_ENTRY(IES), so I didn't bother replicating those.

 


In Topic: BWP 18.2 issues (Improved Coronet, Revised Battles, etc.)

18 December 2020 - 03:56 AM

I see that the component from Stratagems is one that i have problems with. The mod VCV20 puts a file into the override that is corrupted somehow. That file also screws up the TBTweaks component, 'Mages drop spellbooks'. The offending file is SLMAGE1.cre. What i have always done is after i install the VCV20 mod, i take my backup copy of that file, which i have altered to make it work, and copied it into the override folder. The TBTweak mod and the Stratagem mods both load without problems.

I split your problems from this post because you raised potential issues with other mods that don't seem to be related to the random treasure issue at all. Vlad's Improved Coronet does indeed copy/overwrite slmage1.cre (and a bunch of other files) causing not-so-"harmless" inconsistencies (see attached):

Attached File  slmage01.gif   59.87K   261 downloads

 

Revised Battles then later globally patches all .cre files with an outdated copy of Nythrun's creature validity check/reordering macro/function, apparently causing further issues.

Attached File  slmage02.gif   55.95K   247 downloads

 

These functions are now built into and updated in WeiDU (the installer for all mods). It seems Revised Battle's goal may have been to correct creatures after the fact (at the end of its installer), but it makes more sense to correct them before doing any patching to avoid corruption and inconsistencies. Indeed, I thought BiG World Project did this long ago but perhaps not anymore. Thus, I suggest omitting that code from the RevisedBattles.tp2 file (comment it out by adding /* at line 5070 before "//The following code blatantly hijacked from Nythrun" and */ at the end of the file ~line 5385).

 

Revised (fka Improved) Battles hasn't received an update in a while, but its last support topic was here.

 

Jan's Alchemy has received a relatively recent update, so if you notice issues with it, you might want to report those here.

 

Proposed addition to Setup-VCv21.tp2 @ line 14117 (after COPY ~NeJE\bdash\coppercr\copy~ ~override~):

  PATCH_IF (~%SOURCE_EXT%~ STRING_EQUAL_CASE ~CRE~ = 1) BEGIN
    LAUNCH_PATCH_FUNCTION FJ_CRE_VALIDITY END
  END

This is a band-aid at best; the optimal solution is to patch the existing .cre files and compile scripts (.baf files) instead of overwriting/copying .bcs files, but no one likely has the time and expertise to do that. As a test, I copied the slmage1.cre from Improved Coronet and did a LAUNCH_PATCH_FUNCTION FJ_CRE_VALIDITY on it and then patched it (arbitrarily modified the creature gold field), and the resulting .cre appeared to be fine. Doing this at the time of any initial COPYs avoids such errors as the attached that occur with your subsequent SLMAGE1.cre files from your change-log.