4 replies to this topic

[pro5]

I'm posting here for lack of another place to support TS-BP.

Looking at TS-BP code:

1) Bonus merchants in TP2 code are always installed, even if already present - which may cause multiple instances of Joluv/Deidre to appear in corresponding areas.

2) tYOSHX.baf:
There are two duplicate Exists() triggers in the topmost script block:

IF
	InParty(Myself)
	InParty("Kachiko")
	HPPercentLT("Kachiko",50)
	!HP("Kachiko",1)
	Exists(LastAttackerOf("Kachiko"))
	Global("VP_Kachiko_Dies","GLOBAL",0)
	Exists(LastAttackerOf("Kachiko"))
THEN

It makes sense to change the second one to

See(LastAttackerOf("Kachiko"))

Edited by pro5, 17 October 2006 - 04:03 PM.

[Vlad]

And if Yoshimo does not see the last attacker of Kachiko, he won't help her? No, it's possible just to remove the duplicated line, but it does not hurt to leave it anyway.

[pro5]

It was actually part of a bigger change to the whole script on my part, if Yoshimo doesn't see Kachiko's attacker he just moves to her.

Edited by pro5, 23 October 2006 - 06:26 AM.

[Vlad]

Did you try this script in the game?

[pro5]

Did you try this script in the game?

No, sorry - it's untested.
I'm trying to build my own custom huge BG installation at the moment, and the first stage is to review all mods' code to solve possible problems and compatibility clashes. While I'm here I also modify small bits such as this to my taste.

Another non-critical issue found:

Interjections into Irenicus in Hell and Tree of Life dialogues do not use COPY_TRANS. I guess it's not a problem in regular version of TS, but TS-BP can be installed after other mods which add their own interjections to those dialogues.