Her religion is pretty much the most ridiculously flashy thing ever, hence two-weapon style being appropriate as a secondary skill. You're obviously welcome to shadowkeep it into whatever you'd prefer, of course.
I too was uncomfortable with the proficiency picks - from both a game play and role playing perspective.
I can easily see a Cavalier, especially a Paladin of Sune, going for 2 wpn style. However, if they have done so, I can't see them also going for 2-handed wpn style. It really strikes me as an either-or situation. [I suspect the heavy emphasis towards 2-handed style and 2-handed swd is due to the availability of Carsomyr, which everyone wants their Paladin to wave around.] So if she and her fath are flashy [a fair assumption] then I'd go with max ability in 2 wpn style and *NO* points in 2-handed weapons or 2-handed swd.
Her decision [in game] seems very unwise, for a Paladin class NPC who has a fairly high minimum stat in Wisdom. She has limited herself to two weapon choices only, the 2-hander and Long swds and isn't all that proficient in her supposedly preferred "flashy" style - only proficient in L swds and not fully proficient in 2 wpn style. This doesn't strikes me as a particularly "wise" choice. As indicated above, I feel it would be more "realistic" if she had decided to pursue one path or the other, either all out in 2-handed, or all out in 2 wpn, but not a hybrid of both.
Because of her odd choice here, she has no ranged weapon [which can be justified on role playing grounds however; Cavaliers are prohibited from *missile* wpns in the computer game, but the intent in AD&D, as I see it, is to restrict them from *ranged* weapons, even those like hammers, axes and daggers that can be both melee and ranged weapons. Doing it the PnP way is, however, beyond the capabilities of the game engine...] She also has no skill with *any* blunt weapon and no piercing weapon. Given the kind of creatures a Paladin is going to be called upon to face, the lack of a blunt weapon, especially, is hard to justify - especially with her starting out at lvl 8+. Surely by now she has faced a skeleton or two, or other beasties partially or fully immune to slashing weapons? Being "flashy" is one thing, but being foolish is another...
You are, of course, correct than one can always SK her to what one wants. Personally, I spend 3 pts on 2-wpn style, 2 pts on L Swd, and a point each on Mace and Axes [at 9th lvl]. If I am using the "Thrown Hammer" mod [as I often do] then I might change Axe to Hammer proficiency. That she won't be uber-skilled with Carsomyr is just too bad - she has no way of knowing it is going to be found and not all Holy Swords are 2-Handers anyway. She will make do....
Now, other than the quibbles about proficiencies, let me finish by saying that I think that this is an excellent NPC, in many, many ways. The stories are interesting, the family stuff especially. Her personality is well-drawn and shows through in both conversations and parentheticals. She is neither super-powered, nor crippled in some way. How she interacts with situations and other NPCs is reasonable, understandable and appropriate. Both the friendships and romance struck me as un-forced, natural and believable - well written all around!
Two measures of how much I like her; #1, my favorite mod NPC, from a role playing and writing viewpoint is Xan - can't praise that mod highly enough, on so many levels. Well Isra is now my second favorite NPC mod [and I have played them all, from 1-day munchkins to demi-God Kensia's...] That I include her along with Xan is, for me, pretty high praise indeed.
#2, That I take along, given my style of play, is remarkable. One of my overriding game-play choices is that only the PC can kill anything, which means only he or she can inflict *any* damage on enemies. This makes spell-casting comrades useful [for buffs and disabling spells, Truesight, anti-mage defences stuff, etc] but means melee or ranged weapons classes are basically useless to me. What value is a Minsc, if he can't strike at anything with a weapon [for fear that I might end the game with less than 100% of the kills]?
So, given my unusual style of play, that I find Isra interesting and entertaining enough to take along, when all she can do is cast Remove Fear and use Lay on Hands occasionally, is saying a lot!
Very good job, thanks for making the mod and I look forward to seeing more of your work.