300 replies to this topic

[Lollorian]

Done

 

Also, removed the bg1npc patches because v22.1 got out

[subtledoctor]

Hello gents. Is this FixPack only for use with BWS? Or can a traditionalist and/or Mac user who installs mods one-by-one also get the benefit of it?

[agb1]

It uses the "patch" tool, which is installed by default on OS X, so it is possible.  But right now the fixpack only has a Windows .bat script, so that needs to be rewritten as a shell script for OS X.

 

See for example:  http://tldp.org/LDP/...l/dosbatch.html

Edited by agb1, 02 December 2015 - 03:34 PM.

[subtledoctor]

Hmm. Any particular reason it's not written in Weidu??

[agb1]

Because using the patch tool will only modify the original file if the part of the file being modified hasn't changed from what it was when the patch was created, so using that method instead of weidu means that when the mod itself gets updated, the fixpack doesn't break it.

[Lollorian]

What he/she said

[subtledoctor]

Got it. Cool.

[Nightfarer]

Les Exiles de Lunargent AKA Devin (The Exiles of Silverymoon) Fix:

 

#VNewArea.tp2:

 

FOR ( i = SHORT_AT 0xc8 ; i ; --i ) BEGIN
    LAUNCH_PATCH_FUNCTION ~fj_are_structure~
        INT_VAR
        fj_delete_mode = i - 1
        STR_VAR
        fj_structure_type = note
    END
END

 

To be added right below:

 

// Implantation du site de la confrérie

COPY ~Devin/New Area/#VAR20.are~ ~override~

 

and right before the ADD_MAP_NOTE patching. I also already wrote you a PM with a revised file for Textpack English (this fix is included).

 

The fix deletes the map notes present in #VAR20.are which mess up the map notes added.

[Nightfarer]

Hi Lollorian.

 

I just wrote you a PM for Area Patcher ALPHA 7. I noticed some stupid mistakes in the ALPHA 6 code.

[Lollorian]

Shit fuck! Sorry

[Nightfarer]

Don't worry At least ALPHA 7 should work as expected and those are "fixed".

 

It is a fault of mine, in any case. The fact is that at times it is hard to notice, manually writing code on phone. And as I'm still without pc I'm unable to test

[Lollorian]

1. running BiG World Fixpack.bat does not copy res_fixer and lolfixer to game directory

2. running BiG World Fixpack.bat pauses twice (start and end message) because BW Installpack and BW Smoothpack are not present

This should be handled by the BWS if it doesn't want to use the BWPInstallpack

 

3. vampiretales:

patching file `vampiretales\american\CMGMIRIJ.tra'
Hunk #1 FAILED at 47.
1 out of 1 hunk FAILED -- saving rejects to vampiretales\american\CMGMIRIJ.tra.rej

patch attempts to add '<' to CHARNAME tag on line @49, but this is no longer necessary (the author fixed this)

4. alora:

patching file `SETUP-alora.tp2'
Hunk #1 FAILED at 8.
1 out of 1 hunk FAILED -- saving rejects to SETUP-alora.tp2.rej

patch attempts to change version '1.3' to '1.5 BWP fix' but Alora is now version 1.5
the other patch for bcmalor.d is still working

Bigger issue - opened thread

[agb1]

I'm not really sure if BWS should be using the BW Installpack for EE.  I see that BWS manually copies and runs some files from the Installpack for BGT games:

 

Spoiler

CMD;IF EXIST ".\BiG World Installpack\BiG World Smoothpack" move ".\BiG World Installpack\BiG World Smoothpack\_modify\*.*" "."

CMD;IF NOT EXIST BWP_Smoothpack.installed Call ".\BiG World Installpack\BiG World Smoothpack.bat"

CMD;IF EXIST ".\BiG World Installpack\BWP_Smoothpack.installed" copy ".\BiG World Installpack\BWP_Smoothpack.installed" "."

 

...

 

CMD;Call ".\BiG World Installpack\define_BIG.bat" (near end of install)

CMD;IF EXIST setup-w_psionics_unleashed.exe Call ".\BiG World Installpack\edit_string_w_psionics.bat

ANN;trim leading and trailing spaces, remove duplicates

CMD;Call ".\BiG World Installpack\trim_IDS.bat" 

ANN;correct some possibly corrupted IDS files

CMD;Call ".\BiG World Installpack\trim_KitIDS.bat"

Edited by agb1, 26 December 2015 - 06:59 PM.

[agb1]

After further analysis, I have added BiG World Installpack and Smoothpack to BWS' BG1EE and BG2EE installs.

Edited by agb1, 26 December 2015 - 07:15 PM.

[agb1]

New question.  BWS copies the contents of BiG World Fixpack\_IDS_ref\ to override for BGT installs.  Should it do the same for EE?

 

I see a conflict with BPSeries AI:  it looks for STATE_DISEASED_FIX (numbered 134) in Stats.IDS ... but the copy of Stats.IDS in _IDS_ref contains "134 EXTRAPROFICIENCY20"

 

Further down the rabbit hole, we find in bpseries\lib\bp.tph the following:

 

Spoiler

//////////////////////////////////STATE_DISEASED FIX///////////////////////////////////

//

// STATE_DISEASED was broken in BG2:ToB, and to date remains broken in BGEE

//To detect the state, we assign a Stats value to it (#134, STATE_DISEASED_FIX)

// This also allows us to assign "severity values"

// Num Stars  Disease Type

//    1         [EMPTY --some mods may still use this for old DS #134 LEVELDRAIN)

//    2         Slowing

//    3         Ability Draining

//    4         Hit-Point Draining

//    5         Mummy Rot [Reserved for aTweaks special-case: Mummy Rot disease -- no healing possible while so diseased]

//

// The proficiency value is assigned to a custom secodary spell school (fl#Disease, also in sync w/ aTweaks package)

// To make this work, all curative spells (and items) are assigned a Remove Secondary School effect

//

//

 

DEFINE_ACTION_FUNCTION fix_state_diseased BEGIN

...

 

While we are on the subject, is any harm caused by duplicate entries in IDS files with different names?

Edited by agb1, 26 December 2015 - 08:08 PM.

[The Imp]

While we are on the subject, is any harm caused by duplicate entries in IDS files with different names?

It depends totally on the context of the .ids, in this case the AI can automatically be programmed to fix the draining attack abilities, aka the above, as they all have the same cure, cleric lesser restoration spell, will fix it.

[Lollorian]

Things like:

 

1 RANDOM_NAME

1 RANDOM_NAME2

 

are OK. But shit like:

 

1 RANDOM_NAME

2 RANDOM_NAME

 

will screw the game

Edited by Lollorian, 27 December 2015 - 12:18 AM.

[agb1]

We have some IDS problems then.

[Lollorian]

Things like:

 

1 RANDOM_NAME

1 RANDOM_NAME2

 

are OK. But shit like:

 

1 RANDOM_NAME

2 RANDOM_NAME

 

will screw the game

Wait sorry I mixed things up...

[The Imp]

Things like:

 

1 RANDOM_NAME

1 RANDOM_NAME2

 

are OK. But shit like:

 

1 RANDOM_NAME

2 RANDOM_NAME

 

will screw the game

Wait sorry I mixed things up...

Well, that again depends on the .ids 's link to the actual in game file. But mostly yeah.