Jump to content


Photo

Tashia Mod Conflict with Imoen Romance Mod


  • Please log in to reply
24 replies to this topic

#1 vanatos

vanatos
  • Member
  • 5 posts

Posted 01 January 2016 - 02:24 PM

Hi i am the maintainer (coder) of the Imoen Romance Mod.

 

Tashia has a conflict with the Imoen Romance mod.

 

I tracked down the issue, the modification of finsol01 state 28 is the problem.

 

In the tashi25j. there is this line of code.

 

Tashia Code

 

REPLACE FINSOL01
  IF ~~ THEN BEGIN 28
    SAY @39
    IF ~Global("TashiaRomanceActive","GLOBAL",2)~ THEN EXTERN tashi25j rom1
    IF ~!Global("TashiaRomanceActive","GLOBAL",2)~ THEN EXTERN FINSOL01 TashiaAdd1
  END
END
 
this replaces the Vanilla dialogue state in the retail code.
 
Retail Code

IF ~~ THEN BEGIN 28 // from: 27.0
  SAY #67885 /* ~The time has come to make your choice, Bhaalspawn. What is your wish?~ [SOLAR102] */
  IF ~GlobalLT("PPEvilChoices","GLOBAL",2)
~ THEN REPLY #68063 /* ~I will retain the essence of Bhaal that is my right and become a power of the planes.~ */ DO ~SetGlobal("PlayerChoseEssence","GLOBAL",1)
~ GOTO 31
  IF ~GlobalGT("PPEvilChoices","GLOBAL",1)
GlobalLT("PPEvilChoices","GLOBAL",4)
~ THEN REPLY #68064 /* ~I will retain the essence of Bhaal that is my right and become a power of the planes.~ */ DO ~SetGlobal("PlayerChoseEssence","GLOBAL",1)
~ GOTO 30
  IF ~GlobalGT("PPEvilChoices","GLOBAL",3)
GlobalLT("PPEvilChoices","GLOBAL",6)
~ THEN REPLY #68065 /* ~I will retain the essence of Bhaal that is my right and become a power of the planes.~ */ DO ~SetGlobal("PlayerChoseEssence","GLOBAL",1)
~ GOTO 29
  IF ~~ THEN REPLY #68066 /* ~I do not want the essence of Bhaal. Do what you will with it... I want to remain mortal.~ */ GOTO 32
END
 
 
As you can see the transitions have been removed so there is only 2 instead of 4.
 
So any mod that tries to modify the original transitions will cause an error.
 

Edited by vanatos, 01 January 2016 - 02:38 PM.


#2 Roxanne

Roxanne

    Modder

  • Member
  • 3564 posts

Posted 01 January 2016 - 03:00 PM

Hi i am the maintainer (coder) of the Imoen Romance Mod.

 

Tashia has a conflict with the Imoen Romance mod.

 

I tracked down the issue, the modification of finsol01 state 28 is the problem.

 

In the tashi25j. there is this line of code.

 

Tashia Code

 

REPLACE FINSOL01
  IF ~~ THEN BEGIN 28
    SAY @39
    IF ~Global("TashiaRomanceActive","GLOBAL",2)~ THEN EXTERN tashi25j rom1
    IF ~!Global("TashiaRomanceActive","GLOBAL",2)~ THEN EXTERN FINSOL01 TashiaAdd1
  END
END
 
this replaces the Vanilla dialogue state in the retail code.
 
Retail Code

IF ~~ THEN BEGIN 28 // from: 27.0
  SAY #67885 /* ~The time has come to make your choice, Bhaalspawn. What is your wish?~ [SOLAR102] */
  IF ~GlobalLT("PPEvilChoices","GLOBAL",2)
~ THEN REPLY #68063 /* ~I will retain the essence of Bhaal that is my right and become a power of the planes.~ */ DO ~SetGlobal("PlayerChoseEssence","GLOBAL",1)
~ GOTO 31
  IF ~GlobalGT("PPEvilChoices","GLOBAL",1)
GlobalLT("PPEvilChoices","GLOBAL",4)
~ THEN REPLY #68064 /* ~I will retain the essence of Bhaal that is my right and become a power of the planes.~ */ DO ~SetGlobal("PlayerChoseEssence","GLOBAL",1)
~ GOTO 30
  IF ~GlobalGT("PPEvilChoices","GLOBAL",3)
GlobalLT("PPEvilChoices","GLOBAL",6)
~ THEN REPLY #68065 /* ~I will retain the essence of Bhaal that is my right and become a power of the planes.~ */ DO ~SetGlobal("PlayerChoseEssence","GLOBAL",1)
~ GOTO 29
  IF ~~ THEN REPLY #68066 /* ~I do not want the essence of Bhaal. Do what you will with it... I want to remain mortal.~ */ GOTO 32
END
 
 
As you can see the transitions have been removed so there is only 2 instead of 4.
 
So any mod that tries to modify the original transitions will cause an error.
 

This is a bit more than just a conflict with Imoen, especially since it does not even check for Tashia to be present so the first transition kills the game if Tashia is not in party - what happens otherwise cannot be determined on this information (needs to check what those two EXTERN contain)


The Sandrah Saga

another piece of *buggy, cheesy, unbalanced junk*

 


#3 agb1

agb1
  • Member
  • 1623 posts

Posted 04 January 2016 - 02:36 PM

setup-tashia.tp2 contains:

 

COMPILE ~tashia/Dialogues/tashi25j.d~
  USING ~tashia/%s/tashi25j.tra~
 

Attached is tashi25j.d and tashi25j.tra.

 

I also found a tashi25j.d.rej in my tashia\dialogues\ folder, which I think is a failed Fixpack patch:

 

Spoiler

Attached Files


BiG World Fixpack (community collection of mod fixes and compatibility patches, with user-friendly cross-platform script)

 

BiG World Setup (tool to automate best-practice installation of Infinity Engine mods on Windows, with conflict analysis)

Latest version:    https://bitbucket.or.../get/master.zip


#4 Roxanne

Roxanne

    Modder

  • Member
  • 3564 posts

Posted 04 January 2016 - 02:52 PM

setup-tashia.tp2 contains:

 

COMPILE ~tashia/Dialogues/tashi25j.d~
  USING ~tashia/%s/tashi25j.tra~
 

Attached is tashi25j.d and tashi25j.tra.

 

I also found a tashi25j.d.rej in my tashia\dialogues\ folder, which I think is a failed Fixpack patch:

 

Spoiler
So the first response now contains the check for Tashia
The second does not need it as it just adds a line to Finsol
however both lead (COPY_TRANS) back into Finsol01 state28 probably with the intention to continue from there, but the 4 remaining transitions are removed by the same code. So it fails.
The REPLACE should be rather EXTEND_BOTTOM and reworked.

Edited by Roxanne, 04 January 2016 - 03:10 PM.

The Sandrah Saga

another piece of *buggy, cheesy, unbalanced junk*

 


#5 agb1

agb1
  • Member
  • 1623 posts

Posted 04 January 2016 - 03:02 PM

Bri and Lord Ernie haven't been active on these forums in over a year.  According to the Tashia readme, it is "an 'open-mod' and subject to further change [by] all."  Is anyone knowledgeable willing to rework this code into a more compatible form?


BiG World Fixpack (community collection of mod fixes and compatibility patches, with user-friendly cross-platform script)

 

BiG World Setup (tool to automate best-practice installation of Infinity Engine mods on Windows, with conflict analysis)

Latest version:    https://bitbucket.or.../get/master.zip


#6 Roxanne

Roxanne

    Modder

  • Member
  • 3564 posts

Posted 05 January 2016 - 12:00 AM


Bri and Lord Ernie haven't been active on these forums in over a year.  According to the Tashia readme, it is "an 'open-mod' and subject to further change [by] all."  Is anyone knowledgeable willing to rework this code into a more compatible form?

I have made an attempt. It only revises the .d file using the unchanged dialogues from the tra. It covers the case of Tashia's romance beeing active or not, It checks for Tashia's presence at Final. I think it fully catches the author's initial intention.

I tested it only by install and it works, provided that Ascension is installed (if not a condition for Tashia ToB in BWS already, it should be added.)

Somebody needs to test it in the game however, I cannot because I avoided installing Tashia (causing same problem for my Sandrah as for Imoen),

 

Attached File  tashi25j_Revised.d   4K   195 downloads

 

This file needs to be renamed and replaces the original in the mod,


Edited by Roxanne, 05 January 2016 - 12:01 AM.

The Sandrah Saga

another piece of *buggy, cheesy, unbalanced junk*

 


#7 agb1

agb1
  • Member
  • 1623 posts

Posted 05 January 2016 - 05:05 AM

Is this revised dialogue compatible with Sandrah?

BiG World Fixpack (community collection of mod fixes and compatibility patches, with user-friendly cross-platform script)

 

BiG World Setup (tool to automate best-practice installation of Infinity Engine mods on Windows, with conflict analysis)

Latest version:    https://bitbucket.or.../get/master.zip


#8 Roxanne

Roxanne

    Modder

  • Member
  • 3564 posts

Posted 05 January 2016 - 05:12 AM

Is this revised dialogue compatible with Sandrah?

It should be generic, i.e. not have any issue with any other mod.


The Sandrah Saga

another piece of *buggy, cheesy, unbalanced junk*

 


#9 agb1

agb1
  • Member
  • 1623 posts

Posted 05 January 2016 - 05:24 AM

Thanks Roxanne. Your contribution is greatly appreciated!

BiG World Fixpack (community collection of mod fixes and compatibility patches, with user-friendly cross-platform script)

 

BiG World Setup (tool to automate best-practice installation of Infinity Engine mods on Windows, with conflict analysis)

Latest version:    https://bitbucket.or.../get/master.zip


#10 Lollorian

Lollorian

    smiley addict

  • Member
  • 4150 posts

Posted 06 January 2016 - 07:18 AM

I have a patch ready but before I put it up... why require Ascension?


"I am the smiley addict, yellow and round, this is my grin :D when I'm usually around :P.
When there's trouble brewing, see me post, cuz it's usually a wall o' yellow and your eyes are toast!!!"

BWP GUIDE - BWP FIXES - impFAQ - NPC LIST - KIT LIST - AREA LIST

GitHub Links : BWP Fixpack | Lolfixer | BWP Trimpack | RezMod


#11 Roxanne

Roxanne

    Modder

  • Member
  • 3564 posts

Posted 06 January 2016 - 07:45 AM

I have a patch ready but before I put it up... why require Ascension?

Sorry, my mistake. The revised dialogue should work with vanilla ToB. But you should not publish it without someone having tested it before - like I pointed out, I could only see that it compiles without error and is correct via NI, I have no option to test it in the game.


The Sandrah Saga

another piece of *buggy, cheesy, unbalanced junk*

 


#12 Lollorian

Lollorian

    smiley addict

  • Member
  • 4150 posts

Posted 06 January 2016 - 07:49 AM

Agreed :cheers:


"I am the smiley addict, yellow and round, this is my grin :D when I'm usually around :P.
When there's trouble brewing, see me post, cuz it's usually a wall o' yellow and your eyes are toast!!!"

BWP GUIDE - BWP FIXES - impFAQ - NPC LIST - KIT LIST - AREA LIST

GitHub Links : BWP Fixpack | Lolfixer | BWP Trimpack | RezMod


#13 -Titania-

-Titania-
  • Guest

Posted 19 January 2016 - 04:42 PM

Just stumbled upon this and now I'm cursing myself for having installed Tashia at all (didn't even take her along in the end). Approaching ToB at the moment, any override hotfix for an ongoing game available to prevent problems from occuring when Tashia won't be present later? Thanks!



#14 agb1

agb1
  • Member
  • 1623 posts

Posted 19 January 2016 - 05:30 PM

Yes, it will be possible to patch your game.  We'll have to restore a version of the finsol01.dlg that doesn't have the changes from Tashia.  Run a WeiDU --change-log on finsol01.dlg so we can see which other mods tweaked it.  Then upload a copy of finsol01.dlg from your generalized_biffing\prod\0\??? folder (??? varies from install to install so search for finsol01.dlg in all of the subfolders there).


BiG World Fixpack (community collection of mod fixes and compatibility patches, with user-friendly cross-platform script)

 

BiG World Setup (tool to automate best-practice installation of Infinity Engine mods on Windows, with conflict analysis)

Latest version:    https://bitbucket.or.../get/master.zip


#15 -Titania-

-Titania-
  • Guest

Posted 20 January 2016 - 10:43 AM

wow, thanks for the quick help!

 

so it's giving me a parsing error...

 

https://www.dropbox....ge-log.txt?dl=0



#16 -Titania-

-Titania-
  • Guest

Posted 20 January 2016 - 10:49 AM

... and here's finsol01.dlg from generalized biffing backups.

 

https://www.dropbox....NSOL01.DLG?dl=0

 

...and complete weidu.log, just in case ;)

 

https://www.dropbox..../WeiDU.log?dl=0



#17 -Titania-

-Titania-
  • Guest

Posted 20 January 2016 - 10:59 AM

well, sorry for posting faster than thinking. ignore the first post, it was an issue of not having overwritten a newer version of weidu.

 

here's changelog results:

 

https://www.dropbox....ge-log.txt?dl=0

 

https://www.dropbox.....00022.DLG?dl=0



#18 Roxanne

Roxanne

    Modder

  • Member
  • 3564 posts

Posted 21 January 2016 - 04:51 AM

Open Finsol01.dlg in your NI editor

Switch to editing mode

Go to the line that has *Response Trigger 89* and select it

In the preview box at the bottom you will see *!Global("TashiaRomanceActive","GLOBAL",2)*

Enter in the empty line below that

IfValidForPartyDialogue("Tashia")

Click *Update* in the box below that window

Click *Save* in the bottom menu


The Sandrah Saga

another piece of *buggy, cheesy, unbalanced junk*

 


#19 Roxanne

Roxanne

    Modder

  • Member
  • 3564 posts

Posted 21 January 2016 - 04:58 AM

Just a short remark to those issues with Finsol01.dlg

It is the last dialogue in the normal game. The game is at its end. You may do your final decision but that really has no consequence because the game is over. All you loose from issues here are the final NPC bios (telling you what became of your friends in further life) and the end credits. Nice to have, cosmetics...maybe a feeling that the end is incomplete.

 

You do not have a mod installed that takes any consequences out of the decision you give to the Solar in the end, so it does not matter that much.


The Sandrah Saga

another piece of *buggy, cheesy, unbalanced junk*

 


#20 -Titania-

-Titania-
  • Guest

Posted 21 January 2016 - 11:02 PM

Thanks for the help, Roxanne!

I'm aware of that, and that's precisely why I really want to make this play as smoothly as possible. See, I only have time to get to play through BG every odd 2 years, and those emotional moments are half the fun for me. NPC Epilogues is like, the best moment of ToB, so I rather make sure in advance not to have messed sth up.

 

So just to be sure - 

response trigger 89 actually contains

 

  IfValidForPartyDialogue("Tashia")
Global("TashiaRomanceActive","GLOBAL",2)
 
already. I assume you mean response trigger 90?
 
  !Global("TashiaRomanceActive","GLOBAL",2)