77 replies to this topic

[Jakar]

@The Imp
@Leonardo Watson
Thanks for your reply.
Guess i will try to install it before NeJ and see what happens.

 
I didn't risk to install it in megamod with other big modes, but i tried to install Vlad's compilation just after BGT install (simple pausing in BWS helps), and it goes fine. I didn't check further Irenicus dungeon, but no errors so far, Kachiko is in her place, everyone reacts as suspected.

https://imgur.com/a/lGJiQ

[Miksip]

Vlad, can i ask you to add more options to your compilation. Now it is either all or nothing.

[Vlad]

Leonardo, please wait a bit. I am on my last run through the game. There are some minor issues addressed and some new options I have added. So, it's better to wait for the next final release. 

 

Miksip, my compilation should be installed as it is for the sake of compatibility. You may choose what you want during the game.

[Miksip]

@Vlad

One of the components for Baldurdash and Vlad Compilation sets bag capacity to 32767.

If i install only your compilation then there should be no problem, maybe.

When i install your compilation in a mega-mod game then it causes lags because of baldur.bcs and lots of scrips that look for items in inventory.

This is your mod and you are not wrong, rather the people who bloated bcs file are at fault.

But if you remove said component or at least put an option for it then it should be more user friendly. Thank you in advance.

Here it is:

 

  C:\BGT\Baldur's Gate 2\Setup-BDToBv175.tp2 (2 hits)
    Line 2053:     WRITE_SHORT 0x22 32767
    Line 7831:     WRITE_SHORT 0x22CA 0x0116
  C:\BGT\Baldur's Gate 2\Setup-VCv10.tp2 (2 hits)
    Line 1758:     WRITE_SHORT 0x22 32767
    Line 6718:     WRITE_SHORT 0x22CA 0x0116

 

//-------------------------------------------------------------------------
//Botomless Bag of Holding
//-------------------------------------------------------------------------

COPY_EXISTING_REGEXP GLOB ~^.+\.sto$~ ~override~
  READ_LONG 0x08 "itemtype" ELSE 0
  PATCH_IF ("%itemtype%" = 5) BEGIN
    WRITE_SHORT 0x22 32767
  END
BUT_ONLY_IF_IT_CHANGES

[Mirandel]

@Vlad

One of the components for Baldurdash and Vlad Compilation sets bag capacity to 32767.

If i install only your compilation then there should be no problem, maybe.

When i install your compilation in a mega-mod game then it causes lags because of baldur.bcs and lots of scrips that look for items in inventory.

This is your mod and you are not wrong, rather the people who bloated bcs file are at fault.

But if you remove said component or at least put an option for it then it should be more user friendly. Thank you in advance.

Here it is:

 

  C:\BGT\Baldur's Gate 2\Setup-BDToBv175.tp2 (2 hits)
    Line 2053:     WRITE_SHORT 0x22 32767
    Line 7831:     WRITE_SHORT 0x22CA 0x0116
  C:\BGT\Baldur's Gate 2\Setup-VCv10.tp2 (2 hits)
    Line 1758:     WRITE_SHORT 0x22 32767
    Line 6718:     WRITE_SHORT 0x22CA 0x0116

 

//-------------------------------------------------------------------------
//Botomless Bag of Holding
//-------------------------------------------------------------------------

COPY_EXISTING_REGEXP GLOB ~^.+\.sto$~ ~override~
  READ_LONG 0x08 "itemtype" ELSE 0
  PATCH_IF ("%itemtype%" = 5) BEGIN
    WRITE_SHORT 0x22 32767
  END
BUT_ONLY_IF_IT_CHANGES

 

Aha! I did found out the Bag of Holing is responsible for lag, but is there any way to fix it after installation? 

[The Imp]

Don't put the items that cause lag to occur into them, and keep going. You can leave them into anywhere else and keep playing, as the check is IF the player char has them, a thing happens and THEN nothing, until it's switched around or other things happen.
The bags size is NOT the issue. Nor is the fact that the items are actually checked, it's that the thing just fires a little sparatically, aka the character begomes permanently marked as having possessed the item, as they don't actually make the other globals to be back to zero. Or there's multiple of the same items...

[Miksip]

@Mirandel

You need to use NearInfinity and redact bag size(capacity) manually. Edit your save file - it should have those bags as stores(*.STO), then look in .STO directory for bags which have 32767 as their capacity and change that too.

Since they cause slowdown even when they are empty - I'm guessing that script which looks for items in inventory(hasitem, partyhasitem) makes n iterations though those bags where n is their capacity.

This makes sense since their original size is 50 or 100 for bag of holding. And original size of baldur.bcs is 76kb, but after megamod installation it became 1579kb for me. Game wasn't supposed to handle all this.

So there you have it. I would recommend to edit your baldur.bcs too using NearInfinity if you experience slowdown due to bags, but make backup first(export baldur.bcs). When you edit and save - it should be in override folder.

 

P.S. Don't listen to The Imp - it is voice of the Devil.

[Mirandel]

Thank you, Miksip and The Imp , now I have a good reason to study NearInfinity. Will do.

[The Imp]

I'm guessing that script which looks for items in inventory(hasitem, partyhasitem) makes n iterations though those bags where n is their capacity.

P.S. Don't listen to The Imp - it is voice of the Devil.

Or just use the ToBEx to remove this behaviour !!!
The devil knows more than you, you should listen ... and the BWS does this by default. I am talking about this: "Optimise Bag Search Code=1"

Now, you have to install the ToBEx'es core component for it... of course, but a Megamodder should do that automatically. Unless they are lunatics.

And should you know, the feature is included in EE games, so...

Edited by The Imp, 28 October 2017 - 07:25 AM.

[Ikki]

Aha! I did found out the Bag of Holing is responsible for lag, but is there any way to fix it after installation?

You need to use NearInfinity and redact bag size(capacity) manually

just install the mod atweaks

it has a component that do exactly that (Slightly expanded storage capacity for containers -> Use the recommended storage capacity value (999))

Edited by Ikki, 28 October 2017 - 09:02 AM.

[Mirandel]

Aha! I did found out the Bag of Holing is responsible for lag, but is there any way to fix it after installation?

You need to use NearInfinity and redact bag size(capacity) manually

just install the mod atweaks

it has a component that do exactly that (Slightly expanded storage capacity for containers -> Use the recommended storage capacity value (999))

 

Was not sure addition of yet another mod would not ruin something else during installation (on BGT to make it even more complicated). So, tried a compromise - Nearinfinity but value 999. Looks like it worked!

[The Imp]

Was not sure addition of yet another mod would not ruin something else during installation (on BGT to make it even more complicated). So, tried a compromise - Nearinfinity but value 999. Looks like it worked!

Well, it does nothing in the save with the .sto already being in the possession of the player char, as the .sto is tied into the bag. You can get the new size by just cheating in the same item as the original and then just swapping items from and to... but that kind defeats all the purpose of our lives.
And no, more and more mods in a running game doesn't really do anything special ... the text might sometimes get wonky, especially if you messup and uninstall a mod, but that's about it.

[Roxanne]

 

Was not sure addition of yet another mod would not ruin something else during installation (on BGT to make it even more complicated). So, tried a compromise - Nearinfinity but value 999. Looks like it worked!

Just a hint:

If you change something for an ongoing game e.g. with Near Infinity (or an added mod), the effect on your current game depends on where the game saves the respective resource.

 

Just some examples:

- scripts, spells or items are just referenced in saves by their name or IDS. If you change something and reload the game, your changes are immediately working.

- areas (are-files) or stores (sto) or creatures are saved in the state you left them. This means that your changes are only working for the initial state, i.e. if you have not yet entered the area or visited the store or met the creature.

 

You can still change those in NI as well, but you need to apply the change to the version that is in your savegame not the one you find under the respective category (those are the initial versions).

[The Imp]

Didn't I already say that Roxanne ?

[Creepin]

Aha! I did found out the Bag of Holing is responsible for lag, but is there any way to fix it after installation?

The only reliable way to actually fix the slowdown I have found in years of playing megamod is manually removing all useless shit from 5 ever-running scripts: dplayer, dplayer2, dplayer3, baldur and baldur25 after installation of megamod. Really, what were authors thinking with while cramming always-running scripts with bloats over bloats of useless nonsense? Perhaps thinking their mod will be the only one used, but that assumption is absurd in this time and age. Anyway, the point is to remove as much "X has item Y" checks as possible without breaking something important. 24 script blocks to make sure items I will never use will return to wielder if thrown away? Erase. 36 script blocks to make sure personal item of an NPC won't be equipped to other PC? Purge. 6 script blocks to make sure that talking sword will have it's poorly voiced and poorly recorded screams? Remove. And so on and so forth. Tedious, true, but after doing that megamod runs smoothly again.

 

Easiest way to do it if you're not accustomed to compiling/decompiling routine is by Near Infinity: cut what you need, press compile, press save, and you're done.
 

The devil knows more than you, you should listen ... and the BWS does this by default. I am talking about this: "Optimise Bag Search Code=1"

I've heard many times that TobEX optimizes item checks, sadly I never felt it in my playthroughs: TobEX or not game grew disgustingly slow by the end of BG1, which fixed immediately upon aforementioned purge was done.

Edited by Creepin, 29 October 2017 - 04:15 AM.

[The Imp]

Perhaps thinking their mod will be the only one used, but that assumption is absurd in this time and age. Anyway,... but after doing that megamod runs smoothly again.

You are judging someone by todays standards from 10 years ago, really man, really !
See they weren't thinking about megamoding...

Could you quote the lines you removed from the files... it would actually be easy to just make a .patch file based on that, or even just make a mod components from those... just like the Lollorian made his mod.
Of course this is all way offtopic, so if you wish, you could just make an offtopic discussion from this ...

[Creepin]

To cut the offtopic short (sorry Vlad!): next time I'll go through this routine I'll made a list and post the results. The main targets are already in my post though: cursed returning items from SoS, NPC items that punish you if you equip them to wrong NPC and talking items.

Edited by Creepin, 29 October 2017 - 03:16 AM.

[Mirandel]

Uh! Now I am completely confused. Ok, step by step:

 

First, Creepin, I do not think it's offtopic - NEJ creates a problem that has to be solved. You suggested a solution. The problem is, I do not really know how to use your solution, what to look at. There are hundreds entries "hasItem"  in baldur.bcs - how to separate useless from necessary?

 

Now, the situation was like this: I installed BGT manually - BG, BG2, then run BGT. After that - VC and NEJ. Then I realised, VC and NEJ is about BG2 only, and if I want to survive BG1 I need at leas 2 mods - BG1NPC and BG1re. Installed both on top of what I had. And it looked (still does) as it worked. But after I cheated in (with Shadowkeeper) Bag of Holdings I got lag. Not right away, past Beregost, but I got it.

 

So far I deleted (with Shadowkeeper) Bag of Holding, saved game (lag was still there), then opened chitin.key from BG2 folder with NI and replaced every 32767 with 999 for every bag.STO in "STO" folder I found, plus in the new (bag-less) save file. Did not touch "baldur.bcs" because I do not know what to change there. Lag is not entirely gone but not as severe as it was. 

 

Where else should I look?

[The Imp]

Miradel, this will technically break the game, but it's a debug tool so, uninstalling it will fix the state that it breaks... I am talking about the LStest tool in the Megamod FAQ.
It's not likely to be the NEJ that actually broke your game, but something completely different, and the LStest tool will ease it's finding... if it's script related.