14 replies to this topic

[temnix]

Scripts for some reason recognize when people are in spell states but don't want to recognize the opposite. In BALDUR.BCS, if you put this check:

 

IF
    CheckSpellState(Player1,PROTECTION_FROM_EVIL)
THEN
    RESPONSE #1
        Kill(Player1)
END

 

and give the player an item that puts him in this state, he will die. But this check does nothing:

 

IF
    !CheckSpellState(Player1,PROTECTION_FROM_EVIL)
THEN
    RESPONSE #1
        Kill(Player1)
END

[Miloch]

Offhand, I'm just looking at what *should be* the logic. What you're saying is "if (don't bother checking) whether the player should be in this state." Well of course this should always have no effect. Just guessing there as a logician, but I'll admit IE scripting isn't always logical.

[Avenger_teambg]

Offhand, I'm just looking at what *should be* the logic. What you're saying is "if (don't bother checking) whether the player should be in this state." Well of course this should always have no effect. Just guessing there as a logician, but I'll admit IE scripting isn't always logical.

 

Bad logic.

!false should be true.

!true should be false.

 

And i'm fairly sure, it works that way too. I don't know what exactly went wrong in the example, though.

[GeN1e]

Negating a trigger don't seem to always be binary. E.g. neither TriggerOverride("ff_camp",IsOverMe("corwin")) nor !TriggerOverride("ff_camp",IsOverMe("corwin")) would return true if there was no ff_camp object.

 

I don't remember seeing such with spellstates, though/

[Avenger_teambg]

Negating a trigger don't seem to always be binary. E.g. neither TriggerOverride("ff_camp",IsOverMe("corwin")) nor !TriggerOverride("ff_camp",IsOverMe("corwin")) would return true if there was no ff_camp object.

 

I don't remember seeing such with spellstates, though/

 

Yeah, you should use  TriggerOverride("ff_camp",!IsOverMe("corwin")) anyway i think. (And still fail the negation, if the object doesn't exist).

 

I don't know if triggeroverride would even notice the negation.

 

Anyway, this is triggeroverride's problem, not checkspellstate's.

Edited by Avenger_teambg, 26 February 2018 - 09:42 AM.

[subtledoctor]

I'm using !CheckSpellState in some dialogues, to determine your proficiency level in place of CheckStat, and it seems to be working fine for me.

https://github.com/U...files/d5profx.d

[temnix]

I can't say anything about dialogues. The example is from scripts, and he who wants to look into it should replicate what is written.

 

And what is this with an explosion of answers on this board? Like someone has blasted it in his pants.

[subtledoctor]

Well, from what I can tell dialogues use precisely the same triggers and actions as scripts. Before people (including devs) start freaking out that the trigger is broken, I just wanted to point out that the trigger seems fine. At least in one context. And that I have an installable mod people can use to test further.

I suspect the problem here has to do with your test environment, not the trigger. But OTOH maybe there is some difference between how triggers are handled in .DLG versus .BCS. I'm no expert.

Edited by subtledoctor, 26 February 2018 - 02:08 PM.

[temnix]

Just insert the freaking dildo, I mean the code, in your BALDUR and see if you have different results. Instead of cooing like that Gaelan guy that everything is coo.

[Miloch]

Bad logic.

!false should be true.

!true should be false.

Yeah, it should be. You seem to be assuming the engine works logically though, and you should know better by now (basically what GeN1e said - negation doesn't always seem to work binarily).

[subtledoctor]

You keep your dildo, I'll stick to data points. Of which I have provided one. You'recwelcome.

[GeN1e]

Works perfectly.

 

LAF ds_resolve_stat INT_VAR ids=1 STR_VAR id=PROTECTION_FROM_EVIL RET bless_state=stat_ind END

COPY_EXISTING sppr107.spl override
  LPF ADD_SPELL_EFFECT INT_VAR opcode=328 target=2 duration=36 parameter2=bless_state special=1 END

CLEAR_IDS_MAP

<<<<<<<<extend.baf
IF
    CheckSpellState(Player1,PROTECTION_FROM_EVIL)
THEN
    RESPONSE #1
        DisplayStringHead(Player1,~Protected.~)
END

IF
    !CheckSpellState(Player1,PROTECTION_FROM_EVIL)
THEN
    RESPONSE #1
        DisplayStringHead(Player1,~Not protected.~)
END
>>>>>>>>
EXTEND_TOP baldur25.bcs extend.baf

 

[Avenger_teambg]

Bad logic.

!false should be true.

!true should be false.

Yeah, it should be. You seem to be assuming the engine works logically though, and you should know better by now (basically what GeN1e said - negation doesn't always seem to work binarily).

I know only about 'triggeroverride' and 'or' that are ignoring the negation flag. These are not real triggers.

Edited by Avenger_teambg, 27 February 2018 - 08:44 AM.

[temnix]

TriggerOverride is real enough, and negation works with it. But Ardanis is right about spell states, and so is subtledoctor. Apparently my "environment" was to blame. When I reproduce the issue as Ardanis wrote, everything works.

[subtledoctor]

Blame climate change