19 replies to this topic

[AndrewB]

As has been reported by myself and a few others over in the BWP thread (BWP v8.3 thread) there appears to be some kind of problem with the Wildmage kit in BWP installs that has yet to be pinned down, probably because the reports of it have been sporadic due to the modular nature of the BWP, and it having managed to escape a lot of people's notice (not everyone wants to play a Wildmage). The symptoms of the problem have already been mentioned here (Chars changing classes mid-game), and after some changelogs we started digging through .tp2's to try and sniff out what was causing the Wildmage kit to be more broken than Jackie Chan's skeleton during a movie shoot. In case you were wondering, I'm posting this here because Refinements deals with assigning kits in order to function properly (and you might want to know what could potentially break your junk), and.. well, I've never written a scrap of code in my life and could use your expertise

My comments are pretty much all speculation. I'm sure there are things I've misunderstood or missed in ignorance, but that aside, here is the chain of .tp2 changes that appear to be relevant,

Spoiler

The Chain of KIT.IDS changes starts with Big Picture

COPY_EXISTING ~kit.ids~ ~override~
  REPLACE_TEXTUALLY ~0x00004000~ ~0x4000~ // TRUECLASS/MAGESCHOOL_GENERALIST
  REPLACE_TEXTUALLY ~0x00000040~ ~0x0040~ // MAGESCHOOL_ABJURER
  REPLACE_TEXTUALLY ~0x00000080~ ~0x0080~ // MAGESCHOOL_CONJURER
  REPLACE_TEXTUALLY ~0x00000100~ ~0x0100~ // MAGESCHOOL_DIVINER
  REPLACE_TEXTUALLY ~0x00000200~ ~0x0200~ // MAGESCHOOL_ENCHANTER
  REPLACE_TEXTUALLY ~0x00000400~ ~0x0400~ // MAGESCHOOL_ILLUSIONIST
  REPLACE_TEXTUALLY ~0x00000800~ ~0x0800~ // MAGESCHOOL_INVOKER
  REPLACE_TEXTUALLY ~0x00001000~ ~0x1000~ // MAGESCHOOL_NECROMANCER
  REPLACE_TEXTUALLY ~0x00002000~ ~0x2000~ // MAGESCHOOL_TRANSMUTER
  REPLACE_TEXTUALLY ~0x00000001~ ~0x4001~ // BERSERKER
  REPLACE_TEXTUALLY ~0x00000002~ ~0x4002~ // WIZARDSLAYER
  REPLACE_TEXTUALLY ~0x00000004~ ~0x4003~ // KENSAI
  REPLACE_TEXTUALLY ~0x00000008~ ~0x4004~ // CAVALIER
  REPLACE_TEXTUALLY ~0x00000010~ ~0x4005~ // INQUISITOR
  REPLACE_TEXTUALLY ~0x00000020~ ~0x4006~ // UNDEADHUNTER
  REPLACE_TEXTUALLY ~0x00008000~ ~0x4007~ // FERALAN
  REPLACE_TEXTUALLY ~0x00010000~ ~0x4008~ // STALKER
  REPLACE_TEXTUALLY ~0x00020000~ ~0x4009~ // BEASTMASTER
  REPLACE_TEXTUALLY ~0x00040000~ ~0x400A~ // ASSASIN
  REPLACE_TEXTUALLY ~0x00080000~ ~0x400B~ // BOUNTYHUNTER
  REPLACE_TEXTUALLY ~0x00100000~ ~0x400C~ // SWASHBUCKLER
  REPLACE_TEXTUALLY ~0x00200000~ ~0x400D~ // BLADE
  REPLACE_TEXTUALLY ~0x00400000~ ~0x400E~ // JESTER
  REPLACE_TEXTUALLY ~0x00800000~ ~0x400F~ // SKALD
  REPLACE_TEXTUALLY ~0x01000000~ ~0x4013~ // GODTALOS
  REPLACE_TEXTUALLY ~0x02000000~ ~0x4014~ // GODHELM
  REPLACE_TEXTUALLY ~0x04000000~ ~0x4015~ // GODLATHANDER
  REPLACE_TEXTUALLY ~0x08000000~ ~0x4010~ // TOTEMIC
  REPLACE_TEXTUALLY ~0x10000000~ ~0x4011~ // SHAPESHIFTER
  REPLACE_TEXTUALLY ~0x20000000~ ~0x4012~ // BEASTFRIEND
  REPLACE_TEXTUALLY ~0x40000000~ ~0x401F~ // BARBARIAN
  REPLACE_TEXTUALLY ~0x0000 BARBARIAN~ ~0x401F BARBARIAN~ //Some mods install this incorrectly
 BUT_ONLY_IF_IT_CHANGES

APPEND ~kit.ids~ ~0x0000 WILDMAGE~ UNLESS ~0x0000 WILDMAGE~

Then the Ding0's Questpack comes along

COPY_EXISTING ~kit.ids~ ~override~
REPLACE_TEXTUALLY ~.*\bTRUECLASS\b~              ~0x4000 TRUECLASS~
REPLACE_TEXTUALLY ~.*\bBERSERKER\b~              ~0x4001 BERSERKER~
REPLACE_TEXTUALLY ~.*\bWIZARDSLAYER\b~           ~0x4002 WIZARDSLAYER~
REPLACE_TEXTUALLY ~.*\bKENSAI\b~                 ~0x4003 KENSAI~
REPLACE_TEXTUALLY ~.*\bCAVALIER\b~               ~0x4004 CAVALIER~
REPLACE_TEXTUALLY ~.*\bINQUISITOR\b~             ~0x4005 INQUISITOR~
REPLACE_TEXTUALLY ~.*\bUNDEADHUNTER\b~           ~0x4006 UNDEADHUNTER~
REPLACE_TEXTUALLY ~.*\bMAGESCHOOL_ABJURER\b~     ~0x0040 MAGESCHOOL_ABJURER~
REPLACE_TEXTUALLY ~.*\bMAGESCHOOL_CONJURER\b~    ~0x0080 MAGESCHOOL_CONJURER~
REPLACE_TEXTUALLY ~.*\bMAGESCHOOL_DIVINER\b~     ~0x0100 MAGESCHOOL_DIVINER~
REPLACE_TEXTUALLY ~.*\bMAGESCHOOL_ENCHANTER\b~   ~0x0200 MAGESCHOOL_ENCHANTER~
REPLACE_TEXTUALLY ~.*\bMAGESCHOOL_ILLUSIONIST\b~ ~0x0400 MAGESCHOOL_ILLUSIONIST~
REPLACE_TEXTUALLY ~.*\bMAGESCHOOL_INVOKER\b~     ~0x0800 MAGESCHOOL_INVOKER~
REPLACE_TEXTUALLY ~.*\bMAGESCHOOL_NECROMANCER\b~ ~0x1000 MAGESCHOOL_NECROMANCER~
REPLACE_TEXTUALLY ~.*\bMAGESCHOOL_TRANSMUTER\b~  ~0x2000 MAGESCHOOL_TRANSMUTER~
REPLACE_TEXTUALLY ~.*\bMAGESCHOOL_GENERALIST\b~  ~0x4000 MAGESCHOOL_GENERALIST~
REPLACE_TEXTUALLY ~.*\bFERALAN\b~                ~0x4007 FERALAN~
REPLACE_TEXTUALLY ~.*\bSTALKER\b~                ~0x4008 STALKER~
REPLACE_TEXTUALLY ~.*\bBEASTMASTER\b~            ~0x4009 BEASTMASTER~
REPLACE_TEXTUALLY ~.*\bASSASIN\b~                ~0x400A ASSASIN~
REPLACE_TEXTUALLY ~.*\bBOUNTYHUNTER\b~           ~0x400B BOUNTYHUNTER~
REPLACE_TEXTUALLY ~.*\bSWASHBUCKLER\b~           ~0x400C SWASHBUCKLER~
REPLACE_TEXTUALLY ~.*\bBLADE\b~                  ~0x400D BLADE~
REPLACE_TEXTUALLY ~.*\bJESTER\b~                 ~0x400E JESTER~
REPLACE_TEXTUALLY ~.*\bSKALD\b~                  ~0x400F SKALD~
REPLACE_TEXTUALLY ~.*\bGODTALOS\b~               ~0x4013 GODTALOS~
REPLACE_TEXTUALLY ~.*\bGODHELM\b~                ~0x4014 GODHELM~
REPLACE_TEXTUALLY ~.*\bGODLATHANDER\b~           ~0x4015 GODLATHANDER~
REPLACE_TEXTUALLY ~.*\bTOTEMIC\b~                ~0x4010 TOTEMIC~
REPLACE_TEXTUALLY ~.*\bSHAPESHIFTER\b~           ~0x4011 SHAPESHIFTER~
REPLACE_TEXTUALLY ~.*\bBEASTFRIEND\b~            ~0x4012 BEASTFRIEND~
REPLACE_TEXTUALLY ~.*\bBARBARIAN\b~              ~0x0000 BARBARIAN~
REPLACE_TEXTUALLY ~.*\bWILDMAGE\b~               ~0x0000 WILDMAGE~
BUT_ONLY_IF_IT_CHANGES

APPEND ~kit.ids~ ~0x4000 TRUECLASS~
UNLESS ~\bTRUECLASS\b~
APPEND ~kit.ids~ ~0x0000 BARBARIAN~
UNLESS ~\bBARBARIAN\b~
APPEND ~kit.ids~ ~0x0000 WILDMAGE~
UNLESS ~\bWILDMAGE\b~

all entries are consistent except for the Barbarian, which gets set to occupy the same numerical value as Wildmages, 0x0000 (I'm going to venture a guess that it's not a good idea to have two classes occupying the same place on the table)

Song and Silence comes after that,

COPY_EXISTING ~KIT.IDS~ ~override~
  REPLACE_TEXTUALLY ~0x00004000~ ~0x4000~ // TRUECLASS/MAGESCHOOL_GENERALIST
  REPLACE_TEXTUALLY ~0x00000040~ ~0x0040~ // MAGESCHOOL_ABJURER
  REPLACE_TEXTUALLY ~0x00000080~ ~0x0080~ // MAGESCHOOL_CONJURER
  REPLACE_TEXTUALLY ~0x00000100~ ~0x0100~ // MAGESCHOOL_DIVINER
  REPLACE_TEXTUALLY ~0x00000200~ ~0x0200~ // MAGESCHOOL_ENCHANTER
  REPLACE_TEXTUALLY ~0x00000400~ ~0x0400~ // MAGESCHOOL_ILLUSIONIST
  REPLACE_TEXTUALLY ~0x00000800~ ~0x0800~ // MAGESCHOOL_INVOKER
  REPLACE_TEXTUALLY ~0x00001000~ ~0x1000~ // MAGESCHOOL_NECROMANCER
  REPLACE_TEXTUALLY ~0x00002000~ ~0x2000~ // MAGESCHOOL_TRANSMUTER
  REPLACE_TEXTUALLY ~0x00000001~ ~0x4001~ // BERSERKER
  REPLACE_TEXTUALLY ~0x00000002~ ~0x4002~ // WIZARDSLAYER
  REPLACE_TEXTUALLY ~0x00000004~ ~0x4003~ // KENSAI
  REPLACE_TEXTUALLY ~0x00000008~ ~0x4004~ // CAVALIER
  REPLACE_TEXTUALLY ~0x00000010~ ~0x4005~ // INQUISITOR
  REPLACE_TEXTUALLY ~0x00000020~ ~0x4006~ // UNDEADHUNTER
  REPLACE_TEXTUALLY ~0x00008000~ ~0x4007~ // FERALAN
  REPLACE_TEXTUALLY ~0x00010000~ ~0x4008~ // STALKER
  REPLACE_TEXTUALLY ~0x00020000~ ~0x4009~ // BEASTMASTER
  REPLACE_TEXTUALLY ~0x00040000~ ~0x400A~ // ASSASIN
  REPLACE_TEXTUALLY ~0x00080000~ ~0x400B~ // BOUNTYHUNTER
  REPLACE_TEXTUALLY ~0x00100000~ ~0x400C~ // SWASHBUCKLER
  REPLACE_TEXTUALLY ~0x00200000~ ~0x400D~ // BLADE
  REPLACE_TEXTUALLY ~0x00400000~ ~0x400E~ // JESTER
  REPLACE_TEXTUALLY ~0x00800000~ ~0x400F~ // SKALD
  REPLACE_TEXTUALLY ~0x01000000~ ~0x4013~ // GODTALOS
  REPLACE_TEXTUALLY ~0x02000000~ ~0x4014~ // GODHELM
  REPLACE_TEXTUALLY ~0x04000000~ ~0x4015~ // GODLATHANDER
  REPLACE_TEXTUALLY ~0x08000000~ ~0x4010~ // TOTEMIC
  REPLACE_TEXTUALLY ~0x10000000~ ~0x4011~ // SHAPESHIFTER
  REPLACE_TEXTUALLY ~0x20000000~ ~0x4012~ // BEASTFRIEND
  REPLACE_TEXTUALLY ~0x40000000~ ~0x401F~ // BARBARIAN
BUT_ONLY_IF_IT_CHANGES

Song and Silence seems to be affecting a fix similar to Big Picture, changing any of the Vanilla values it finds to the BP table. But as we aren't using the vanilla values, I don't think this is relevant.

And then Divine Remix,

// fixing kit.ids
COPY_EXISTING ~kit.ids~ ~override~
  REPLACE_TEXTUALLY ~.*\bTRUECLASS\b~              ~0x4000 TRUECLASS~
  REPLACE_TEXTUALLY ~.*\bBERSERKER\b~              ~0x4001 BERSERKER~
  REPLACE_TEXTUALLY ~.*\bWIZARDSLAYER\b~           ~0x4002 WIZARDSLAYER~
  REPLACE_TEXTUALLY ~.*\bKENSAI\b~                 ~0x4003 KENSAI~
  REPLACE_TEXTUALLY ~.*\bCAVALIER\b~               ~0x4004 CAVALIER~
  REPLACE_TEXTUALLY ~.*\bINQUISITOR\b~             ~0x4005 INQUISITOR~
  REPLACE_TEXTUALLY ~.*\bUNDEADHUNTER\b~           ~0x4006 UNDEADHUNTER~
  REPLACE_TEXTUALLY ~.*\bMAGESCHOOL_ABJURER\b~     ~0x0040 MAGESCHOOL_ABJURER~
  REPLACE_TEXTUALLY ~.*\bMAGESCHOOL_CONJURER\b~    ~0x0080 MAGESCHOOL_CONJURER~
  REPLACE_TEXTUALLY ~.*\bMAGESCHOOL_DIVINER\b~     ~0x0100 MAGESCHOOL_DIVINER~
  REPLACE_TEXTUALLY ~.*\bMAGESCHOOL_ENCHANTER\b~   ~0x0200 MAGESCHOOL_ENCHANTER~
  REPLACE_TEXTUALLY ~.*\bMAGESCHOOL_ILLUSIONIST\b~ ~0x0400 MAGESCHOOL_ILLUSIONIST~
  REPLACE_TEXTUALLY ~.*\bMAGESCHOOL_INVOKER\b~     ~0x0800 MAGESCHOOL_INVOKER~
  REPLACE_TEXTUALLY ~.*\bMAGESCHOOL_NECROMANCER\b~ ~0x1000 MAGESCHOOL_NECROMANCER~
  REPLACE_TEXTUALLY ~.*\bMAGESCHOOL_TRANSMUTER\b~  ~0x2000 MAGESCHOOL_TRANSMUTER~
  REPLACE_TEXTUALLY ~.*\bMAGESCHOOL_GENERALIST\b~  ~0x4000 MAGESCHOOL_GENERALIST~
  REPLACE_TEXTUALLY ~.*\bFERALAN\b~                ~0x4007 FERALAN~
  REPLACE_TEXTUALLY ~.*\bSTALKER\b~                ~0x4008 STALKER~
  REPLACE_TEXTUALLY ~.*\bBEASTMASTER\b~            ~0x4009 BEASTMASTER~
  REPLACE_TEXTUALLY ~.*\bASSASIN\b~                ~0x400A ASSASIN~
  REPLACE_TEXTUALLY ~.*\bBOUNTYHUNTER\b~           ~0x400B BOUNTYHUNTER~
  REPLACE_TEXTUALLY ~.*\bSWASHBUCKLER\b~           ~0x400C SWASHBUCKLER~
  REPLACE_TEXTUALLY ~.*\bBLADE\b~                  ~0x400D BLADE~
  REPLACE_TEXTUALLY ~.*\bJESTER\b~                 ~0x400E JESTER~
  REPLACE_TEXTUALLY ~.*\bSKALD\b~                  ~0x400F SKALD~
  REPLACE_TEXTUALLY ~.*\bGODTALOS\b~               ~0x4013 GODTALOS~
  REPLACE_TEXTUALLY ~.*\bGODHELM\b~                ~0x4014 GODHELM~
  REPLACE_TEXTUALLY ~.*\bGODLATHANDER\b~           ~0x4015 GODLATHANDER~
  REPLACE_TEXTUALLY ~.*\bTOTEMIC\b~                ~0x4010 TOTEMIC~
  REPLACE_TEXTUALLY ~.*\bSHAPESHIFTER\b~           ~0x4011 SHAPESHIFTER~
  REPLACE_TEXTUALLY ~.*\bBEASTFRIEND\b~            ~0x4012 BEASTFRIEND~
  REPLACE_TEXTUALLY ~.*\bBARBARIAN\b~              ~0x0000 BARBARIAN~
  REPLACE_TEXTUALLY ~.*\bWILDMAGE\b~               ~0x0000 WILDMAGE~
  BUT_ONLY_IF_IT_CHANGES

APPEND ~kit.ids~ ~0x4000 TRUECLASS~
  UNLESS ~\bTRUECLASS\b~
APPEND ~kit.ids~ ~0x0000 BARBARIAN~
  UNLESS ~\bBARBARIAN\b~
APPEND ~kit.ids~ ~0x0000 WILDMAGE~
  UNLESS ~\bWILDMAGE\b~

The block of changes is identical to that of Questpack's, with both Barbarian's and Wildmages being set to 0x0000

and finally, Refinements

// Corrections to KIT.IDS. Translates in WeiDU the corrections originally
        // made by Dyara

        COPY_EXISTING     ~KIT.IDS~                  ~override/KIT.IDS~
                REPLACE_TEXTUALLY ~0x00004000 TRUECLASS~     ~0x4000 TRUECLASS~
                REPLACE_TEXTUALLY ~0x00000001~         ~0x4001~
                REPLACE_TEXTUALLY ~0x00000002~         ~0x4002~
                REPLACE_TEXTUALLY ~0x00000004~         ~0x4003~
                REPLACE_TEXTUALLY ~0x00000008~         ~0x4004~
                REPLACE_TEXTUALLY ~0x00000010~         ~0x4005~
                REPLACE_TEXTUALLY ~0x00000020~         ~0x4006~
                REPLACE_TEXTUALLY ~0x00000040~         ~0x0040~
                REPLACE_TEXTUALLY ~0x00000080~         ~0x0080~
                REPLACE_TEXTUALLY ~0x00000100~         ~0x0100~
                REPLACE_TEXTUALLY ~0x00000200~         ~0x0200~
                REPLACE_TEXTUALLY ~0x00000400~         ~0x0400~
                REPLACE_TEXTUALLY ~0x00000800~         ~0x0800~
                REPLACE_TEXTUALLY ~0x00001000~         ~0x1000~
                REPLACE_TEXTUALLY ~0x00002000~         ~0x2000~
                REPLACE_TEXTUALLY ~0x00008000~         ~0x4007~
                REPLACE_TEXTUALLY ~0x00010000~         ~0x4008~
                REPLACE_TEXTUALLY ~0x00020000~         ~0x4009~
                REPLACE_TEXTUALLY ~0x00040000 MAGESCHOOL_GENERALIST~   ~0x4000 MAGESCHOOL_GENERALIST~
                REPLACE_TEXTUALLY ~0x00080000~         ~0x400B~
                REPLACE_TEXTUALLY ~0x00100000~         ~0x400C~
                REPLACE_TEXTUALLY ~0x00200000~         ~0x400D~
                REPLACE_TEXTUALLY ~0x00400000~         ~0x400E~
                REPLACE_TEXTUALLY ~0x00800000~         ~0x400F~
                REPLACE_TEXTUALLY ~0x01000000~         ~0x4013~
                REPLACE_TEXTUALLY ~0x02000000~         ~0x4014~
                REPLACE_TEXTUALLY ~0x04000000~         ~0x4015~
                REPLACE_TEXTUALLY ~0x08000000~         ~0x4010~
                REPLACE_TEXTUALLY ~0x10000000~         ~0x4011~
                REPLACE_TEXTUALLY ~0x20000000~         ~0x4012~
                REPLACE_TEXTUALLY ~0x40000000 BARBARIAN~         ~0x401F BARBARIAN~
                // Added by the_bigg, further corrections by Littiz. Some installations have a
                // different (and still wrong) version of KIT.IDS, so they require a different patch:
                REPLACE_TEXTUALLY ~0x00004000 BARBARIAN~         ~0x401F BARBARIAN~
                REPLACE_TEXTUALLY ~0x40010000~         ~0x4001~
                REPLACE_TEXTUALLY ~0x40020000~         ~0x4002~
                REPLACE_TEXTUALLY ~0x40030000~         ~0x4003~
                REPLACE_TEXTUALLY ~0x40040000~         ~0x4004~
                REPLACE_TEXTUALLY ~0x40050000~         ~0x4005~
                REPLACE_TEXTUALLY ~0x40060000~         ~0x4006~
                REPLACE_TEXTUALLY ~0x00400000~         ~0x0040~
                REPLACE_TEXTUALLY ~0x00800000~         ~0x0080~
                REPLACE_TEXTUALLY ~0x01000000~         ~0x0100~
                REPLACE_TEXTUALLY ~0x02000000~         ~0x0200~
                REPLACE_TEXTUALLY ~0x04000000~         ~0x0400~
                REPLACE_TEXTUALLY ~0x08000000~         ~0x0800~
                REPLACE_TEXTUALLY ~0x10000000~         ~0x1000~
                REPLACE_TEXTUALLY ~0x20000000~         ~0x2000~
                REPLACE_TEXTUALLY ~0x40000000 TRUECLASS~               ~0x4000 TRUECLASS~
                REPLACE_TEXTUALLY ~0x40000000 MAGESCHOOL_GENERALIST~   ~0x4000 MAGESCHOOL_GENERALIST~
                REPLACE_TEXTUALLY ~0x40070000~         ~0x4007~
                REPLACE_TEXTUALLY ~0x40080000~         ~0x4008~
                REPLACE_TEXTUALLY ~0x40090000~         ~0x4009~
                REPLACE_TEXTUALLY ~0x400A0000~         ~0x400A~
                REPLACE_TEXTUALLY ~0x400B0000~         ~0x400B~
                REPLACE_TEXTUALLY ~0x400C0000~         ~0x400C~
                REPLACE_TEXTUALLY ~0x400D0000~         ~0x400D~
                REPLACE_TEXTUALLY ~0x400E0000~         ~0x400E~
                REPLACE_TEXTUALLY ~0x400F0000~         ~0x400F~
                REPLACE_TEXTUALLY ~0x40130000~         ~0x4013~
                REPLACE_TEXTUALLY ~0x40140000~         ~0x4014~
                REPLACE_TEXTUALLY ~0x40150000~         ~0x4015~
                REPLACE_TEXTUALLY ~0x40100000~         ~0x4010~
                REPLACE_TEXTUALLY ~0x40110000~         ~0x4011~
                REPLACE_TEXTUALLY ~0x40120000~         ~0x4012~
                REPLACE_TEXTUALLY ~0x401F0000~         ~0x401F~
        BUT_ONLY_IF_IT_CHANGES

Very similar to the BP's block. I assume it is taking any of the old vanilla values and converting them to the BP table, in case anyone installing the mod is still using those values. I suspect it isn't relevant, except that due to Questpack and DR's changes, the last state of Barbarians was not 0x401F , but 0x0000 .

What I suspect is that the break occurs at Questpack and again later at Divine Remix, and that it can be fixed by replacing these lines in both of those .tp2s

REPLACE_TEXTUALLY ~.*\bBARBARIAN\b~              ~0x0000 BARBARIAN~

APPEND ~kit.ids~ ~0x0000 BARBARIAN~
UNLESS ~\bBARBARIAN\b~

with

REPLACE_TEXTUALLY ~.*\bBARBARIAN\b~              ~0x401F BARBARIAN~

APPEND ~kit.ids~ ~0x401F BARBARIAN~
UNLESS ~\bBARBARIAN\b~

What do you think?

[the bigg]

What makes you think that I am the correct person to ask how to fix a mod I am not the author of?

[Hoppy]

What makes you think that I am the correct person to ask how to fix a mod I am not the author of?

Maybe a better question or a better phrasing of the question is what KIT.IDS patching/fix does Refinements work the best with as far as not getting the aforementioned errors? I assume G3 fixpack is the standard and any other mods that try to fix the IDS or think they fix it should not be installed pre-Refinements.

[AndrewB]

What makes you think that I am the correct person to ask how to fix a mod I am not the author of?

I don't know that anyone but the mod's creator would be the "correct" person to ask, and in an ideal world they'd always be there to answer you. But some of those dudes can't be reached and you're the code guru around here, so if it ain't you hoss, I don't know who it is. Also as Hoppy mentioned, I'm more concerned with what, in your opinion, would provide the best continuity chain leading into Refinements.

Edited by AndrewB, 27 March 2010 - 04:21 PM.

[AndrewB]

Did some more digging. The fixpack uses the "0x0000 BARBARIAN , 0x0000 WILDMAGE" model but I found an old thread in the fixpack forum relating to this.

It occurs to me that maybe those other mods don't even need to be changed. Maybe Refinements could add a compatibility line to account for those with the 0x0000 BARBARIAN entry to make sure it gets them where they need to be. I would guess something like this to the end of it's kit.ids table:

REPLACE_TEXTUALLY ~0x0000 BARBARIAN~ ~0x401F BARBARIAN~

[the bigg]

I tried a bunch of variations and I can't get them to work. I'm afraid I'll have to block barbarians being dual-classable to thief and mage to avoid issues

Edited by the bigg, 28 March 2010 - 07:37 AM.

[Miloch]

Did some more digging. The fixpack uses the "0x0000 BARBARIAN , 0x0000 WILDMAGE" model but I found an old thread in the fixpack forum relating to this.

Very confusing. So which is right? The IESDP has barbarian at 0x4000 which I'm fairly certain is not right.

[the bigg]

In that thread in the Fixpack forum, Idobek says that he spent some time testing and he found out that 0x401f and 0x0000 are both correct and wrong in different and subtle ways - and Idobek is usually a very reliable guy.

[AndrewB]

could this be doing it? This is from the "Currently Known Issues" thread here on the Refinements board.

G3 Tweak Pack: Dual-able barbarians has to be installed after Refinements, the rest of the G3 Tweak Pack has to be installed before Refinements. (install A before B, B before C and C before A )

my WeiDu log has it being installed before Refinements, and after checking BWP 8.3's .pdf and .bat, it appears that component is being installed out of order.

edit: It also appears that this component (of the G3 Tweak pack) has it's own KIT.IDS fixer that might overwrite your changes in refinements:

Spoiler

REPLACE_TEXTUALLY ~.*\bTRUECLASS\b~              ~0x4000 TRUECLASS~
  REPLACE_TEXTUALLY ~.*\bBERSERKER\b~              ~0x4001 BERSERKER~
  REPLACE_TEXTUALLY ~.*\bWIZARDSLAYER\b~           ~0x4002 WIZARDSLAYER~
  REPLACE_TEXTUALLY ~.*\bKENSAI\b~                 ~0x4003 KENSAI~
  REPLACE_TEXTUALLY ~.*\bCAVALIER\b~               ~0x4004 CAVALIER~
  REPLACE_TEXTUALLY ~.*\bINQUISITOR\b~             ~0x4005 INQUISITOR~
  REPLACE_TEXTUALLY ~.*\bUNDEADHUNTER\b~           ~0x4006 UNDEADHUNTER~
  REPLACE_TEXTUALLY ~.*\bMAGESCHOOL_ABJURER\b~     ~0x0040 MAGESCHOOL_ABJURER~
  REPLACE_TEXTUALLY ~.*\bMAGESCHOOL_CONJURER\b~    ~0x0080 MAGESCHOOL_CONJURER~
  REPLACE_TEXTUALLY ~.*\bMAGESCHOOL_DIVINER\b~     ~0x0100 MAGESCHOOL_DIVINER~
  REPLACE_TEXTUALLY ~.*\bMAGESCHOOL_ENCHANTER\b~   ~0x0200 MAGESCHOOL_ENCHANTER~
  REPLACE_TEXTUALLY ~.*\bMAGESCHOOL_ILLUSIONIST\b~ ~0x0400 MAGESCHOOL_ILLUSIONIST~
  REPLACE_TEXTUALLY ~.*\bMAGESCHOOL_INVOKER\b~     ~0x0800 MAGESCHOOL_INVOKER~
  REPLACE_TEXTUALLY ~.*\bMAGESCHOOL_NECROMANCER\b~ ~0x1000 MAGESCHOOL_NECROMANCER~
  REPLACE_TEXTUALLY ~.*\bMAGESCHOOL_TRANSMUTER\b~  ~0x2000 MAGESCHOOL_TRANSMUTER~
  REPLACE_TEXTUALLY ~.*\bMAGESCHOOL_GENERALIST\b~  ~0x4000 MAGESCHOOL_GENERALIST~
  REPLACE_TEXTUALLY ~.*\bFERALAN\b~                ~0x4007 FERALAN~
  REPLACE_TEXTUALLY ~.*\bSTALKER\b~                ~0x4008 STALKER~
  REPLACE_TEXTUALLY ~.*\bBEASTMASTER\b~            ~0x4009 BEASTMASTER~
  REPLACE_TEXTUALLY ~.*\bASSASIN\b~                ~0x400A ASSASIN~
  REPLACE_TEXTUALLY ~.*\bBOUNTYHUNTER\b~           ~0x400B BOUNTYHUNTER~
  REPLACE_TEXTUALLY ~.*\bSWASHBUCKLER\b~           ~0x400C SWASHBUCKLER~
  REPLACE_TEXTUALLY ~.*\bBLADE\b~                  ~0x400D BLADE~
  REPLACE_TEXTUALLY ~.*\bJESTER\b~                 ~0x400E JESTER~
  REPLACE_TEXTUALLY ~.*\bSKALD\b~                  ~0x400F SKALD~
  REPLACE_TEXTUALLY ~.*\bGODTALOS\b~               ~0x4013 GODTALOS~
  REPLACE_TEXTUALLY ~.*\bGODHELM\b~                ~0x4014 GODHELM~
  REPLACE_TEXTUALLY ~.*\bGODLATHANDER\b~           ~0x4015 GODLATHANDER~
  REPLACE_TEXTUALLY ~.*\bTOTEMIC\b~                ~0x4010 TOTEMIC~
  REPLACE_TEXTUALLY ~.*\bSHAPESHIFTER\b~           ~0x4011 SHAPESHIFTER~
  REPLACE_TEXTUALLY ~.*\bBEASTFRIEND\b~            ~0x4012 BEASTFRIEND~
  REPLACE_TEXTUALLY ~.*\bBARBARIAN\b~              ~0x0000 BARBARIAN~
  REPLACE_TEXTUALLY ~.*\bWILDMAGE\b~               ~0x0000 WILDMAGE~
  BUT_ONLY_IF_IT_CHANGES

APPEND ~kit.ids~ ~0x4000 TRUECLASS~
  UNLESS ~\bTRUECLASS\b~
APPEND ~kit.ids~ ~0x0000 BARBARIAN~
  UNLESS ~\bBARBARIAN\b~
APPEND ~kit.ids~ ~0x0000 WILDMAGE~
  UNLESS ~\bWILDMAGE\b~

COPY_EXISTING_REGEXP GLOB ~Anomen[0-9]+\.cre$~  ~override~
                          ~Haer[0-9]+\.cre$~    ~override~
                          ~_?Imoen[0-9]+\.cre$~ ~override~
                          ~Korgan[0-9]+\.cre$~  ~override~
                          ~Mazzy[0-9]+\.cre$~   ~override~
  PATCH_IF (SOURCE_SIZE > 0x2d3) THEN BEGIN // protects against invalid files
    READ_LONG 0x0244 KIT_VALUE
    PATCH_IF (KIT_VALUE = 0x00) BEGIN
      WRITE_LONG 0x0244 0x40000000
    END ELSE
    PATCH_IF (KIT_VALUE = 0x20) BEGIN
      WRITE_LONG 0x0244 0x400d0000
    END ELSE
    PATCH_IF (KIT_VALUE = 0x010000) BEGIN
      WRITE_LONG 0x0244 0x40010000
    END
  END
  BUT_ONLY_IF_IT_CHANGES

Edited by AndrewB, 29 March 2010 - 07:05 AM.

[the bigg]

That message is five years old, I can't recall what the problem is/was (and Use Scrolls was completely rewritten since that message was posted, so it's likely that any problems that might've existed are nonexistent now). I've also tested a dozen of kit.ids and scripting variations and none of them worked correctly, so I'll be lazy and simply disable barb->thief and barb->mage.

[AndrewB]

bummer. Well, thank you for giving the issue your attention. I know you've had a lot going on with WeiDu and Generalized Biffing lately.

[maximus2001]

Well some good news! It is the BG2 Tweaks component #2140 // Expanded Dual-Class Options: v8. (for Barbarians and Wild Mages)

I removed this from the BWP install.bat and summoned Worgas the wildmage and it works fine. Weapons work, spells work, etc.

[AndrewB]

I just noticed another little oddity in my KIT.IDS while looking in NI. Take a look at this section of my KIT.IDS and see if you notice anything out of place..

Spoiler

IDS
0x4000 TRUECLASS                    
0x4001 BERSERKER                    
0x4002 WIZARDSLAYER                 
0x4003 KENSAI                       
0x4004 CAVALIER                     
0x4005 INQUISITOR                   
0x4006 UNDEADHUNTER                 
0x0040 MAGESCHOOL_ABJURER           
0x0080 MAGESCHOOL_CONJURER          
0x0100 MAGESCHOOL_DIVINER           
0x0200 MAGESCHOOL_ENCHANTER         
0x0400 MAGESCHOOL_ILLUSIONIST       
0x0800 MAGESCHOOL_INVOKER           
0x1000 MAGESCHOOL_NECROMANCER       
0x2000 MAGESCHOOL_TRANSMUTER        
0x0000 WILDMAGE        
0x4007 FERALAN                      
0x4008 STALKER                      
0x4009 BEASTMASTER                  
0x400A ASSASIN                      
0x400B BOUNTYHUNTER                 
0x400C SWASHBUCKLER                 
0x400D BLADE                        
0x400E JESTER                       
0x400F SKALD                        
0x4013 GODTALOS                     
0x4014 GODHELM                      
0x4015 GODLATHANDER                 
0x4010 TOTEMIC                      
0x4011 SHAPESHIFTER                 
0x4012 BEASTFRIEND                  
0x0000 BARBARIAN                    
0x0000 WILDMAGE

0x2000 MAGESCHOOL_TRANSMUTER
0x0000 WILDMAGE
...
...
0x0000 BARBARIAN
0x0000 WILDMAGE

Two "0x0000 WILDMAGE" entries. I don't know quite how it happened or what effect it's having (if any), but I think it might be one of the APPEND(s) doing it.

Also, what kind of trouble are you seeing with Barb/Thief? Is it just with the Use Scrolls HLA? I noticed some immediate problems with Barb/Mage (immediately after dual-classing the inactive class lost it's kit and when it reactived, it did so as a generic kitless-fighter and never regained Barb Rage and proper usability flags) but the only problem I noticed with Barb/Thief occurred when I took Use Scrolls. The inactive class reactivated properly and gained all of it's unique kit features and usabilities, but everything went haywire when I took Use Scrolls. The usability flag got all screwy, and the inactive class lost it's kit and reverted to a generic kitless fighter immediately after taking that HLA.

If it is just that HLA in particular, would you be able to just disallow them from using that particular HLA? Barbarian's are illiterate anyway.

Edited by AndrewB, 31 March 2010 - 02:11 AM.

[Wisp]

I just noticed another little oddity in my KIT.IDS while looking in NI. Take a look at this section of my KIT.IDS and see if you notice anything out of place..

I think some mod(s) replace MAGESCHOOL_GENERALIST with WILDMAGE, rather than appending WILDMAGE. I don't think MAGESCHOOL_GENERALIST should be replaced.

[AndrewB]

ahh, I see now. Yes, that makes sense. That entry is right where Generalist should be. I will try to pinpoint the mod doing it.

[Lollorian]

And narrowing that down, I've scoured my mod folder for any that do this and (drumroll)

- Amber
- ding0's Tweakpack
- ding0's Questpack
- Kitanya

All 4 of their .tp2's have:

REPLACE_TEXTUALLY ~.*\bMAGESCHOOL_GENERALIST\b~  ~0x0000 WILDMAGE~

[the bigg]

The problem is that there is no reliable way (or I couldn't find one) to distinguish between a Barbarian and a Wild Mage, something that Refinements needs to avoid errors.

[AndrewB]

is that why you can't "grey out" Use Scrolls for a Barb/Thief? Barb/Mage is probably hopelessly screwed, but you could play the entire game as a Barb/Thief and not notice anything funky unless you took Use Scrolls. I noticed that this works for the Wizard Slayer, at least.

and about the BG2 Tweaks component: I think I'm going to try installing that component after refinements, as per the suggestion in the Known Issues thread, to see if it doesn't produce better results. But I'm going to wait until whatever is going on with BP and the new WeiDU gets worked out to reinstall.

Edited by AndrewB, 31 March 2010 - 06:18 AM.

[the bigg]

Look, I'd have to write two pages of text detailing the in-depth implementation of Use Scrolls to give an ultimately convincing answer, and I'm far too lazy to do that (not to mention that it such a remote and complex hack that even an experienced modder would require a non trivial amount of time to properly understand it). The result of not being able to detect the kit is that Barbarians (including the various dual-class combinations) will either be able to use scrolls when they shouldn't, or not be able to use scrolls when they should (and, in either case, selecting the US HLA will actually be a waste of an HLA slot). Of course, I could leave US enabled, scrolls always enabled, and let the player police himself; however, I'm not a fan of that solution, and the other authors were strongly against that.

[AndrewB]

fair enough. If I've been a pain or a thorn in your side over it, I hope you realize it is only because I enjoy Refinements a great deal, and I wouldn't consider playing without it.

Edited by AndrewB, 31 March 2010 - 11:55 PM.