546 replies to this topic

[Almateria]

I know, right?

Edited by Almateria, 18 April 2013 - 08:20 AM.

[Yovaneth]

 

-Y-

[Almateria]

I uploaded a new version. New stuff:

- Deril isn't supposed to die so fast on the first meeting

- He's got a new shiny horn

- Also I guess you don't need the fixpack anymore

[micbaldur]

Nice to see new versions being made of this

 

Has anyone tried this in a BWP environment yet? Does it work well?

It installs just fine in BWP expert install, topic here. I haven't played it though.

[weewuh]

Hey, I have the BG2 Fixpack installed, but I'm getting an error trying to install the first component of this mod. Something about missing area something or other. Any idea what could be causing this?

 

Edit: Checked again: specifically something about an illegal 6-byte write to ar2700. my gut says, Ascension issue?

Edited by weewuh, 09 May 2013 - 02:05 AM.

[Wisp]

Almateria, stuff like this is a super-bad idea:

COPY_EXISTING ~worldmap.wmp~ ~override~
WRITE_ASCII ~41452~ ~ar2700~
WRITE_ASCII ~41668~ ~ar2700~
WRITE_LONG ~41492~ 50
WRITE_LONG ~41708~ 50

You can't rely on stuff outside the file header to be static like that. If mod X was installed before your mod and added one or more WMP areas, all your offsets would be off by an unknown amount. Likewise, if something was removed, you could end up writing out-of-bounds. Best case scenario would be that the installation failed with an error, but your mod could just as well end up silently corrupting whatever file it was writing to.

 

You need to read the foo offset and foo count (areas and links in this case) and navigate the file structure that way. The length of foo is always the same (but bar could obviously have a different length) and can be looked up in the IESDP or calculated with the help of NI. You can use static offsets within the file header (the very first part of the file).

[Almateria]

You need to read the foo offset and foo count (areas and links in this case) and navigate the file structure that way. The length of foo is always the same (but bar could obviously have a different length) and can be looked up in the IESDP or calculated with the help of NI. You can use static offsets within the file header (the very first part of the file).

idgi

Seriously I only have the faintest idea of what you said.

[Wisp]

idgi
Seriously I only have the faintest idea of what you said.
 

Well, simply put, you need something like this:

OUTER_SET area_length = 0xf0
OUTER_SET link_length = 0xd8
OUTER_SPRINT encounter_area ar2700
OUTER_SET encounter_probability = 50

COPY_EXISTING worldmap.wmp override
  READ_LONG 0x30 area_count
  READ_LONG 0x34 area_offset
  READ_LONG 0x38 link_offset
  READ_LONG 0x3c link_count
  FOR (i = 0; i < area_count; ++i) BEGIN
    current_area_offset = area_offset + i * area_length
    READ_ASCII current_area_offset area_name
    PATCH_IF "%area_name%" STRING_EQUAL_CASE ar1800 BEGIN
      PATCH_FOR_EACH node IN 0 3 2 1 BEGIN // 0 is North, 1 is West, etc.
        READ_LONG current_area_offset + 0x50 + node * 0x8 link_index
        READ_LONG current_area_offset + 0x54 + node * 0x8 link_count
        FOR (j = 0; j < link_count; ++j) BEGIN
          current_link_offset = link_offset + (link_index + j) * link_length
          WRITE_ASCIIE current_link_offset + 0x2c "%encounter_area%" #8
          WRITE_LONG   current_link_offset + 0x54 encounter_probability
        END
      END
      i = area_count // we're done
    END
  END
BUT_ONLY

(Assuming you want to add the encounter to all links from ar1800.)

[Almateria]

[Almateria]

Okay Wisp I used your code and I think it works. I did the same for the ToB random encounter because why not. Thanks!

[Almateria]

Did some bug fixing this time.

[Lollorian]

Line 1480 in setup-arestorationp.tp2:

ACTION_IF (~%LANGUAGE%~ STRING_COMPARE_CASE ~Polski~) THEN BEGIN

should either be:

 

ACTION_IF (~%LANGUAGE%~ STRING_EQUAL_CASE ~Polski~) THEN BEGIN

OR

ACTION_IF (~%LANGUAGE%~ STRING_COMPARE_CASE ~Polski~ = 0) THEN BEGIN

 

... because

 

Cryptic weidu operators FTW!

[Delfosse]

When you save Viconia, one of her captors called "Fanatic" has a wrong voice for moral failure. He screams "ah, i have failed him!" in a woman's voice.

 

Also, yeah, Reliev speaks a few phrases in Polish, happened to me as well.

[Lollorian]

Lines 692 and 697 in the TP2 should be exchanged to fix the cultist sex change on damage and morale failure

[Almateria]

I fixed those things. Sorry for being super late but I had pretty much no access to a computer lately

[Lollorian]

v3.4 seems to have an extra undocumented component that's missing the component name (@1000 is missing from setup.tra)

[Almateria]

No it doesn't, shush!!!!!!!!!!!

(It was the first half of some code I was working on a few months ago, it was supposed to incorporate the ruined Saradush icon)

[Lollorian]

But thing is... you haven't commented out this WIP component so the installation fails before it even starts

[Almateria]

It's not in the public version anymore anyway so what's the big deal