355 replies to this topic

[Lollorian]

That argument would be valid - if th purpose of the component wasn't precisely to fix that. But since it's a "fixer", it doesn't matter whether cres are vanilla or not.

The component that does this is "Creature Stuff - Inventory Unborker (removes spurious references to the item table)" btw - and by my principle of non-deletion of absolutely ANY game content, I remove spurious references to non-existent items by nulling them and remove references to exiting items by actually referring to them.
 
If you're referring to the Lolfixer part... well, I'm open to ideas

The thing is, I checked a dozen or so creatures, and it literally happens on every second creature affected. If you want, I can drop the whole log here, but I think that a systematic problem would be better handled in a systematic way. To be constructive,
1) the very first thing that comes to mind is to check whether the cre already has the same item. That would get rid of blatant duplicates.
2) also it could be useful to check whether the cre already has an item of the same type (at least, for armor and weapons).
3) it doesn't make sense to add undroppable items into inventory unless they are also equipped. Check grael.cre/immune1.itm, for example. (On the other hand, since they're undroppable, you could equip them into invalid slots when all valid ones are busy).

Also, unrelated to the above, but
4) I think "equipping" component doesn't always work. For instance, alanbl.cre/bow05.itm.
5) You should be more careful moving around items. Sometimes they are in invalid slots for a reason. Take Kangax. You move his ring to either a ring slot or inventory - poof, it's pickpocketable!

Before we start, I'd like to mention that I still do think the CENTEOL-like cases (extra quest items) are where the lolfixer fails - the IRONGU-like (extra standard equipment) ones are, ignorable, IMHO. I wrote the component because I didn't want CREs in my game to have "hidden and inaccessible" treasure.

1) & 2) I don't see the problem with this in IRONGU-like cases other than maybe a lack of immersion (also the lolfixer is not supposed to be a gameplay mod - it's a purely technical mod that aims to fix crashes and unlock content) - in CENTEOL-like cases, this will have no effect
3) In the case you mentioned, equipping IMMUNE1 on GRAEL.CRE would make him immune to lots of stuff - which is seriously not what this component should be doing haphazardly. Would rather just assign an inventory reference and let it sit.
4) Will have a look thanks
5) There is a very nice flag for CRE-based items which sets an item to unstealable - no unstealable flag set? I guess fair game for pickpockets.

Edited by Lollorian, 13 September 2015 - 11:32 AM.

[The Imp]

....

Yes, you are totally off.
 

Based on ?

2) also it could be useful to check whether the cre already has an item of the same type (at least, for armor and weapons).

Yeah, well, do you know how long it would take to make such a lists and do the corrective comparison and identifying the best outputs and so on and forward ?
Or the mod could be used to summearly be installed and looked up on ... and make fixes based on the output.

So now the .cre has 3 armors, you can --change-log the .cre file and report the findings of that to the proper place that the mod that adds the 3 armors can be corrected or the action can be removed.
But no, why on earth would you bother, while you could just complain to Lollorian of a thing he only made you able to see ? That could be fixed in the mod so it won't be there in the next megamod install ?

If you want, I can drop the whole log here, but I think that a systematic problem would be better handled in a systematic way. To be constructive,

Now we are getting somewhere... the way to fix all of these is to go and make a clean and properly made and incontraversiable evidence chain which points to a single mod and then go and report the wrongdoings to that mods forum.
AKA, --change-log the irongu.cre file, and then heck which mods backup doesn't have the extra armors in the inventory slots, and then report the fact to that mods forum. Easy ? Should be.
And the BiG World Fixpack can then pickup the fix from that forum instead of it needing to report all it's findings backwards.

Edited by The Imp, 13 September 2015 - 12:08 PM.

[The Imp]

You really are thick, aren't you? It's a ... vanilla cre.

Well, I knew I didn't have the tools to check... see I didn't have the Near Infinity installed on the computer I am working here with.
A Vanilla BG1 creature. Yeah, so how many other levels does the creature has besides the fighter he is currently under ? And from which class did he dual from to gain the 23 HPs it currently has, to the being a fighter ? +Any constitution bonuses. It's not like there's anything wrong there either.

But seriously now, does his bigger brother, that of "ironelit.cre" have the same like problem ? Cause the vanilla BG1 ironelit,cre has a leather armor too. Asking cause yet again I don't have the tools currently at my disposal.
These can be fixed in the BGT's export function or right afterit. They just need to be reported. I am still waiting the list. The copy paste can't be that hard.

Ahh yeah, the SCS was effected by the armors... and DavidW saw it wiser to remove the use of the irongu.cre's completelly and copy paste the ironelit.cre's as their place. Or I would remember something to that effect.

Edited by The Imp, 14 September 2015 - 10:11 AM.

[Lollorian]

Damn I'm seriously considering renaming the thing now

I think you're missing the purpose of the lolfixer It's not supposed to know anything about what it changes - it just reads files and tries to process it... which means it will NOT know whether Grael is missing half his immunities or whether Kangaxx's ring was supposed to be non-stealable.

 

Instead of going about arguing semantics, I'd appreciate if we can come up with a purely technical solution for the 5 points you raised. The solution should:

- be applicable for all files of a certain type

- not differentiate between vanilla or mod stuff

- not add anything new into the file

 

Anything, even rough algorithms, would help and I'll try to convert it into WeiDU and test it out in my installation during the weekend. If it doesn't break atleast a vanilla BGT installation, I'd be more than happy to include it

 

PS: Ignore the documentation - I only work on that part when I feel like it... which was around 3 years ago last time

[Lollorian]

Yes a pull request would be awesome

 

I'm still thinking about how to handle the CENTEOL thing though... how do we identify a quest item in pure technical terms? (duplicate spider's bane is ok, but the body double is a strict no-no )

 

EDIT: Since you mentioned the BG2Fixpack, I remember I used to handle cases that were left out by it and found the commit where I removed that block:

Spoiler

          PATCH_IF ((~%item%~ STRING_EQUAL_CASE ~MISC86~) OR                                                           //Bandit Scalp
                   ((~%item%~ STRING_EQUAL_CASE ~MISC54~) AND (~%SOURCE_RES%~ STRING_EQUAL_CASE ~JALANT~)) OR          //Child's Body
                   ((~%item%~ STRING_EQUAL_CASE ~RING07~) AND (~%SOURCE_RES%~ STRING_EQUAL_CASE ~RAMAZI~)) OR          //Ramazith's Prot Ring
                   ((~%item%~ STRING_EQUAL_CASE ~MISC2H~) AND (~%SOURCE_RES%~ STRING_EQUAL_CASE ~SHANDAL2~)) OR        //Shandalar's Wardstone
                   ((~%item%~ STRING_EQUAL_CASE ~MISC6Z~) AND (~%SOURCE_RES%~ STRING_EQUAL_CASE ~GEMCH02~)) OR         //Imnesvale Chicken's Beljuril
                   ((~%item%~ STRING_EQUAL_CASE ~MISCB7~) AND (~%SOURCE_RES%~ STRING_EQUAL_CASE ~HELLGEN~)) OR         //Genie's Tears of Bhaal
                   ((~%item%~ STRING_EQUAL_CASE ~RING39~) AND (~%SOURCE_RES%~ STRING_EQUAL_CASE ~HLKANG~)) OR          //Kangaxx's Gaxx Ring
                   ((~%item%~ STRING_EQUAL_CASE ~MISC8K~) AND (~%SOURCE_RES%~ STRING_EQUAL_CASE ~TRRAK01~)) OR         //Ihtafeer's Head
                   ((~%item%~ STRING_EQUAL_CASE ~MISCA7~) AND (~%SOURCE_RES%~ STRING_EQUAL_CASE ~UDPRINCE~)) OR        //Kuo-Tuan Prince's Blood
                   ((~%item%~ STRING_EQUAL_CASE ~MISC8H~) AND (~%SOURCE_RES%~ STRING_EQUAL_CASE ~UDSILVER~)) OR        //Adalon's Blood
                   ((~%item%~ STRING_EQUAL_CASE ~MISCCC~) AND (~%SOURCE_RES%~ STRING_EQUAL_CASE ~UDSILVER~))           //Adalon's Note
                   ) THEN BEGIN
            SET "ignore" = 1
          END

 

I think it was when I decided that the list was paltry enough to not handle specifically That was a joke btw... there must be another reason.

 

The point being the code is pretty robust to reimplement a system like this again so it should be easy for you Do ask about whatever shittiness I did whenever you feel as well... I'm never ashamed to say I code like a monkey with a typewriter

 

PS: Can you please attach or link to your full lolfixer log file like the Imp asked btw?

Edited by Lollorian, 15 September 2015 - 08:24 AM.

[Niewiem]

I think I`ll put it here as it did not get any answers yet:

http://www.shsforums...l-form-new-guy/

Leonardo Watson had same problem with his latest BWP

[Lollorian]

You mean the F_6666.ARE error? Yeah, I'm waiting to find some time to sync up the git repo with Leonardo's latest release (he's made quite a few changes of his own in there )

 

Will have a look

[Lollorian]

So an update I had a look at how to identify quest items - narrowed down on the following conditions:

 

- item must not be a random treasure

- item must be unsellable

- item must be a misc item with price = 0

 

So, revised item unborker (found = 0 means it was not referenced in the inventory table btw )

 

Spoiler

        PATCH_IF (%found% = 0) BEGIN
          READ_ASCII ("%itm_off%" + (0x14 * "%index%")) "item"
          PATCH_IF FILE_EXISTS_IN_GAME ~%item%.itm~ BEGIN
            INNER_PATCH_FILE ~%item%.itm~ BEGIN
              READ_BYTE  0x18 "flags"
              READ_SHORT 0x1c "type"
              READ_LONG  0x34 "price"
              PATCH_IF ("%item%" STRING_COMPARE_REGEXP "^[Rr][Nn][Dd].+$") AND ((("%flags%" BAND 0b00000001) = 0b00000001) OR ((%type% = 0) AND (%price% = 0))) BEGIN
                SET "critical" = 1
              END
            END
          END
          PATCH_IF %critical% = 1 BEGIN
            PATCH_PRINT "%SOURCE_FILE% error: Inventory Item #%index% (%item%.ITM) is not actually in inventory! Potentially quest-breaking item! Removing..."
            REMOVE_CRE_ITEM ~%item%~
            SET "index" = 0 - 1
            READ_LONG  0x2b8 "slot_off" ELSE 0
            READ_LONG  0x2bc "itm_off" ELSE 0
            READ_SHORT 0x2c0 "itm_num" ELSE 0
          END ELSE
          BEGIN
            FOR (index1 = 21 ; index1 < 37 && foundslot = 0 ; index1 = index1 + 1) BEGIN
              READ_SHORT ("%slot_off%" + (0x02 * "%index1%")) "ref" ELSE 0xffff
              PATCH_IF ("%ref%" = 0xffff) BEGIN
                SET "foundslot" = "index1"
              END
            END
            PATCH_IF ("%foundslot%" > 0) BEGIN
              PATCH_PRINT "%SOURCE_FILE% error: Inventory Item #%index% (%item%.ITM) is not actually in inventory! Adding to Inventory Slot #%foundslot%..."
              WRITE_SHORT ("%slot_off%" + (0x02 * "%foundslot%")) "index"
            END ELSE
            BEGIN
              FOR (index1 = 0 ; index1 < 22 && foundslot = 0 ; index1 = index1 + 1) BEGIN
                READ_SHORT ("%slot_off%" + (0x02 * "%index1%")) "ref" ELSE 0xffff
                PATCH_IF ("%ref%" = 0xffff) BEGIN
                  SET "foundslot" = "index1"
                END
              END
              PATCH_PRINT "%SOURCE_FILE% error: Inventory Item #%index% (%item%.ITM) is not actually in inventory! No free inventory slot found! Adding to Slot #%foundslot%..."
              WRITE_SHORT ("%slot_off%" + (0x02 * "%foundslot%")) "index"
            END
          END
        END

 

New log for CENTEO.CRE:

Spoiler

CENTEO.CRE error: Inventory Item #0 (RING23.ITM) is not actually in inventory! Adding to Inventory Slot #21...

CENTEO.CRE error: Inventory Item #1 (RING18.ITM) is not actually in inventory! Adding to Inventory Slot #22...

CENTEO.CRE error: Inventory Item #2 (WAND06.ITM) is not actually in inventory! Adding to Inventory Slot #23...

CENTEO.CRE error: Inventory Item #3 (MISC90.ITM) is not actually in inventory! Potentially quest-breaking item! Removing...

CENTEO.CRE error: Inventory Item #0 (SW2H06.ITM) is not actually in inventory! Adding to Inventory Slot #24...

 

Also, just to clarify something:

5) Yes, there is. But you don't use it, do you? No, it's not actually a fair game, it's an exploit.

Actually, I do set the unstealable flag when moving to inventory You'll find lines like these:

WRITE_BYTE  ("%itm_off%" + 0x10 + (0x14 * "%ref%")) ("%cre_flags%" BOR 0b00000010)

[Roxanne]

I have a major problem with these components

SETUP-LOLFIXER.TP2~ 0 9 // Item Stuff - Portrait Icon Assigner: 21102015 and 0 10 // Item Stuff -Proper Immunity Assigner: 21102015

 

I just did a BWS mega-mod install (all-you-can eat) to do a regression test for the Sandrah mods.

I found that my NPCs personal items have been tweaked beyond comprehension by that lolfixer item stuff thing.

There are loads of extra effects and capabilities assigned to the items that contradict the original intention.

 

What is the real intention of this component?

Is there a way to excempt items from its manipulations?

Edited by Roxanne, 02 November 2015 - 01:25 PM.

[The Imp]

I have a major problem with this component

SETUP-LOLFIXER.TP2~ 0 9 // Item Stuff - Portrait Icon Assigner

I just did a BWS mega-mod install (all-you-can eat) to do a regression test for the Sandrah mods.

I found that my NPCs personal items have been tweaked beyond comprehension by that lolfixer item stuff thing.

There are loads of extra effects and capabilities assigned to the items that contradict the original intention.

What is the real intention of this component?

Is there a way to excempt items from its manipulations?

If you change logged the items, upload them so Lollorian can take a look at them, there's likely something odd going on them after some mod that botches them.

[Roxanne]

I have a major problem with this component

SETUP-LOLFIXER.TP2~ 0 9 // Item Stuff - Portrait Icon Assigner

I just did a BWS mega-mod install (all-you-can eat) to do a regression test for the Sandrah mods.

I found that my NPCs personal items have been tweaked beyond comprehension by that lolfixer item stuff thing.

There are loads of extra effects and capabilities assigned to the items that contradict the original intention.

What is the real intention of this component?

Is there a way to excempt items from its manipulations?

If you change logged the items, upload them so Lollorian can take a look at them, there's likely something odd going on them after some mod that botches them.

Here are some example change-logs

The changes that really bother me are the final ones done by lolfixer - but Imp may be right that some mod before that did a change to trigger lolfixer's action.

 

EDIT

I took a deeper look into the changes made on the items prior lolfixer - although the number of effects is almost doubled from the original none of it has any impact (they are somehow redundant variations only). However what lolfixer does is, it takes all of these effects and adds a portrait item for them until you see nothing anymore of the NPC (it also does similar for other party members). This may have been the components original idea, it is just not working in conjunction with all these item/spell tweaking mods - you will not even be able to see when one of your NPCs or the PC gets injured or spell affected, everything is cluttered already.

I am still standing near Gorion's dead body with minimum equipment out of Candlekeep and PC has two portrait items, Imoen has three and Sandrah has five - just wait when we get real equipment,,,

Edited by Roxanne, 02 November 2015 - 02:37 PM.

[Fouinto]

I like this component !
The last time, I used it (maybe one year ago or such) it filled icons up to half of the portrait... but, if you don't like it... don't install it

[Roxanne]

I like this component !
The last time, I used it (maybe one year ago or such) it filled icons up to half of the portrait... but, if you don't like it... don't install it

This is not the point here.

When a modder creates a new item with some abilities, he/she assigns the effects for this item including the portrait items to be displayed or not not displayed. The changes of lolfixer here may be valid for vanilla game items but not for items created by other mods with some intention - on top of that some icons are not correct, Just do not try to outsmart the work of others - this is the point here.

This is not item fixing but item tweaking.

Edited by Roxanne, 03 November 2015 - 09:43 AM.

[The Imp]

Ahh...

This is not item fixing but item tweaking.

Yeah... a visual tweak-or-fix is an optional component. The ruling is "a little here, a little there" one.
Hmm, Lollorian, can you also make a counter component, one that removes all the display while wearing icons from the portrait view ?

[Fouinto]

This is not the point here.When a modder creates a new item with some abilities, he/she assigns the effects for this item including the portrait items to be displayed or not not displayed. The changes of lolfixer here may be valid for vanilla game items but not for items created by other mods with some intention - on top of that some icons are not correct, Just do not try to outsmart the work of others - this is the point here.

I disagree with you : this is the goal of modding : change (not only "improve" the way I or you think) what others have done.

This is not the point here.This is not item fixing but item tweaking.

OK, now, I think I understand the idea. And I agree

[Lollorian]

I'll probably take the lazy route and rename the component to 'Tweak' or something when I get around to it (sorry I've been travelling a while so can't exactly do code stuff )

 

Or maybe rename the mod to whatever but I think the BWS will need an small update and the BWP batches will break until Leonardo updates it

 

@Roxanne: Can you maybe elaborate on the "There are loads of extra effects and capabilities assigned to the items that contradict the original intention" bit please? Specifically:

 

- What extra effects (aside from the aforementioned portrait icons) are your items getting? the mod should be stripping duplicate and redundant effects not adding them

- Please don't consider this the wrong way, but I'd like to know the 'original intention' - I might be able to accommodate it with some shitty variable checks and stuff

 

Before and after examples of any added erroneous effects (with attachments) would be awesome

[Roxanne]

I'll probably take the lazy route and rename the component to 'Tweak' or something when I get around to it (sorry I've been travelling a while so can't exactly do code stuff )

 

Or maybe rename the mod to whatever but I think the BWS will need an small update and the BWP batches will break until Leonardo updates it

 

@Roxanne: Can you maybe elaborate on the "There are loads of extra effects and capabilities assigned to the items that contradict the original intention" bit please? Specifically:

 

- What extra effects (aside from the aforementioned portrait icons) are your items getting? the mod should be stripping duplicate and redundant effects not adding them

- Please don't consider this the wrong way, but I'd like to know the 'original intention' - I might be able to accommodate it with some shitty variable checks and stuff

 

Before and after examples of any added erroneous effects (with attachments) would be awesome

Sorry for the mess - I see the intention behind lolfixer and I think it does its stuff well in the majority of cases. Working with scripts and makros just sometimes fishes out something they should not.

After all the mods do their game with Sandrah's items her initial appearance in the game (in BG1) is like a Mellisan incarnation (Example ). When I give her the initial unchanged items, all is well (). One reason is how her items work together and are used by her script (which obviously cannot be detected by other mods).

So my very easy solution is to do just this in a BWS/BWP install, ie. install the mod, let all the other mods do their tweaks and then reinstall the few items that should not be changed by a little patch I posted here http://www.shsforums...37#entry582034.

Otherwise you would need to adjust Lolfixer everytime something changes in another mod (Sandrah is still beta tested) instead of letting thiis mod solve the problem by itself. (Or is there any method to excempt a file from being *corrected*?)

Edited by Roxanne, 04 November 2015 - 09:25 AM.

[Roxanne]

I'll probably take the lazy route and rename the component to 'Tweak' or something when I get around to it (sorry I've been travelling a while so can't exactly do code stuff )

 

Or maybe rename the mod to whatever but I think the BWS will need an small update and the BWP batches will break until Leonardo updates it

 

@Roxanne: Can you maybe elaborate on the "There are loads of extra effects and capabilities assigned to the items that contradict the original intention" bit please? Specifically:

 

- What extra effects (aside from the aforementioned portrait icons) are your items getting? the mod should be stripping duplicate and redundant effects not adding them

- Please don't consider this the wrong way, but I'd like to know the 'original intention' - I might be able to accommodate it with some shitty variable checks and stuff

 

Before and after examples of any added erroneous effects (with attachments) would be awesome

Sorry for the mess - I see the intention behind lolfixer and I think it does its stuff well in the majority of cases. Working with scripts and makros just sometimes fishes out something they should not.

After all the mods do their game with Sandrah's items her initial appearance in the game (in BG1) is like a Mellisan incarnation (Example SANRING_Tweaked.itm). When I give her the initial unchanged items, all is well (SANRING.ITM). One reason is how her items work together and are used by her script (which obviously cannot be detected by other mods).

So my very easy solution is to do just this in a BWS/BWP install, ie. install the mod, let all the other mods do their tweaks and then reinstall the few items that should not be changed by a little patch I posted here http://www.shsforums...37#entry582034.

Otherwise you would need to adjust Lolfixer everytime something changes in another mod (Sandrah is still beta tested) instead of letting thiis mod solve the problem by itself. (Or is there any method to excempt a file from being *corrected*?) And lastly, Lolfixer is applying its changes on files that have already been modified by four or five other mods before - so it is not your mod alone but the concerto of all these tweaks culmulating - and the result may be a different one in any possible constellation chosen for install.