68 replies to this topic

[Lollorian]

Grazie again!

Onto the AR0705 patching stuff:

Old code:

Spoiler

// ar0705
OUTER_SPRINT "name" "tz25nnpm"
OUTER_SET    "coordinate_x" = 1186
OUTER_SET    "coordinate_y" = 56    
OUTER_SET    "schedule1" = 0b11111111 // bitwise
OUTER_SET    "schedule2" = 0b11111111 // bitwise
OUTER_SET    "schedule3" = 0b11111111 // bitwise
OUTER_SET    "schedule4" = 0b11111111 // bitwise
OUTER_SPRINT "animation_bam" "tz25nnpm"
OUTER_SET    "sequence" = 0
OUTER_SET    "frame" = 0
OUTER_SET    "flag1"= 0b01000001 // bitwise
OUTER_SET    "flag2"= 0b00000001 // bitwise
OUTER_SET    "flag3"= 0b00000000 // bitwise, unknown
OUTER_SET    "flag4"= 0b00000000 // bitwise, unknown
OUTER_SET    "height" = 0
OUTER_SET    "transparency" = 0
OUTER_SET    "starting_frame" = 255 // 255 as default?
OUTER_SET    "loop_probability" = 0
OUTER_SET    "start_delay" = 0
OUTER_SPRINT "palette" "none"

COPY_EXISTING ~ar0705.are~ ~override~
  LAUNCH_PATCH_MACRO ~add_animation~
  BUT_ONLY_IF_IT_CHANGES

<<<<<<<< ...ts25mini-inlined/vertex.2da
1180 82
1225 53
1225 85
1180 114
>>>>>>>>

OUTER_SPRINT "name" "tz25nnp1"
OUTER_SET    "type" = 1
OUTER_SET    "bounding_box_left" = 1180
OUTER_SET    "bounding_box_top" = 53
OUTER_SET    "bounding_box_right" = 1225
OUTER_SET    "bounding_box_bottom" = 114
OUTER_SET    "adding_vertex_num" = 4
OUTER_SET    "cursor" = 22
OUTER_SPRINT "destination_area" "None"
OUTER_SPRINT "entrance_name" ""
OUTER_SET    "flag1" = 0b00000000 // bitwise
OUTER_SET    "flag2" = 0b00000000 // bitwise
OUTER_SET    "flag3" = 0b00000000 // bitwise unknown
OUTER_SET    "flag4" = 0b00000000 // bitwise unknown
OUTER_SPRINT "info_text" ""
OUTER_SET    "trap_detection_difficulty" = 0
OUTER_SET    "trap_removal_difficulty" = 0
OUTER_SET    "traped" = 0
OUTER_SET    "detected" = 0
OUTER_SET    "launch_point_x" = 1200
OUTER_SET    "launch_point_y" = 50
OUTER_SPRINT "key" ""
OUTER_SPRINT "script" "tz25nnp1"
OUTER_SET    "activation_point_x" = 0
OUTER_SET    "activation_point_y" = 0

COPY_EXISTING ~ar0705.are~ ~override~
  LAUNCH_PATCH_MACRO ~add_region~
  BUT_ONLY_IF_IT_CHANGES

<<<<<<<< ...ts25mini-inlined/vertex.2da
1180 82
1225 53
1225 85
1180 114
>>>>>>>>

OUTER_SPRINT "name" "tz25nnp2"
OUTER_SET    "type" = 1
OUTER_SET    "bounding_box_left" = 1180
OUTER_SET    "bounding_box_top" = 53
OUTER_SET    "bounding_box_right" = 1225
OUTER_SET    "bounding_box_bottom" = 114
OUTER_SET    "adding_vertex_num" = 4
OUTER_SET    "cursor" = 8
OUTER_SPRINT "destination_area" "None"
OUTER_SPRINT "entrance_name" ""
OUTER_SET    "flag1" = 0b00000000 // bitwise
OUTER_SET    "flag2" = 0b00000001 // bitwise
OUTER_SET    "flag3" = 0b00000000 // bitwise unknown
OUTER_SET    "flag4" = 0b00000000 // bitwise unknown
OUTER_SPRINT "info_text" ""
OUTER_SET    "trap_detection_difficulty" = 0
OUTER_SET    "trap_removal_difficulty" = 0
OUTER_SET    "traped" = 0
OUTER_SET    "detected" = 0
OUTER_SET    "launch_point_x" = 1200
OUTER_SET    "launch_point_y" = 50
OUTER_SPRINT "key" ""
OUTER_SPRINT "script" "tz25nnp2"
OUTER_SET    "activation_point_x" = 0
OUTER_SET    "activation_point_y" = 0

COPY_EXISTING ~ar0705.are~ ~override~
  LAUNCH_PATCH_MACRO ~add_region~
  BUT_ONLY_IF_IT_CHANGES

New code:

Spoiler

COPY_EXISTING ~ar0900.are~ ~override~
  LPF fj_add_are_structure
    INT_VAR
    fj_loc_x       = 1186
    fj_loc_y       = 56
    fj_flags       = 0b01000001000000010000000000000000
    STR_VAR
    fj_structure_type = animation
    fj_name           = tz25nnpm
    fj_bam_resref     = tz25nnpm
  END
  LPF fj_add_are_structure
    INT_VAR
    fj_type         = 1
    fj_box_left     = 1180
    fj_box_top      = 53
    fj_box_right    = 1225
    fj_box_bottom   = 114
    fj_cursor_idx   = 22
    fj_vertex_0     = 1180 + (82 << 16)
    fj_vertex_1     = 1225 + (53 << 16)
    fj_vertex_2     = 1225 + (85 << 16)
    fj_vertex_3     = 1180 + (114 << 16)
    fj_loc_x        = 1200
    fj_loc_y        = 50
    STR_VAR
    fj_structure_type   = region
    fj_name             = tz25nnp1
  END
  LPF fj_add_are_structure
    INT_VAR
    fj_type         = 1
    fj_box_left     = 1180
    fj_box_top      = 53
    fj_box_right    = 1225
    fj_box_bottom   = 114
    fj_cursor_idx   = 8
    fj_flags        = 0b00000000000000010000000000000000
    fj_vertex_0     = 1180 + (82 << 16)
    fj_vertex_1     = 1225 + (53 << 16)
    fj_vertex_2     = 1225 + (85 << 16)
    fj_vertex_3     = 1180 + (114 << 16)
    fj_loc_x        = 1200
    fj_loc_y        = 50
    STR_VAR
    fj_structure_type   = region
    fj_name             = tz25nnp2
    fj_reg_script        = tz25nnp2
  END

Things to note:
1) FPF 1 should prolly include the "schedule" variables like the original code has, but I couldn't find an example of how to schedule 4 times

2) LPF 3 has flags ... they're freaky (might just be the reason the original AR0400 area crashed cause I'd left out flags in its revised patching macro )

The AR0400 (originally crashing) region's flags go like so:

fj_flags        = 0b00000100000000110000000000000000

Recipe for disaster??

[Lollorian]

Awesome! So lesson(s) for today:
- Leading 0's are redundant
- Flags go topsy-turvy
- Can't have enough of hex

Using fj_are_struct.tpp from now on ... will try to get some more areas patchified soon

[Fennek]

I did some more testing. There was no ctd, the exit of TDD seems to exist (blue field on the sewer entrance) and the entrance added by TS25mini is also there. A bit problematic is, however, that it actually should be inaccessible (and not even shown as an exit) until a certain variable is set, so that one cannot go there (before some children finally lead one there to find a halfling). Now one can actually enter the building, just to find a halflig who "doesn't have anything to say to you", since the children are not supposed to go there (to start the dialog) until the exit becomes accessible for the player.

Edited by Fennek, 10 October 2010 - 02:54 AM.

[Lollorian]

Uh huh That might have something to do with the flags not being set Here's a fixed thingus ...

I had a look at the IEDSP and 0x304 stands for the NPC can't pass, Deactivated and Party Required flags Now there's also this flag (bit 6) called NPC can trigger which seems to be needed for this particular case but I'll let the gurus do the talking

Attached Files

•  setup-ts25mini.tp2   97.05K   268 downloads

[Hoppy]

Uh huh That might have something to do with the flags not being set Here's a fixed thingus ...

I had a look at the IEDSP and 0x304 stands for the NPC can't pass, Deactivated and Party Required flags Now there's also this flag (bit 6) called NPC can trigger which seems to be needed for this particular case but I'll let the gurus do the talking

Just use a trigger activation in the AR0400 script like TDD does. addario_assassin_den is the point of interest and we have:

IF
	!Global("adarioquests","GLOBAL",<img src='http://www.shsforums.net/public/style_emoticons/<#EMO_DIR#>/cool.gif' class='bbc_emoticon' alt='8)' />
	Global("adariogridcopper","GLOBAL",0)
THEN
	RESPONSE #100
		TriggerActivation("adario_assassin_den",FALSE)
		SetGlobal("adariogridcopper","GLOBAL",1)
		Continue()
END

IF
	Global("adarioquests","GLOBAL",<img src='http://www.shsforums.net/public/style_emoticons/<#EMO_DIR#>/cool.gif' class='bbc_emoticon' alt='8)' />
	Global("adariogridcopper","GLOBAL",1)
THEN
	RESPONSE #100
		TriggerActivation("adario_assassin_den",TRUE)
		SetGlobal("adariogridcopper","GLOBAL",2)
		Continue()
END

EDIT: Obviously you use the door you want closed and opened depending on your favorite global check related to the mod's quest et Voila!

Edited by Hoppy, 11 October 2010 - 12:45 PM.

[Fennek]

I cannot install component 5 with the new setup-file. I get an error regarding unknown function "fj_are_structure". And the additional file in the lib-folder is actually called "fj_add_are_struct" (so the "always include" command at the beginning also caused some problems until I changed it).

[Lollorian]

Oh yea I didn't up a pack with the awesome anon's new macro Shouldn't matter cause Miloch did say they're prolly the same thing Methinks the next WeiDU will probably include the MACRO built-in or something

Attached the fj_are_struct.tpp btw ... put into ts25mini/lib/ and use with the setup-ts25mini.tp2 attached a few posts back

Attached Files

•  fj_are_struct.tpp   46.17K   227 downloads

Edited by Lollorian, 14 October 2010 - 07:41 AM.

[Fennek]

When trying to install component 5 I now get told that there's a problem (parse error;(state 495) at PLUS; GLR parse error, near text "+") with line 244, column 1-60 of the new file

FOR( num = 0 ; VARIABLE_IS_SET EVAL ~fj_%value%_%num%~ ; ++num )BEGIN

I deleded one +, but nothing changed and I have no idea of the command anyway...

[Lollorian]

Unless you're somehow using an older WeiDU or something, that's a seriously freaky case I did install all the components with the new .tp2 and .tpp just a moment ago ... proof in the DEBUG attached

I deleded one +, but nothing changed and I have no idea of the command anyway...

That might not work

++n is shorthand for n=n+1 ... I think ...

Attached Files

•  SETUP-TS25MINI.7z   20.05K   191 downloads

Edited by Lollorian, 15 October 2010 - 08:11 AM.

[Fennek]

Clean installation was not up to date anymore... Weidu was 213... XXX... Installation worked fine. I also tested it ingame, entrance appears when it has to. Thanks a lot!
I guess one can throw this into the Fixpack now, to combine it with the other patch(s) for the setup-file.

Edited by Fennek, 15 October 2010 - 08:33 AM.

[Lollorian]

[psychlopes]

any chance this mod will be translated to English, since my German is non-existant.
انا لا اتكام اللغة الالمانية

[Fennek]

If anyone wants to translate Japanese-English or German-English, he should feel free to do so. My (not yet complete) German translation can be found in the fixpack (ts25mini/_copy/tra/German) and there are also the readme-files. If I first translate the mod to German and then to English, this might take until Christmas - next year...
(And it's always better if the translator translates into his native language...).

[Miloch]

++n is shorthand for n=n+1 ... I think ...

Should be += not ++ if that's what it's doing (i += 1 is i = i + 1). Dunno if ++ stands for anything in tp2 files (it's shorthand for dialogue file syntax but that's different).

[Wisp]

++n is shorthand for n=n+1 ... I think ...

Should be += not ++ if that's what it's doing (i += 1 is i = i + 1). Dunno if ++ stands for anything in tp2 files (it's shorthand for dialogue file syntax but that's different).

Lollorian is correct in that ++n means n+=1. It was introduced a few WeiDU versions ago.

[Miloch]

Lollorian is correct in that ++n means n+=1. It was introduced a few WeiDU versions ago.

Ah. So it's undocumented shorthand for documented shorthand that saves... a whole character? Might not quite win the "most useless shorthand" award, but it's probably in the top 10 .

[Wisp]

Ah. So it's undocumented shorthand for documented shorthand that saves... a whole character? Might not quite win the "most useless shorthand" award, but it's probably in the top 10 .

I don't know, I find it very convenient. ++ is a quick double tap whereas += is + plus shift-0 (at least on a Swedish keyboard).

Edited by Wisp, 18 October 2010 - 04:30 PM.

[Lollorian]

Ah. So it's undocumented shorthand for documented shorthand that saves... a whole character? Might not quite win the "most useless shorthand" award, but it's probably in the top 10 .

n++ is like magic, you add 1 to n but you don't specify the 1 ... it adds like magic! (there's also the thing that this is the basic unary increment operator in most languages but ... meh, magic rocks )