74 replies to this topic

[prowler]

Suggested fix (might need to be expanded for Spanish):
ALTER_TLK_LIST BEGIN 18268 18269 18272 END
BEGIN
REPLACE_TEXTUALLY ~!~ ~?~
END

How insert this code in tp2 file? My friend-modder told that he dont have a reference of how that ALTER_TLK_LIST function is used cause no BG mod uses it.
Near Text: ALTER_TLK_LIST syntax error

Edited by prowler, 14 April 2012 - 10:48 AM.

[prowler]

-Any weapon (e.g. zzz6bc.itm) that should have a damage/thac0 bonus vs. creatures per its description seem to miss these abilities effects, if you look at it using NI. It may be hardcoded in IWD, but how handles 'IWD in BG2' those?

Hm... I'm not a modder but I want to help 'cause IWD my favourite game.
What about IWD Redrake fixpack? Some items are changed by this mod.

E.g. (from readme) - Arrows of the hand were no different than the Arrows +2. I've changed this, so now Arrows of the hand offer +4 damage vs orcs
- Hellpick, according to its description was used to kill drow wizards. It seems logical to me that the weapon should have bonus against mages. Therefore, +5 damage vs mages.

Can you check this mod and it's damage/thac0 bonus vs. creatures?
http://forums.chosen...sa=view;down=22

Now you have suggestions for fix other items (zzz6bc.itm and others)?

It needs to be tested, whether the original game items get the mentioned effects applied hardcoded via the IWD engine.
A hint for a special handling could be, that all but 2(3?) file names for items in question starting with 'zz'.

I did some testing on this matter (used zzg7ts.itm 'Trollslayer' in ar7005.are to fight snow and ice trolls).

1. According to dialog window feedback the extra bonus to damage and hit seems to be applied correctly. Since NI doesn't show any of the mentioned effects attached, it must be hardcoded inside the IWD engine. So IWD is ok, but I think those items need some tweaking for IWDinBG2 (if not done already)...

2. The way Redrake's Fixpack applies extra boni to damage and hit for some items doesn't seems to work (and should not according to IESDP). It attaches effects 178 and 179 directly and utilized 'power' for the desired value. But the value has to go to paramter 3 and there is no way to set it using this method.
For testing, I made a copy of zzg7ts.itm and applied the effects the way Redrake's Fixpack did it and the feedback did not show any improvment in to hit or damage.

3. Now it gets wierd... I made another copy of zzg7ts.itm and applied effects 178 and 179 via effect 177, this method is used on original BG1/BG2 items. So far so good, after the first hit the boni get applied correctly (if the feedback is right). But... if you switch to a different weapon the boni stay and don't go away. Even if you fight a different creature with this weapon and than another troll, the boni return... In order to get rid of them, you need to reload a save game.
I think, that's why they didn't use effects 177/178/179 at all and there seems to be no easy way to make items that have damage/to hit boni vs. certain creatures.

And, if this has been already known, sorry for the spam

So all weapons '+ XX vs creatures' in Redrake IWD fixpack not work correctly?

Mike, I talk with Redrake and ask him to add your fixes in his mod. Are you give permission for that?

[Sasha Al'Therin]

For some reason the IWD Fixpack at G3 removes the HaveSpell check from d5hitort.bcs. the other 2 files are untouched.

In fact your change for d5yuanp2.bcs and d5yuanp3.bcs is redundant. they already have the proper HaveSpell checks in the blocks that the code would touch.

Their scripts have nothing for physical attacks only spell casting. It's possible the player's fight lasted long enough for the creatures to run out of spells. They only have 1-2 instances of each memorized.

This should be a no-action as far as fixes go. Unless these creatures are supposed to have physical attacks....

However IWD does have the ForceSpell & ReallyForceSpell actions so perhaps a tweak mod could drop the HaveSpell checks and change the Spell action into ForceSpell or ReallyForceSpell.

Had my games mixed up in the NI windows....

Original IWD unmodified (patched) has the HaveSpell checks IWD+HOW+TOTLM does not have the HaveSpell checks... The HaveSpell check was dropped with HOW if not HOW content then with HOW's latest patch sans ToTLM

Still it is possible that with the limited # of spells memorized by the creatures in question that the player experienced them running out of spells and with no physical attack scripting in place all they did was follow the blocks to keep them in range of the player.... small tiny block hard to see amidst all the others... AttackReevaluate in IWD+HOW+TOTLM AttackOneRound in IWD could be something with the timing of the reevaluation period of 75

the d5hitort.bcs is changed by G3 Fixpack from a Dead check into a StateCheck


With the BG Fixpack and changes between the two version I've learned a few things that you might want to utilize.
I'd change your code to cover some unforeseen possibilities:

Spoiler

//Yxunomei's High torturer and priests just follow you around
//without doing anything after casting their initial spells
//Add trigger HaveSpell(...) to several blocks in D5HITORT.BCS, D5YUANP2.BCS and D5YUANP3.BCS
PRINT ~Try to add trigger to several blocks in D5HITORT.BCS, D5YUANP2.BCS and D5YUANP3.BCS~

ACTION_FOR_EACH file IN ~d5hitort.bcs~ ~d5yuanp2.bcs~ ~d5yuanp3.bcs~ BEGIN
 ACTION_IF (FILE_EXISTS_IN_GAME ~%file%~) THEN BEGIN
  COPY_EXISTING ~%file%~ ~override~
   DECOMPILE_AND_PATCH BEGIN
    COUNT_REGEXP_INSTANCES CASE_INSENSITIVE EXACT_MATCH ~HaveSpell(CLERIC_SYMBOL_OF_PAIN)+See(NearestEnemyOf(Myself))~ tsp1
    PATCH_IF (tsp1 < 1) BEGIN
	 REPLACE_TEXTUALLY CASE_INSENSITIVE EXACT_MATCH ~THEN[%WNL%%TAB% ]+RESPONSE #100[%WNL%%TAB% ]+Spell(\(.+,\)\(.+)\)~ ~%TAB%HaveSpell(\2%WNL%THEN%WNL%%TAB%RESPONSE #100%WNL%%TAB%%TAB%Spell(\1\2~
    END
    COUNT_REGEXP_INSTANCES CASE_INSENSITIVE EXACT_MATCH ~HaveSpell(CLERIC_DISPEL_MAGIC)+See(NearestEnemyOf(Myself))~ tsp2
    PATCH_IF (tsp2 < 1) BEGIN
	 REPLACE_TEXTUALLY CASE_INSENSITIVE EXACT_MATCH ~THEN[%WNL%%TAB% ]+RESPONSE #100[%WNL%%TAB% ]+Spell(\(.+,\)\(.+)\)~ ~%TAB%HaveSpell(\2%WNL%THEN%WNL%%TAB%RESPONSE #100%WNL%%TAB%%TAB%Spell(\1\2~
    END
    COUNT_REGEXP_INSTANCES CASE_INSENSITIVE EXACT_MATCH ~HaveSpell(CLERIC_RECITATION)+!Global("YXUN_ATTACK","MYAREA",0)~ tsp3
    PATCH_IF (tsp3 < 1) BEGIN
	 REPLACE_TEXTUALLY CASE_INSENSITIVE EXACT_MATCH ~THEN[%WNL%%TAB% ]+RESPONSE #100[%WNL%%TAB% ]+Spell(\(.+,\)\(.+)\)~ ~%TAB%HaveSpell(\2%WNL%THEN%WNL%%TAB%RESPONSE #100%WNL%%TAB%%TAB%Spell(\1\2~
    END
    COUNT_REGEXP_INSTANCES CASE_INSENSITIVE EXACT_MATCH ~HaveSpell(CLERIC_PRAYER)+!Global("YXUN_ATTACK","MYAREA",0)~ tsp4
    PATCH_IF (tsp4 < 1) BEGIN
	 REPLACE_TEXTUALLY CASE_INSENSITIVE EXACT_MATCH ~THEN[%WNL%%TAB% ]+RESPONSE #100[%WNL%%TAB% ]+Spell(\(.+,\)\(.+)\)~ ~%TAB%HaveSpell(\2%WNL%THEN%WNL%%TAB%RESPONSE #100%WNL%%TAB%%TAB%Spell(\1\2~
    END
   END
  BUT_ONLY
 END
END
//what this does:
// will NOT make the change if the change doesn't need to be made
// covers the situation in case the file is not present for some reason.  they should be there but you never know...
// any of these cases will crap out the installer...

I haven't actually ran this yet to see if it does the job. It should tho. Nor do I have any IWD saves to even consider testing in game. uses latest weidu... (at least that's the weidu I have ^^ )

Edited by Sasha Al'Therin, 23 April 2012 - 05:12 PM.

[redrake]

So all weapons '+ XX vs creatures' in Redrake IWD fixpack not work correctly?

I did not test any items from Redrake's fixpack, I've just used its method to apply the effects to my test item. Maybe I overlooked something, but no, it did not work in my tests. And, if IESDP is right, it should not work...

Hello Mike,

From what remember when I designed (modified) those weapons I used the already in place system IWD1 used. Weapons like Trollkiller or Three White Doves use this system.
Also, I remember I've tested some of the weapons. Cradle of Mielikki for example, which in my mod grants 50% chances of slaying orcs, works as intended.

Maybe the the already in place IWD1 abilities never worked, though. I can't be sure.

[Sasha Al'Therin]

More work to do, but right now I'm not sure about the best way. Add the missing spells to the creatures or change scripts to use (Really)ForceSpell(..) in conjuction with some local spell sequence variable...

That becomes more the realm of tweaks as I don't think ALL would necessarily have the same spells memorized. I believe the script was intended as a general/race script for several creatures with different pre-memorized abilities.

Also if ALL had the same spells or had them using the ReallyForceSpell action then they'd never do any physical attacks as I believe ReallyForceSpell doesn't require the spells to be memorized.

If you do decide to go that route try adding in some randomness, this is an example from another mod which uses one of the spell actions to make a creature invisible and attempt a backstab. Since this spell action in the BG2 engine is always effective, the mod author wanted to give opportunities for it to fail and do other things.

Spoiler

IF
!GlobalTimerNotExpired("t-tk","LOCALS")
!StateCheck(Myself,STATE_INVISIBLE)
!StateCheck(Myself,STATE_IMPROVEDINVISIBILITY)
!Range(LastSeenBy(Myself),15)
HasItem("dagg05",Myself) // Throwing Dagger
THEN
RESPONSE #50
  SetGlobalTimer("t-tk","LOCALS",ONE_ROUND)
  SetInterrupt(FALSE)
  ApplySpell(Myself,THIEF_STEALTH)
  EquipMostDamagingMelee()
  MoveToObject(LastSeenBy(Myself))
  SetInterrupt(TRUE)
  Attack(LastSeenBy(Myself))
RESPONSE #25
  SetGlobalTimer("t-tk","LOCALS",3)
  DisplayString(Myself,17120) // Hide In Shadows Failed
  EquipRanged()
  Attack(LastSeenBy(Myself))
RESPONSE #25
  SetGlobalTimer("t-tk","LOCALS",ONE_ROUND)
  DisplayString(Myself,17120) // Hide In Shadows Failed
  RunAwayFromNoInterrupt(LastSeenBy(Myself),15)
END

At the very least you could code something up and offer it as an optional component...

[Sasha Al'Therin]

in that case if the scripts are specific to a specific creature then it isn't that much of a stretch to say that the spells were forgotten to be added when the scripts were made. Just be sure to state that that is the conclusion you came to when releasing (if you do) the mod. No need to do any scripting ninja work.

[prowler]

I did some testing on this matter (used zzg7ts.itm 'Trollslayer' in ar7005.are to fight snow and ice trolls).

1. According to dialog window feedback the extra bonus to damage and hit seems to be applied correctly. Since NI doesn't show any of the mentioned effects attached, it must be hardcoded inside the IWD engine. So IWD is ok, but I think those items need some tweaking for IWDinBG2 (if not done already)...

2. The way Redrake's Fixpack applies extra boni to damage and hit for some items doesn't seems to work (and should not according to IESDP). It attaches effects 178 and 179 directly and utilized 'power' for the desired value. But the value has to go to paramter 3 and there is no way to set it using this method.
For testing, I made a copy of zzg7ts.itm and applied the effects the way Redrake's Fixpack did it and the feedback did not show any improvment in to hit or damage.

3. Now it gets wierd... I made another copy of zzg7ts.itm and applied effects 178 and 179 via effect 177, this method is used on original BG1/BG2 items. So far so good, after the first hit the boni get applied correctly (if the feedback is right). But... if you switch to a different weapon the boni stay and don't go away. Even if you fight a different creature with this weapon and than another troll, the boni return... In order to get rid of them, you need to reload a save game.
I think, that's why they didn't use effects 177/178/179 at all and there seems to be no easy way to make items that have damage/to hit boni vs. certain creatures.

And, if this has been already known, sorry for the spam

Mike, have you found any solution for this?

[Ayrus]

When you speak to Hrothgar in the beginning of the game, at one point he says: "Don't really know.  The messenger wasn't too specific.  I suppose if you want more details you could ask old Everard over at the temple, but time's a-wasting.". But actually, the English voice says "I don't know.", not "Don't know".

...

Really . Not the biggest bug in the world, but anyway.

Also, I noticed that the new Item Upgrade version 4 has a folder called "delete for release". That probably shouldn't be there?

[hook71]

@Ayrus: Could you please post your bug report to the forum at Gibberlings 3.

[Ayrus]

@Ayrus: Could you please post your bug report to the forum at Gibberlings 3.

Actually, I tried it previously, but I got errors when posting the message. It said: "Content Encoding Error" "The page you are trying to view cannot be shown because it uses an invalid or unsupported form of compression." "Please contact the website owners to inform them of this problem.". I posted as a guest there, since I don't have an account there. I use Firefox 16.